wip

[Fix] avoid bash-specific syntax
Fixes #3499
2025-12-18 19:24:21 +08:00 · 2024-12-16 23:52:31 -08:00 · 2024-12-19 22:21:09 -08:00 · 2024-12-16 10:03:18 -08:00 · 2024-11-23 10:12:26 -10:00 · 2024-11-22 13:15:01 -10:00
13 changed files with 76 additions and 200 deletions
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -19,8 +19,6 @@ jobs:
            raw.githubusercontent.com:443
            registry.npmjs.org:443
      - uses: actions/checkout@v4
-        with:
-          fetch-tags: true
      - uses: actions/setup-node@v4
        with:
          node-version: "14"
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -31,8 +31,6 @@ jobs:
        suite:
          - install_script
          - sourcing
-          - slow
-          - installation_iojs
        shell:
          - sh
          - bash
--- a/.travis.yml
+++ b/.travis.yml
@@ -87,8 +87,18 @@ env:
    - SHELL=bash TEST_SUITE=fast
    - SHELL=zsh TEST_SUITE=fast
    #  - SHELL=ksh TEST_SUITE=fast
+    - SHELL=sh TEST_SUITE=slow
+    - SHELL=dash TEST_SUITE=slow
+    - SHELL=bash TEST_SUITE=slow
+    - SHELL=zsh TEST_SUITE=slow
+    #  - SHELL=ksh TEST_SUITE=slow
+    - SHELL=sh TEST_SUITE=installation_iojs
    - SHELL=sh TEST_SUITE=installation_iojs WITHOUT_CURL=1
+    - SHELL=dash TEST_SUITE=installation_iojs
    - SHELL=dash TEST_SUITE=installation_iojs WITHOUT_CURL=1
+    - SHELL=bash TEST_SUITE=installation_iojs
    - SHELL=bash TEST_SUITE=installation_iojs WITHOUT_CURL=1
+    - SHELL=zsh TEST_SUITE=installation_iojs
    - SHELL=zsh TEST_SUITE=installation_iojs WITHOUT_CURL=1
+    #  - SHELL=ksh TEST_SUITE=installation_iojs
    #  - SHELL=ksh TEST_SUITE=installation_iojs WITHOUT_CURL=1
--- a/18
+++ b/18
@@ -91,20 +91,16 @@ RUN echo 'nvm ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers
 # Switch to user "nvm" from now
 USER nvm

-# Create a script file sourced by both interactive and non-interactive bash shells
-ENV BASH_ENV /home/nvm/.bash_env
-RUN touch "$BASH_ENV"
-RUN echo '. "$BASH_ENV"' >> "$HOME/.bashrc"
-
 # nvm
-RUN echo 'export NVM_DIR="$HOME/.nvm"'                                       >> "$BASH_ENV"
-RUN echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> "$BASH_ENV"
-RUN echo '[ -s "$NVM_DIR/bash_completion" ] && . "$NVM_DIR/bash_completion" # This loads nvm bash_completion' >> "$BASH_ENV"
+RUN echo 'export NVM_DIR="$HOME/.nvm"'                                       >> "$HOME/.bashrc"
+RUN echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> "$HOME/.bashrc"
+RUN echo '[ -s "$NVM_DIR/bash_completion" ] && . "$NVM_DIR/bash_completion" # This loads nvm bash_completion' >> "$HOME/.bashrc"

 # nodejs and tools
-RUN nvm install node
-RUN npm install -g doctoc urchin eclint dockerfile_lint
-RUN npm install --prefix "$HOME/.nvm/"
+RUN bash -c 'source $HOME/.nvm/nvm.sh   && \
+    nvm install node                    && \
+    npm install -g doctoc urchin eclint dockerfile_lint && \
+    npm install --prefix "$HOME/.nvm/"'

 # Set WORKDIR to nvm directory
 WORKDIR /home/nvm/.nvm
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@
 </a>


-# Node Version Manager [![Build Status](https://app.travis-ci.com/nvm-sh/nvm.svg?branch=master)][3] [![nvm version](https://img.shields.io/badge/version-v0.40.2-yellow.svg)][4] [![CII Best Practices](https://bestpractices.dev/projects/684/badge)](https://bestpractices.dev/projects/684)
+# Node Version Manager [![Build Status](https://app.travis-ci.com/nvm-sh/nvm.svg?branch=master)][3] [![nvm version](https://img.shields.io/badge/version-v0.40.1-yellow.svg)][4] [![CII Best Practices](https://bestpractices.dev/projects/684/badge)](https://bestpractices.dev/projects/684)

 <!-- To update this table of contents, ensure you have run `npm install` then `npm run doctoc` -->
 <!-- START doctoc generated TOC please keep comment here to allow auto update -->
@@ -18,8 +18,6 @@
 - [Installing and Updating](#installing-and-updating)
  - [Install & Update Script](#install--update-script)
    - [Additional Notes](#additional-notes)
-    - [Installing in Docker](#installing-in-docker)
-      - [Installing in Docker for CICD-Jobs](#installing-in-docker-for-cicd-jobs)
    - [Troubleshooting on Linux](#troubleshooting-on-linux)
    - [Troubleshooting on macOS](#troubleshooting-on-macos)
    - [Ansible](#ansible)
@@ -104,13 +102,13 @@ nvm is a version manager for [node.js](https://nodejs.org/en/), designed to be i

 To **install** or **update** nvm, you should run the [install script][2]. To do that, you may either download and run the script manually, or use the following cURL or Wget command:
 ```sh
-curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
 ```
 ```sh
-wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
 ```

-Running either of the above commands downloads a script and runs it. The script clones the nvm repository to `~/.nvm`, and attempts to add the source lines from the snippet below to the correct profile file (`~/.bashrc`, `~/.bash_profile`, `~/.zshrc`, or `~/.profile`). If you find the install script is updating the wrong profile file, set the `$PROFILE` env var to the profile file’s path, and then rerun the installation script.
+Running either of the above commands downloads a script and runs it. The script clones the nvm repository to `~/.nvm`, and attempts to add the source lines from the snippet below to the correct profile file (`~/.bash_profile`, `~/.zshrc`, `~/.profile`, or `~/.bashrc`).

 <a id="profile_snippet"></a>
 ```sh
@@ -122,94 +120,14 @@ export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || pr

 - If the environment variable `$XDG_CONFIG_HOME` is present, it will place the `nvm` files there.</sub>

- You can add `--no-use` to the end of the above script to postpone using `nvm` until you manually [`use`](#usage) it:
-
-```sh
-export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")"
-[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" --no-use # This loads nvm, without auto-using the default version
-```
+- You can add `--no-use` to the end of the above script (...`nvm.sh --no-use`) to postpone using `nvm` until you manually [`use`](#usage) it.

 - You can customize the install source, directory, profile, and version using the `NVM_SOURCE`, `NVM_DIR`, `PROFILE`, and `NODE_VERSION` variables.
 Eg: `curl ... | NVM_DIR="path/to/nvm"`. Ensure that the `NVM_DIR` does not contain a trailing slash.

 - The installer can use `git`, `curl`, or `wget` to download `nvm`, whichever is available.

- You can instruct the installer to not edit your shell config (for example if you already get completions via a [zsh nvm plugin](https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/nvm)) by setting `PROFILE=/dev/null` before running the `install.sh` script. Here's an example one-line command to do that: `PROFILE=/dev/null bash -c 'curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash'`
-
-#### Installing in Docker
-
-When invoking bash as a non-interactive shell, like in a Docker container, none of the regular profile files are sourced. In order to use `nvm`, `node`, and `npm` like normal, you can instead specify the special `BASH_ENV` variable, which bash sources when invoked non-interactively.
-
-```Dockerfile
-# Use bash for the shell
-SHELL ["/bin/bash", "-o", "pipefail", "-c"]
-
-# Create a script file sourced by both interactive and non-interactive bash shells
-ENV BASH_ENV /home/user/.bash_env
-RUN touch "${BASH_ENV}"
-RUN echo '. "${BASH_ENV}"' >> ~/.bashrc
-
-# Download and install nvm
-RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | PROFILE="${BASH_ENV}" bash
-RUN echo node > .nvmrc
-RUN nvm install
-```
-
-##### Installing in Docker for CICD-Jobs
-
-More robust, works in CI/CD-Jobs. Can be run in interactive and non-interactive containers.
-See https://github.com/nvm-sh/nvm/issues/3531.
-
-```Dockerfile
-FROM ubuntu:latest
-ARG NODE_VERSION=20
-
-# install curl
-RUN apt update && apt install curl -y
-
-# install nvm
-RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
-
-# set env
-ENV NVM_DIR=/root/.nvm
-
-# install node
-RUN bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
-
-# set ENTRYPOINT for reloading nvm-environment
-ENTRYPOINT ["bash", "-c", "source $NVM_DIR/nvm.sh && exec \"$@\"", "--"]
-
-# set cmd to bash
-CMD ["/bin/bash"]
-
-```
-
-This example defaults to installation of nodejs version 20.x.y. Optionally you can easily override the version with docker build args like:
-```
-docker build -t nvmimage --build-arg NODE_VERSION=19 .
-```
-
-After creation of the image you can start container interactively and run commands, for example:
-```
-docker run --rm -it nvmimage
-
-root@0a6b5a237c14:/# nvm -v
-0.40.2
-
-root@0a6b5a237c14:/# node -v
-v19.9.0
-
-root@0a6b5a237c14:/# npm -v
-9.6.3
-```
-
-Noninteractive example:
-```
-user@host:/tmp/test $ docker run --rm -it nvmimage node -v
-v19.9.0
-user@host:/tmp/test $ docker run --rm -it nvmimage npm -v
-9.6.3
-```
+- You can instruct the installer to not edit your shell config (for example if you already get completions via a [zsh nvm plugin](https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/nvm)) by setting `PROFILE=/dev/null` before running the `install.sh` script. Here's an example one-line command to do that: `PROFILE=/dev/null bash -c 'curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash'`

 #### Troubleshooting on Linux

@@ -257,7 +175,7 @@ You can use a task:
 ```yaml
 - name: Install nvm
  ansible.builtin.shell: >
-    curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+    curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
  args:
    creates: "{{ ansible_env.HOME }}/.nvm/nvm.sh"
 ```
@@ -289,7 +207,7 @@ If you're running a system without prepackaged binary available, which means you
  - [bass](https://github.com/edc/bass) allows you to use utilities written for Bash in fish shell
  - [fast-nvm-fish](https://github.com/brigand/fast-nvm-fish) only works with version numbers (not aliases) but doesn't significantly slow your shell startup
  - [plugin-nvm](https://github.com/derekstavis/plugin-nvm) plugin for [Oh My Fish](https://github.com/oh-my-fish/oh-my-fish), which makes nvm and its completions available in fish shell
-  - [nvm.fish](https://github.com/jorgebucaran/nvm.fish) - The Node.js version manager you'll adore, crafted just for Fish
+  - [fnm](https://github.com/fisherman/fnm) - [fisherman](https://github.com/fisherman/fisherman)-based version manager for fish
  - [fish-nvm](https://github.com/FabioAntunes/fish-nvm) - Wrapper around nvm for fish, delays sourcing nvm until it's actually used.

 **Note:** We still have some problems with FreeBSD, because there is no official pre-built binary for FreeBSD, and building from source may need [patches](https://www.freshports.org/www/node/files/patch-deps_v8_src_base_platform_platform-posix.cc); see the issue ticket:
@@ -309,7 +227,7 @@ If you're running a system without prepackaged binary available, which means you

 Homebrew installation is not supported. If you have issues with homebrew-installed `nvm`, please `brew uninstall` it, and install it using the instructions below, before filing an issue.

-**Note:** If you're using `zsh` you can easily install `nvm` as a zsh plugin. Install [`zsh-nvm`](https://github.com/lukechilds/zsh-nvm) and run `nvm upgrade` to upgrade ([you can set](https://github.com/lukechilds/zsh-nvm#auto-use) `NVM_AUTO_USE=true` to have it automatically detect and use `.nvmrc` files).
+**Note:** If you're using `zsh` you can easily install `nvm` as a zsh plugin. Install [`zsh-nvm`](https://github.com/lukechilds/zsh-nvm) and run `nvm upgrade` to upgrade.

 **Note:** Git versions before v1.7 may face a problem of cloning `nvm` source from GitHub via https protocol, and there is also different behavior of git before v1.6, and git prior to [v1.17.10](https://github.com/git/git/commit/5a7d5b683f869d3e3884a89775241afa515da9e7) can not clone tags, so the minimum required git version is v1.7.10. If you are interested in the problem we mentioned here, please refer to GitHub's [HTTPS cloning errors](https://help.github.com/articles/https-cloning-errors/) article.

@@ -319,7 +237,7 @@ If you have `git` installed (requires git v1.7.10+):

 1. clone this repo in the root of your user profile
    - `cd ~/` from anywhere then `git clone https://github.com/nvm-sh/nvm.git .nvm`
-1. `cd ~/.nvm` and check out the latest version with `git checkout v0.40.2`
+1. `cd ~/.nvm` and check out the latest version with `git checkout v0.40.1`
 1. activate `nvm` by sourcing it from your shell: `. ./nvm.sh`

 Now add these lines to your `~/.bashrc`, `~/.profile`, or `~/.zshrc` file to have it automatically sourced upon login:
@@ -670,7 +588,9 @@ Run [`npx nvmrc`](https://npmjs.com/nvmrc) to validate an `.nvmrc` file. If that

 ### Deeper Shell Integration

-You can use [`nvshim`](https://github.com/iamogbz/nvshim) to shim the `node`, `npm`, and `npx` bins to automatically use the `nvm` config in the current directory. `nvshim` is **not** supported by the `nvm` maintainers. Please [report issues to the `nvshim` team](https://github.com/iamogbz/nvshim/issues/new).
+You can use [`avn`](https://github.com/wbyoung/avn) to deeply integrate into your shell and automatically invoke `nvm` when changing directories. `avn` is **not** supported by the `nvm` maintainers. Please [report issues to the `avn` team](https://github.com/wbyoung/avn/issues/new).
+
+You can also use [`nvshim`](https://github.com/iamogbz/nvshim) to shim the `node`, `npm`, and `npx` bins to automatically use the `nvm` config in the current directory. `nvshim` is **not** supported by the `nvm` maintainers. Please [report issues to the `nvshim` team](https://github.com/iamogbz/nvshim/issues/new).

 If you prefer a lighter-weight solution, the recipes below have been contributed by `nvm` users. They are **not** supported by the `nvm` maintainers. We are, however, accepting pull requests for more examples.

@@ -765,8 +685,6 @@ add-zsh-hook chpwd load-nvmrc
 load-nvmrc
 ```

-After saving the file, run `source ~/.zshrc` to reload the configuration with the latest changes made.
-
 ##### fish

 This requires that you have [bass](https://github.com/edc/bass) installed.
@@ -890,7 +808,7 @@ my_alias        default        v10.22.0       v12.18.3      v14.8.0

 ## Compatibility Issues

-`nvm` will encounter some issues if you have some non-default settings set. (see [#606](https://github.com/nvm-sh/nvm/issues/606))
+`nvm` will encounter some issues if you have some non-default settings set. (see [#606](https://github.com/creationix/nvm/issues/606))
 The following are known to cause issues:

 Inside `~/.npmrc`:
@@ -925,13 +843,13 @@ If installing nvm on Alpine Linux *is* still what you want or need to do, you sh
 ### Alpine Linux 3.13+
 ```sh
 apk add -U curl bash ca-certificates openssl ncurses coreutils python3 make gcc g++ libgcc linux-headers grep util-linux binutils findutils
-curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
 ```

 ### Alpine Linux 3.5 - 3.12
 ```sh
 apk add -U curl bash ca-certificates openssl ncurses coreutils python2 make gcc g++ libgcc linux-headers grep util-linux binutils findutils
-curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
 ```

 _Note: Alpine 3.5 can only install NodeJS versions up to v6.9.5, Alpine 3.6 can only install versions up to v6.10.3, Alpine 3.7 installs versions up to v8.9.3, Alpine 3.8 installs versions up to v8.14.0, Alpine 3.9 installs versions up to v10.19.0, Alpine 3.10 installs versions up to v10.24.1, Alpine 3.11 installs versions up to v12.22.6, Alpine 3.12 installs versions up to v12.22.12, Alpine 3.13 & 3.14 install versions up to v14.20.0, Alpine 3.15 & 3.16 install versions up to v16.16.0 (**These are all versions on the main branch**). Alpine 3.5 - 3.12 required the package `python2` to build NodeJS, as they are older versions to build. Alpine 3.13+ requires `python3` to successfully build newer NodeJS versions, but you can use `python2` with Alpine 3.13+ if you need to build versions of node supported in Alpine 3.5 - 3.15, you just need to specify what version of NodeJS you need to install in the package install script._
@@ -1034,9 +952,9 @@ You have to make sure that the user directory name in `$HOME` and the user direc
 To change the user directory and/or account name follow the instructions [here](https://support.apple.com/en-us/HT201548)

 [1]: https://github.com/nvm-sh/nvm.git
-[2]: https://github.com/nvm-sh/nvm/blob/v0.40.2/install.sh
+[2]: https://github.com/nvm-sh/nvm/blob/v0.40.1/install.sh
 [3]: https://app.travis-ci.com/nvm-sh/nvm
-[4]: https://github.com/nvm-sh/nvm/releases/tag/v0.40.2
+[4]: https://github.com/nvm-sh/nvm/releases/tag/v0.40.1
 [Urchin]: https://git.sdf.org/tlevine/urchin
 [Fish]: https://fishshell.com

@@ -1094,7 +1012,7 @@ Here's what you will need to do:
  If one of these broken versions is installed on your system, the above step will likely still succeed even if you didn't include the `--shared-zlib` flag.
  However, later, when you attempt to `npm install` something using your old version of node.js, you will see `incorrect data check` errors.
  If you want to avoid the possible hassle of dealing with this, include that flag.
-  For more details, see [this issue](https://github.com/nodejs/node/issues/39313) and [this comment](https://github.com/nodejs/node/issues/39313#issuecomment-90.40.276)
+  For more details, see [this issue](https://github.com/nodejs/node/issues/39313) and [this comment](https://github.com/nodejs/node/issues/39313#issuecomment-90.40.176)

 - Exit back to your native shell.

@@ -1121,7 +1039,7 @@ Now you should be able to use node as usual.
 If you've encountered this error on WSL-2:

  ```sh
-  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash
+  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                  Dload  Upload  Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0curl: (6) Could not resolve host: raw.githubusercontent.com
@@ -1156,7 +1074,7 @@ Currently, the sole maintainer is [@ljharb](https://github.com/ljharb) - more ma

 ## Project Support

-Only the latest version (v0.40.2 at this time) is supported.
+Only the latest version (v0.40.1 at this time) is supported.

 ## Enterprise Support

@@ -1170,5 +1088,6 @@ See [LICENSE.md](./LICENSE.md).

 ## Copyright notice

-Copyright [OpenJS Foundation](https://openjsf.org) and `nvm` contributors. All rights reserved. The [OpenJS Foundation](https://openjsf.org) has registered trademarks and uses trademarks.  For a list of trademarks of the [OpenJS Foundation](https://openjsf.org), please see our [Trademark Policy](https://trademark-policy.openjsf.org/) and [Trademark List](https://trademark-list.openjsf.org/).  Trademarks and logos not indicated on the [list of OpenJS Foundation trademarks](https://trademark-list.openjsf.org) are trademarks™ or registered® trademarks of their respective holders. Use of them does not imply any affiliation with or endorsement by them.
-[The OpenJS Foundation](https://openjsf.org/) | [Terms of Use](https://terms-of-use.openjsf.org/) | [Privacy Policy](https://privacy-policy.openjsf.org/) | [Bylaws](https://bylaws.openjsf.org/) | [Code of Conduct](https://code-of-conduct.openjsf.org) | [Trademark Policy](https://trademark-policy.openjsf.org/) | [Trademark List](https://trademark-list.openjsf.org/) | [Cookie Policy](https://www.linuxfoundation.org/cookies/)
+Copyright [OpenJS Foundation](https://openjsf.org) and `nvm` contributors. All rights reserved. The [OpenJS Foundation](https://openjsf.org) has registered trademarks and uses trademarks.  For a list of trademarks of the [OpenJS Foundation](https://openjsf.org), please see our [Trademark Policy](https://trademark-policy.openjsf.org/) and [Trademark List](https://trademark-list.openjsf.org/).  Node.js is a trademark of Joyent, Inc. and is used with its permission.  Trademarks and logos not indicated on the [list of OpenJS Foundation trademarks](https://trademark-list.openjsf.org) are trademarks™ or registered® trademarks of their respective holders. Use of them does not imply any affiliation with or endorsement by them.
+
+[The OpenJS Foundation](https://openjsf.org/) | [Terms of Use](https://terms-of-use.openjsf.org/) | [Privacy Policy](https://privacy-policy.openjsf.org/) | [OpenJS Foundation Bylaws](https://bylaws.openjsf.org/) | [Trademark Policy](https://trademark-policy.openjsf.org/) | [Trademark List](https://trademark-list.openjsf.org/) | [Cookie Policy](https://www.linuxfoundation.org/cookies/)
--- a/install.sh
+++ b/install.sh
@@ -33,7 +33,7 @@ nvm_install_dir() {
 }

 nvm_latest_version() {
-  nvm_echo "v0.40.2"
+  nvm_echo "v0.40.1"
 }

 nvm_profile_is_bash_or_zsh() {
--- a/nvm.sh
+++ b/nvm.sh
@@ -136,17 +136,15 @@ nvm_download() {
    eval "curl -q --fail ${CURL_COMPRESSED_FLAG:-} ${CURL_HEADER_FLAG:-} ${NVM_DOWNLOAD_ARGS}"
  elif nvm_has "wget"; then
    # Emulate curl with wget
-    ARGS=$(nvm_echo "$@" | command sed "
-      s/--progress-bar /--progress=bar /
-      s/--compressed //
-      s/--fail //
-      s/-L //
-      s/-I /--server-response /
-      s/-s /-q /
-      s/-sS /-nv /
-      s/-o /-O /
-      s/-C - /-c /
-    ")
+    ARGS=$(nvm_echo "$@" | command sed -e 's/--progress-bar /--progress=bar /' \
+                            -e 's/--compressed //' \
+                            -e 's/--fail //' \
+                            -e 's/-L //' \
+                            -e 's/-I /--server-response /' \
+                            -e 's/-s /-q /' \
+                            -e 's/-sS /-nv /' \
+                            -e 's/-o /-O /' \
+                            -e 's/-C - /-c /')

    if [ -n "${NVM_AUTH_HEADER:-}" ]; then
      ARGS="${ARGS} --header \"${NVM_AUTH_HEADER}\""
@@ -1415,11 +1413,11 @@ nvm_add_iojs_prefix() {
 nvm_strip_iojs_prefix() {
  local NVM_IOJS_PREFIX
  NVM_IOJS_PREFIX="$(nvm_iojs_prefix)"
-
-  case "${1-}" in
-    "${NVM_IOJS_PREFIX}") nvm_echo ;;
-    *) nvm_echo "${1#"${NVM_IOJS_PREFIX}"-}" ;;
-  esac
+  if [ "${1-}" = "${NVM_IOJS_PREFIX}" ]; then
+    nvm_echo
+  else
+    nvm_echo "${1#"${NVM_IOJS_PREFIX}"-}"
+  fi
 }

 nvm_ls() {
@@ -1551,15 +1549,12 @@ nvm_ls() {
  fi

  if [ "${NVM_ADD_SYSTEM-}" = true ]; then
-    case "${PATTERN}" in
-      '' | v)
-        VERSIONS="${VERSIONS}
+    if [ -z "${PATTERN}" ] || [ "${PATTERN}" = 'v' ]; then
+      VERSIONS="${VERSIONS}
 system"
-      ;;
-      system)
-        VERSIONS="system"
-      ;;
-    esac
+    elif [ "${PATTERN}" = 'system' ]; then
+      VERSIONS="system"
+    fi
  fi

  if [ -z "${VERSIONS}" ]; then
@@ -1693,7 +1688,7 @@ EOF
    LTS="${LTS#lts/}"
  fi

-  VERSIONS="$( { command awk -v lts="${LTS-}" '{
+  VERSIONS="$({ command awk -v lts="${LTS-}" '{
        if (!$1) { next }
        if (lts && $10 ~ /^\-?$/) { next }
        if (lts && lts != "*" && tolower($10) !~ tolower(lts)) { next }
@@ -2073,11 +2068,6 @@ nvm_get_arch() {
  local EXIT_CODE
  local LONG_BIT

-  if [ -n "$NVM_NODEJS_ORG_ARCH" ]; then
-    nvm_echo "${NVM_NODEJS_ORG_ARCH}"
-    return
-  fi
-
  NVM_OS="$(nvm_get_os)"
  # If the OS is SunOS, first try to use pkgsrc to guess
  # the most appropriate arch. If it's not available, use
@@ -2742,10 +2732,10 @@ nvm_npm_global_modules() {
  local NPMLIST
  local VERSION
  VERSION="$1"
-  NPMLIST=$(nvm use "${VERSION}" >/dev/null && npm list -g --depth=0 2>/dev/null | command sed -e '1d' -e '/UNMET PEER DEPENDENCY/d')
+  NPMLIST=$(nvm use "${VERSION}" >/dev/null && npm list -g --depth=0 2>/dev/null | command sed 1,1d | nvm_grep -v 'UNMET PEER DEPENDENCY')

  local INSTALLS
-  INSTALLS=$(nvm_echo "${NPMLIST}" | command sed -e '/ -> / d' -e '/\(empty\)/ d' -e 's/^.* \(.*@[^ ]*\).*/\1/' -e '/^npm@[^ ]*.*$/ d' -e '/^corepack@[^ ]*.*$/ d' | command xargs)
+  INSTALLS=$(nvm_echo "${NPMLIST}" | command sed -e '/ -> / d' -e '/\(empty\)/ d' -e 's/^.* \(.*@[^ ]*\).*/\1/' -e '/^npm@[^ ]*.*$/ d' | command xargs)

  local LINKS
  LINKS="$(nvm_echo "${NPMLIST}" | command sed -n 's/.* -> \(.*\)/\1/ p')"
@@ -4443,7 +4433,7 @@ nvm() {
      NVM_VERSION_ONLY=true NVM_LTS="${NVM_LTS-}" nvm_remote_version "${PATTERN:-node}"
    ;;
    "--version" | "-v")
-      nvm_echo '0.40.2'
+      nvm_echo '0.40.1'
    ;;
    "unload")
      nvm deactivate >/dev/null 2>&1
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "nvm",
-  "version": "0.40.2",
+  "version": "0.40.1",
  "description": "Node Version Manager - Simple bash script to manage multiple active node.js versions",
  "directories": {
    "test": "test"
@@ -45,9 +45,9 @@
    "dockerfile_lint": "^0.3.4",
    "doctoc": "^2.2.1",
    "eclint": "^2.8.1",
-    "markdown-link-check": "^3.13.7",
+    "markdown-link-check": "^3.12.2",
    "replace": "^1.2.2",
-    "semver": "^7.7.1",
+    "semver": "^7.6.3",
    "urchin": "^0.0.5"
  }
 }
--- a/exec/Preamble
+++ b/exec/Preamble
--- a/reinstall-packages/should
+++ b/reinstall-packages/should
@@ -16,7 +16,7 @@ EXPECTED_PACKAGES_INSTALL="autoprefixer bower david@11 grunt-cli grunth-cli http
 echo "$EXPECTED_PACKAGES_INSTALL" | sed -e 's/test-npmlink //' | xargs npm install -g --quiet

 get_packages() {
-  npm list -g --depth=0 | \sed -e '1 d' -e 's/^.* \(.*\)@.*/\1/' -e '/^npm$/ d' -e '/^corepack$/ d' | xargs
+  npm list -g --depth=0 | \sed -e '1 d' -e 's/^.* \(.*\)@.*/\1/' -e '/^npm$/ d' | xargs
 }

 nvm use 0.10.29
--- a/reinstall-packages/works
+++ b/reinstall-packages/works
@@ -5,7 +5,7 @@ die () { echo "$@" ; exit 1; }
 \. ../../../nvm.sh

 get_packages() {
-  npm list -g --depth=0 | \sed -e '1 d' -e 's/^.* \(.*\)@.*/\1/' -e '/^npm$/ d' -e '/^corepack$/ d' | xargs
+  npm list -g --depth=0 | \sed -e '1 d' -e 's/^.* \(.*\)@.*/\1/' -e '/^npm$/ d' | xargs
 }

 nvm use 4.7.2
@@ -14,14 +14,5 @@ ORIGINAL_PACKAGES=$(get_packages)
 nvm reinstall-packages 4.7.1
 FINAL_PACKAGES=$(get_packages)

-[ -z "${ORIGINAL_PACKAGES}" ] || die "v4: original packages were not empty: ${ORIGINAL_PACKAGES}"
-[ -z "${FINAL_PACKAGES}" ] || die "v4: final packages were not empty: ${FINAL_PACKAGES}"
-
-nvm use 23.8.20
-ORIGINAL_PACKAGES=$(get_packages)
-
-nvm reinstall-packages 23.8.0
-FINAL_PACKAGES=$(get_packages)
-
-[ -z "${ORIGINAL_PACKAGES}" ] || die "v23: original packages were not empty: ${ORIGINAL_PACKAGES}"
-[ -z "${FINAL_PACKAGES}" ] || die "v23: final packages were not empty: ${FINAL_PACKAGES}"
+[ -z "${ORIGINAL_PACKAGES}" ] || die "original packages were not empty: ${ORIGINAL_PACKAGES}"
+[ -z "${FINAL_PACKAGES}" ] || die "final packages were not empty: ${FINAL_PACKAGES}"
--- a/test/slow/nvm
+++ b/test/slow/nvm
@@ -1,28 +0,0 @@
-#!/bin/sh
-
-set -ex
-
-die () { echo "$@" ; exit 1; }
-
-. ../../../nvm.sh
-
-echo "0.10.7" > .nvmrc
-
-# Check nvm run without --silent
-OUTPUT="$(nvm run --version)"
-EXPECTED_OUTPUT="Found '${PWD}/.nvmrc' with version <0.10.7>
-Running node v0.10.7 (npm v1.2.21)
-v0.10.7"
-[ ">${OUTPUT}<" = ">${EXPECTED_OUTPUT}<" ] \
-  || die "\`nvm run\` failed to run; did not match with the .nvmrc version; got >${OUTPUT}<"
-
-OUTPUT="$(nvm run --silent --version)"
-EXPECTED_OUTPUT="v0.10.7"
-[ "${OUTPUT}" = "${EXPECTED_OUTPUT}" ] \
-  || die "\`nvm run --silent\` failed to run silently; expected no output, got >${OUTPUT}<"
-
-# Output shouldn't be silent if --silent flag is not at the third argument position
-OUTPUT="$(nvm run --version --silent)"
-EXPECTED_OUTPUT=""
-[ "${OUTPUT}" != "${EXPECTED_OUTPUT}" ] \
-  || die "\`nvm run --version --silent\` should not be silent; expected >${OUTPUT}<, got no output"
--- a/uninstall/Running
+++ b/uninstall/Running
@@ -6,7 +6,7 @@ die () { echo "$@" ; exit 1; }
 \. ../../../nvm.sh

 # Version to install/uninstall
-NVM_TEST_VERSION=5.10.1
+NVM_TEST_VERSION=15.5.0

 # Make sure it's not already here
 [ -e ../../../$NVM_TEST_VERSION ] && rm -R ../../../$NVM_TEST_VERSION
@@ -19,7 +19,9 @@ nvm ls | grep "$NVM_TEST_VERSION" || die "Failed to install node"

 # Install global module as root
 npm_path=$(which npm)
-sudo -n "$npm_path" install jspm@'<2' -g || die 'either sudo failed, or `npm install jspm -g` failed`'
+nvm_err "${PATH}"
+PATH="${PATH}" sudo -n echo "${PATH}" || die 'sudo echo failed'
+PATH="${PATH}" sudo -n "$npm_path" install jspm@'<2' -g || die 'either sudo failed, or `npm install jspm -g` failed`'

 # Switch to another version so we can uninstall
 nvm use 0.12.7
Author	SHA1	Message	Date
Jordan Harband	d4cc592ff1	wip	2024-12-16 23:52:31 -08:00
Jordan Harband	c8b55175dc	[Fix] avoid bash-specific syntax Fixes #3499	2024-12-19 22:21:09 -08:00
Jordan Harband	db0b085965	[Fix] `install-latest-npm`: npm v11 is out	2024-12-16 10:03:18 -08:00
Jordan Harband	206302caad	[Tests] ensure `node` can be found by npm	2024-11-23 10:12:26 -10:00
Jordan Harband	42a5175402	[Tests] use a newer node version for this test to avoid flakiness	2024-11-22 13:15:01 -10:00
Jordan Harband	02795cd71d	[actions] TOC: use latest LTS node	2024-11-22 21:44:36 -10:00
Jordan Harband	0641363102	[Tests] `install.sh`: clean up `nvm_detect_profile` tests	2024-11-08 10:52:41 +00:00
Jordan Harband	9659af6c16	[Tests] `nvm_detect_profile`: refactor	2024-11-12 13:31:36 -08:00
menaechmi	abd02e5aae	[Fix] `install.sh`: fix failing install tests (#3458 )	2024-11-12 11:57:02 -06:00
menaechmi	3de0b15810	[Tests] run urchin tests on pull requests	2024-11-12 12:58:53 -06:00
menaechmi	cd22c84026	[New] `install.sh`: add `$ZDOTDIR` to zsh search Fixes #3128	2024-11-06 16:53:58 -06:00
Jordan Harband	d648a3b1ba	[meta] add DCO imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in https://github.com/expressjs/express/pull/6048 See https://github.com/openjs-foundation/project-status/issues/2	2024-11-05 17:51:39 +00:00
Jordan Harband	ccf6d16017	[meta] disable blank issues	2024-11-04 15:07:16 +00:00
Jordan Harband	ba98270442	[meta] update issue template	2024-11-04 15:01:26 +00:00
Jordan Harband	1be4257e96	[Tests] update mocks	2024-10-31 14:23:36 -07:00
Cheerag Patel	9c9ff4bac0	[meta] Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md Moved issue template into ISSUE_TEMPLATE folder	2024-10-30 14:03:05 -07:00
Jordan Harband	51ea809d63	[Tests] ensure that unit tests use only mocked LTS names	2024-10-30 23:41:50 -07:00
Jordan Harband	6b70c40f15	[Fix] `nvm_install_latest_npm`: avoid unbound variable Fixes #3447	2024-10-22 22:02:01 -07:00
Reetik Rajan	5dc31ac51b	[patch] give a more helpful message when `lts` alias is mistakenly used	2024-10-05 09:21:42 +05:30
Jordan Harband	da2720a429	[Fix] `nvm ls`, `nvm alias`, `nvm install`: error when an LTS name is invalid	2024-09-04 13:55:11 -07:00
Jordan Harband	9fb9dec710	[Fix] `nvm_normalize_lts`: error when an LTS name is not lowercase Fixes #3417	2024-09-04 13:54:41 -07:00
Jordan Harband	9a28dbd394	[actions] use `node/install` instead of `node/run`	2024-08-28 11:28:52 -07:00
Jordan Harband	179d45050b	v0.40.1	2024-08-27 13:44:15 -07:00
Jordan Harband	ff7634577b	[Tests] fix broken tests exposed by `863bd63` Leaves 2 non-executable, + some TODOs	2024-08-27 12:46:40 -07:00
Jordan Harband	0ce8f5a52f	[Fix] `nvm_download`: ensure all args are quoted Fixes #3411.	2024-08-20 22:33:38 -07:00
Jordan Harband	863bd63cfa	[Tests] set proper permissions on test files	2024-08-23 17:23:12 -07:00
Jordan Harband	0d53381666	[Tests] move sourcing suite to GHA	2024-08-22 13:30:55 -07:00
Jordan Harband	df70535248	[Fix] `nvm_auto`: Fix bug introduced in `c31a867`	2024-08-21 10:54:19 -07:00
Jordan Harband	c31a867c46	[Fix] `--save`: avoid a conflict with `set -e` Fixes #3405.	2024-08-10 15:52:24 +12:00
Jordan Harband	a8c418558a	[Refactor] `--save`: clean up some usage	2024-08-20 16:21:45 -07:00
Jordan Harband	d5e2c92a25	[Fix] `nvm_has_colors`: avoid an aliased `tput` Fixes #3413	2024-08-20 09:23:45 -07:00
Jordan Harband	81f18bc445	[patch] `install.sh`: fix node capitalization	2024-08-09 13:46:16 +12:00
Jordan Harband	4beab63631	[Fix] declare an unbound variable Fixes #3402	2024-08-07 17:38:37 +12:00
Jordan Harband	14acd3dcdd	[Fix] `nvm install -b`: do not attempt to download source on a failed binary download with `-b` Fixes #3399	2024-08-01 10:35:37 -07:00
Jordan Harband	271720ebfc	[Fix] `nvm install -b`: when no binary is available, fail and output a clear message	2024-08-01 13:57:22 -07:00
Jordan Harband	423ee82b4c	[Tests] fix `nvm ls-remote` unit test	2024-08-01 10:22:28 -07:00
Jordan Harband	deac4e0932	v0.40.0	2024-07-30 12:50:18 -07:00
Jordan Harband	b5118ac365	[Dev Deps] update `semver`	2024-07-30 11:35:15 -07:00
Jordan Harband	24deac7ac5	[readme] add OpenJS Ecosystem Sustainability Program partner - https://openjsf.org/ecosystem-sustainability-program	2024-07-30 10:08:48 -07:00
Jordan Harband	ff1257e8e3	[Refactor] `nvm_has_colors`: also check the env var	2024-07-28 18:01:14 -07:00
Jordan Harband	87a709741f	[Fix] `nvm_get_default_packages`: use `awk` for more reliable file processing See `db19450caa` Fixes #3382	2024-07-28 10:02:08 -07:00
Martin	f439acda4a	[New] `nvm use`/`nvm install`: add `--save` option Fixes #2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>	2022-08-29 16:01:36 +01:00
Ally Summers	dd89af53f5	[patch] Fix issue where zsh global aliases would break nvm help Fix issue with the color codes in the nvm help text where zsh global aliases would display an inline error in the nvm help text.	2024-07-26 03:35:55 +10:00
David Welch	bd090ef7f8	[New] Add support for `NVM_AUTH_HEADER` env var Closes #3366 Co-authored-by: David Welch <david@davidwelch.co> Co-authored-by: Andre Kradolfer <narfdre@gmail.com>	2024-06-21 08:55:22 -06:00
Jordan Harband	4c7d899447	[Tests] ignore travis-ci env vars; improve debug output	2024-07-26 12:04:07 -07:00
Andre Kradolfer	80cb39d712	[debug] adding logging to makefile	2024-07-22 14:07:07 -06:00
Jordan Harband	93277112ae	[Fix] `install-latest-npm`: npm ^8.7 breaks `npm ls` with file: deps	2024-07-26 09:16:03 -07:00
Jordan Harband	762f9ef9d1	[Tests] only install python 2.7 if not already installed See `ee6f7667` / #3067	2024-07-06 10:29:55 -05:00
Jordan Harband	e597bb208e	[Tests] use a better JSON parsing implementation	2024-06-10 11:33:12 -07:00
Jordan Harband	aa427ad396	[Tests] ensure travis can access public repo submodules	2024-06-10 09:15:16 -07:00
Jordan Harband	c20db2ab86	[actions] improve default action permissions	2024-06-10 08:59:48 -07:00
Jordan Harband	29dce5edfd	[New] allow `.nvmrc` files to support comments In theory, `npx nvmrc` can now be used to validate an `.nvmrc` file that `nvm` will support. Allowances have been made for future extensibility, and aliases may no longer contain a `#`. Fixes #3336. Closes #2288. Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com>	2024-06-07 10:13:00 -07:00
Jordan Harband	95081f0bc2	[readme] update CII badge URLs	2024-06-06 14:19:11 -07:00
Jordan Harband	1750b8d327	[actions] update vampire/setup-wsl action	2024-05-30 12:37:36 -07:00
Jordan Harband	97093dc1b3	[Dev Deps] update `markdown-link-check`, `semver`	2024-05-30 12:36:26 -07:00
Jordan Harband	811c039e2b	[actions] finisher tweaks	2024-03-08 22:28:53 -08:00
Huy Z	294ff9e3aa	[readme] Fix uninstall instructions `nvm unload` will unset NVM_DIR. So gotta save NVM_DIR first.	2024-02-13 03:39:07 -08:00
Raphael Boidol	c24c3134a7	[actions] update action versions to use node 20	2024-02-18 21:56:53 +01:00
Jordi Paris Ferrer	c82e7a6f62	Fix typo in WSL section of README `u` -> `you`	2024-02-17 16:39:36 -08:00
jbidad	4e2a71ba9b	[Docs] add `nvm unload` to uninstall nvm instructions	2024-01-18 12:07:01 +03:30