[Fix] ls-remote: do not match on bare LTS names, eg Argon

nvm.sh

@@ -136,17 +136,15 @@ nvm_download() {
     eval "curl -q --fail ${CURL_COMPRESSED_FLAG:-} ${CURL_HEADER_FLAG:-} ${NVM_DOWNLOAD_ARGS}"
   elif nvm_has "wget"; then
     # Emulate curl with wget
-    ARGS=$(nvm_echo "$@" | command sed "
-      s/--progress-bar /--progress=bar /
-      s/--compressed //
-      s/--fail //
-      s/-L //
-      s/-I /--server-response /
-      s/-s /-q /
-      s/-sS /-nv /
-      s/-o /-O /
-      s/-C - /-c /
-    ")
+    ARGS=$(nvm_echo "$@" | command sed -e 's/--progress-bar /--progress=bar /' \
+                            -e 's/--compressed //' \
+                            -e 's/--fail //' \
+                            -e 's/-L //' \
+                            -e 's/-I /--server-response /' \
+                            -e 's/-s /-q /' \
+                            -e 's/-sS /-nv /' \
+                            -e 's/-o /-O /' \
+                            -e 's/-C - /-c /')
 
     if [ -n "${NVM_AUTH_HEADER:-}" ]; then
       ARGS="${ARGS} --header \"${NVM_AUTH_HEADER}\""
@@ -1415,11 +1413,11 @@ nvm_add_iojs_prefix() {
 nvm_strip_iojs_prefix() {
   local NVM_IOJS_PREFIX
   NVM_IOJS_PREFIX="$(nvm_iojs_prefix)"
-
-  case "${1-}" in
-    "${NVM_IOJS_PREFIX}") nvm_echo ;;
-    *) nvm_echo "${1#"${NVM_IOJS_PREFIX}"-}" ;;
-  esac
+  if [ "${1-}" = "${NVM_IOJS_PREFIX}" ]; then
+    nvm_echo
+  else
+    nvm_echo "${1#"${NVM_IOJS_PREFIX}"-}"
+  fi
 }
 
 nvm_ls() {
@@ -1551,15 +1549,12 @@ nvm_ls() {
   fi
 
   if [ "${NVM_ADD_SYSTEM-}" = true ]; then
-    case "${PATTERN}" in
-      '' | v)
-        VERSIONS="${VERSIONS}
+    if [ -z "${PATTERN}" ] || [ "${PATTERN}" = 'v' ]; then
+      VERSIONS="${VERSIONS}
 system"
-      ;;
-      system)
-        VERSIONS="system"
-      ;;
-    esac
+    elif [ "${PATTERN}" = 'system' ]; then
+      VERSIONS="system"
+    fi
   fi
 
   if [ -z "${VERSIONS}" ]; then
@@ -1693,10 +1688,15 @@ EOF
     LTS="${LTS#lts/}"
   fi
 
-  VERSIONS="$( { command awk -v lts="${LTS-}" '{
-        if (!$1) { next }
-        if (lts && $10 ~ /^\-?$/) { next }
-        if (lts && lts != "*" && tolower($10) !~ tolower(lts)) { next }
+  VERSIONS="$({ command awk -v lts="${LTS-}" -v pattern="${PATTERN:-.*}" '
+      BEGIN {
+        if (pattern == "") pattern = ".*"
+      }
+      {
+        if (!$1) { next } # skip empty lines
+        if (lts && $10 ~ /^\-?$/) { next } # skip if LTS wanted, and row is not LTS
+        if (lts && lts != "*" && tolower($10) !~ tolower(lts)) { next } # skip if LTS filter does not match
+        if ($1 !~ pattern) { next } # only keep rows matching the pattern
         if ($10 !~ /^\-?$/) {
           if ($10 && $10 != prev) {
             print $1, $10, "*"
@@ -1708,7 +1708,6 @@ EOF
         }
         prev=$10;
       }' \
-    | nvm_grep -w "${PATTERN:-.*}" \
     | $SORT_COMMAND; } << EOF
 $VERSION_LIST
 EOF
@@ -2737,7 +2736,7 @@ nvm_npm_global_modules() {
   local NPMLIST
   local VERSION
   VERSION="$1"
-  NPMLIST=$(nvm use "${VERSION}" >/dev/null && npm list -g --depth=0 2>/dev/null | command sed -e '1d' -e '/UNMET PEER DEPENDENCY/d')
+  NPMLIST=$(nvm use "${VERSION}" >/dev/null && npm list -g --depth=0 2>/dev/null | command sed 1,1d | nvm_grep -v 'UNMET PEER DEPENDENCY')
 
   local INSTALLS
   INSTALLS=$(nvm_echo "${NPMLIST}" | command sed -e '/ -> / d' -e '/\(empty\)/ d' -e 's/^.* \(.*@[^ ]*\).*/\1/' -e '/^npm@[^ ]*.*$/ d' | command xargs)

package.json

@@ -45,7 +45,7 @@
     "dockerfile_lint": "^0.3.4",
     "doctoc": "^2.2.1",
     "eclint": "^2.8.1",
-    "markdown-link-check": "^3.13.6",
+    "markdown-link-check": "^3.12.2",
     "replace": "^1.2.2",
     "semver": "^7.6.3",
     "urchin": "^0.0.5"

test/fast/Unit tests/nvm_ls_remote

@@ -83,4 +83,11 @@ EXPECTED_OUTPUT="$(cat "$EXPECTED_OUTPUT_PATH")"
 OUTPUT="$(NVM_LTS=argon nvm_ls_remote)"
 [ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] || die "\`NVM_LTS=argon nvm_ls_remote\` did not output >$EXPECTED_OUTPUT<; got >$OUTPUT<"
 
+OUTPUT="$(nvm_ls_remote Argon 2>&1)"
+EXIT_CODE=$?
+[ $EXIT_CODE -eq 3 ] || die "nvm_ls_remote Argon did not exit 3, got '${EXIT_CODE}'"
+
+EXPECTED_OUTPUT='N/A'
+[ "_${OUTPUT}" = "_${EXPECTED_OUTPUT}" ] || die "nvm_ls_remote Argon did not output expected error message; got >${OUTPUT}< expected >${EXPECTED_OUTPUT}<"
+
 cleanup

test/install_script/nvm_check_if_path_exists

@@ -1,41 +0,0 @@
-#!/bin/sh
-
-setup () {
-  HOME="."
-  NVM_ENV=testing \. ../../install.sh
-  touch ".bashrc"
-  touch ".zshrc"
-  touch ".profile"
-}
-
-cleanup () {
-  unset HOME
-  unset NVM_ENV
-  unset NVM_DETECT_PROFILE
-  unset BASH_VERSION
-  unset ZSH_VERSION
-  unset -f setup cleanup die
-  rm -f ".bashrc" ".bash_profile" ".zshrc" ".profile" "test_profile" > "/dev/null" 2>&1
-}
-
-die () { echo "$@" '$NVM_DETECT_PROFILE:' "$NVM_DETECT_PROFILE"; cleanup; exit 1; }
-
-setup
-
-# check if nvm_path already exists in bashrc
-NVM_DETECT_PROFILE="$(BASH_VERSION="1"; unset PROFILE; nvm_detect_profile)"
-echo "export NVM_DIR="$HOME/.nvm"" > $HOME/.bashrc
-OUTPUT = "$(nvm_do_install)"
-EXPECTED_OUTPUT='nvm source string already in ${NVM_PROFILE}'
-if [ "${OUTPUT#*$EXPECTED_OUTPUT}" = "${OUTPUT}" ]; then
-  die "Path already exists in the profile, so should have returned >${EXPECTED_OUTPUT}<. Instead it returned >${OUTPUT}<"
-fi
-
-# .zshrc should be detected for zsh
-NVM_DETECT_PROFILE="$(ZSH_VERSION="1"; unset PROFILE; unset BASH_VERSION; nvm_detect_profile)"
-echo "export NVM_DIR="$HOME/.nvm"" > $HOME/.zshrc
-OUTPUT = "$(nvm_do_install)"
-EXPECTED_OUTPUT='nvm source string already in ${NVM_PROFILE}'
-if [ "${OUTPUT#*$EXPECTED_OUTPUT}" = "${OUTPUT}" ]; then
-  die "Path already exists in the profile, so should have returned >${EXPECTED_OUTPUT}<. Instead it returned >${OUTPUT}<"
-fi