2308 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jordan Harband	32863e1052	[Fix] nvm debug: use default empty values for potentially unset variables ... These variables may be unset, which would cause errors in shells with `set -u` (nounset) enabled. Bugs introduced in b805de80cb and 49e446dac1.	2026-03-14 14:33:35 -07:00
Jordan Harband	53e6244aa6	[Fix] nvm_iojs_version_has_solaris_binary: fix comparison to detect non-iojs versions ... Missing `_` prefix on the right side of the comparison meant the guard clause that rejects non-iojs versions almost never matched, allowing non-iojs versions to fall through. Bug introduced in 2d692d9d78 / #854.	2026-03-14 14:30:54 -07:00
Jordan Harband	bda39c7c04	[Fix] nvm_download_artifact: fix error propagation from subshells ... `return` inside `(...)` subshells only exits the subshell, not the calling function. Errors in mkdir, download, and checksum verification were silently ignored. Use `{ ...; }` brace groups instead. Bug introduced in ba3ad8e460.	2026-03-14 14:30:31 -07:00
Jordan Harband	05d784772c	[Fix] nvm_install_binary: return failure when binary download fails with -b ... When `nosource=1` (the `-b` flag) and binary download fails, the function returned 0 (success) instead of a non-zero exit code, masking the installation failure. Bug introduced in 4fdef427e4 / #2439.	2026-03-14 14:29:56 -07:00
Jordan Harband	39e71eab49	[Fix] nvm_get_arch: only apply musl suffix on x64 Alpine ... Alpine detection unconditionally set `x64-musl` regardless of actual architecture, which would be incorrect on ARM-based Alpine containers. Bug introduced in ef7fc2f2c0 / #3212. Fixes #3616.	2026-03-14 12:53:14 -07:00
Jordan Harband	a5de7236d6	[Fix] nvm_get_arch: add command prefix to uname call ... Other `uname` calls in the file use `command uname` to bypass any user aliases or functions. This one was missing it. Bug introduced in 779a34e6a9 / #2469.	2026-03-14 10:16:48 -07:00
Jordan Harband	d2fca5f0ec	[Fix] nvm_resolve_local_alias: avoid using variable as printf format string ... Using a variable as the format string means `%` characters in alias names would be interpreted as format specifiers. Use `%b` format with the variable as an argument to safely interpret `\n` escapes. Bug introduced in 9b91734f0b.	2026-03-14 10:16:25 -07:00
Jordan Harband	3c48015986	[Fix] nvm_get_mirror: fix awk URL validation to actually reject invalid URLs ... The awk expression `$0 ~ "regex"` as a bare statement in the action block evaluates the match but doesn't affect the exit code. awk always prints the line and exits 0, making the validation a no-op. Bug introduced in b1fa143dd8.	2026-03-14 09:40:43 -07:00
Jordan Harband	a937cb595e	[Fix] nvm_ls_remote_combined: propagate iojs remote listing failures ... `return $A || $B` only evaluates the first argument, since `return` always succeeds. The io.js exit code was never checked, silently swallowing remote listing failures. Bug introduced in ea12784629 / #616.	2026-03-14 09:39:20 -07:00
Jordan Harband	6f428a10bb	[Fix] nvm install: fix nvm err typo to nvm_err for -s/-b conflict ... The error message for using `-s` and `-b` together was calling `nvm err` (invoking nvm with subcommand "err") instead of the `nvm_err` helper function, causing the error message to never be displayed and instead showing the help text with exit code 127. Bug introduced in 4fdef427e4 / #2439	2026-03-14 09:38:04 -07:00
Jordan Harband	ef1620361a	[Refactor] nvm_rc_version: use fd 3 instead of exported env var for multiple return	2026-03-12 15:32:17 -04:00
Jordan Harband	a27a8b7da8	[Fix] nvm alias: fix colors not showing by default ... Colors were lost because `nvm_has_colors` checks `[ -t 1 ]`, which is false inside the `(...) | sort` pipeline in `nvm_list_aliases`. Evaluate `nvm_has_colors` before the pipe and propagate via `NVM_HAS_COLORS`, matching the approach used by `nvm_print_versions`. Bug introduced in 35212c1346.	2026-03-13 16:13:41 -04:00
Jordan Harband	59bd32be6b	[New] nvm install --offline: install from cache without network access ... Add `--offline` flag to `nvm install` that resolves versions using only locally installed versions and cached downloads. No network calls are made. New helper functions `nvm_ls_cached` and `nvm_offline_version` scan `$NVM_DIR/.cache/bin/` for previously downloaded tarballs. In offline mode, `nvm_download_artifact` returns cached tarballs directly without checksum verification or download attempts. The curl/wget requirement is skipped when `--offline` is set. Supports `--lts` via locally stored LTS alias files.	2026-03-13 16:13:19 -04:00
Jordan Harband	14d01c6877	[Tests] add try/try_err helpers; convert tests to use them ... Add `try` and `try_err` helper functions to `test/common.sh` that capture stdout/stderr and exit code from a single invocation, eliminating duplicate command executions in tests. Convert all existing tests that used the `OUTPUT`/`EXIT_CODE` double-invocation pattern to use the new helpers. Also fixes a pre-existing bug in the `nvm_die_on_prefix` test where ASCII apostrophes were used instead of U+2019 to match nvm.sh output.	2026-03-13 15:26:07 -04:00
Jordan Harband	4c556a19b0	[actions] add workflow to update nodejs.org nvm version ... Ref: https://github.com/nodejs/nodejs.org/issues/8628	2026-02-19 21:27:42 -08:00
Jordan Harband	62387b8f92	v0.40.4 v0.40.4	2026-01-29 14:12:03 -08:00
Sy2n0	44e2590cdf	[Fix] sanitize NVM_AUTH_HEADER in wget path	2026-01-09 11:30:14 +09:00
Jordan Harband	242d997da5	[actions] add permissions to GHA workflow	2026-01-29 13:08:52 -08:00
Peter Dave Hello	5533699ec5	Improve uninstall error message for missing versions ... Include the requested version in the uninstall error output when the target is not installed. Add a fast test to lock the behavior. Close #3767	2026-01-30 00:04:01 +08:00
Jordan Harband	6d761baef8	[Tests] add retry logic	2026-01-27 20:59:30 -08:00
Jordan Harband	973840565e	[Tests] add a timeout	2026-01-27 18:09:39 -08:00
Peter Dave Hello	29a652f90f	[patch] show system Node.js version in nvm ls ... Normalize `nvm_version` output when `nvm_ls` returns "system vX" so alias and .nvmrc resolutions treat system correctly. Add fast tests for system alias behavior in `nvm ls`, `nvm use`, and `nvm which`.	2026-01-25 18:19:50 +08:00
Jordan Harband	b1dd81097f	[actions] add a finisher to lint	2026-01-27 17:29:59 -08:00
Peter Dave Hello	4d98875a3a	Migrate GitHub Copilot instructions to AGENTS.md and CLAUDE.md ... Move .github/copilot-instructions.md to AGENTS.md, and generalize the wording, so it will apply to Codex CLI, Cursor, OpenCode, RooCode, and many other AI coding agents. Also add CLAUDE.md as a symlink to AGENTS.md so Claude Code reads the same guidance. Copilot coding agent now supports AGENTS.md custom instructions, as more coding agents support it. Migrating from GitHub Copilot's custom instructions file to AGENTS.md will help developers leverage more and different coding agents than just GitHub Copilot. Reference: - https://agents.md/ - https://github.blog/changelog/2025-08-28-copilot-coding-agent-now-supports-agents-md-custom-instructions/	2025-09-12 00:05:38 +08:00
Jordan Harband	4c3edc5e56	[actions] migrate Travis CI tests to GitHub Actions	2026-01-27 10:31:07 -08:00
Jordan Harband	35212c1346	[Fix] nvm_has_colors: also check if stdout is a terminal	2026-01-27 10:31:07 -08:00
Jordan Harband	d2f93c1c8e	[Tests] mock node in nvm_die_on_prefix test	2026-01-26 22:34:24 -08:00
Jordan Harband	f9dbad9832	[Tests] clean up .nvmrc after nvm-exec test	2026-01-26 22:34:07 -08:00
Jordan Harband	c451e7a4c8	[Tests] set $_ before sourcing nvm.sh in fast tests ... nvm.sh uses `NVM_SCRIPT_SOURCE="$_"` to detect its source location. Adding `: nvm.sh` before each source line ensures `$_` is set correctly, preventing breakage when the previous command (e.g., `set -ex`) overwrites it.	2026-01-26 21:41:57 -08:00
Jordan Harband	9ba422e561	[Fix] nvm_strip_path: avoid gawk-specific RT variable for mawk compatibility	2026-01-26 22:33:58 -08:00
Jordan Harband	38ffc713a7	[Fix] nvm_get_default_packages: use portable awk patterns ... Replace POSIX `[[:space:]]` character class with `[ \t]` for mawk compatibility on Ubuntu 16.04.	2026-01-26 16:59:11 -08:00
Jordan Harband	aa1d829102	[Fix] nvm_install_source: explicitly set SHELL=/bin/sh for make ... Old Node.js versions have Makefiles with unquoted glob patterns like `rm -f *.o` that fail in zsh's strict glob mode. By passing SHELL=/bin/sh to make, we ensure POSIX-compliant shell behavior regardless of what shell nvm is running in.	2026-01-26 15:07:01 -08:00
Wes Todd	ec8906b284	[Fix] install.sh: do not log when user has requested no profile modifications ... [Tests] `install.sh`: add tests for PROFILE=/dev/null profile skip Verify that when PROFILE="/dev/null" is set: - The "Profile not found" warning is suppressed - Profile modification is skipped as expected Co-authored-by: Wes Todd <wes@wesleytodd.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>	2019-12-05 19:30:26 -08:00
Shay Molcho	0509776196	[readme] add missing colon ... Inserted missing colons in specific parts of the text to maintain consistency with the existing format. This adjustment ensures a uniform writing style, improves readability, and aligns the text structure with the rest of the document.	2025-01-28 08:28:41 +02:00
Bark	01a8749d7f	[Fix] nvm exec: Do a version check on nvm-exec ... This check would display a message in case the `.nvmrc` version is not installed, and would not alter the output otherwise.	2024-03-06 16:03:10 +02:00
Sylvain Lesage	0fbe3a6776	[readme] add background on io.js	2025-08-20 09:58:31 -04:00
Ulises Gascón	a36448ffcd	[security] add security escalation policy	2025-09-15 14:33:37 +02:00
Noritaka Kobayashi	4d364c2e7b	[readme] fix typo	2025-10-18 10:28:48 +09:00
Rahul Beniwal	81f13638d7	[Fix] Reject bare LTS codenames in nvm install ... Previously, `nvm install Argon` would succeed by matching the LTS name in the version description (e.g., "v4.9.1 (Latest LTS: Argon)"), but `nvm uninstall Argon` would fail because "Argon" is not a valid alias or not a valid version. Changes: - Added pattern matching check in nvm_remote_version (nvm.sh:785-791) - Skips check for implicit aliases (node, stable, etc.) to preserve existing functionality - Added unit tests to verify LTS names are rejected while version numbers still work After this fix: - `nvm install Argon` → fails (use `nvm install lts/argon` instead) - `nvm install 4` → still works - `nvm install node` → still works - `nvm install lts/argon` → still works This makes install and uninstall behavior consistent. Fixes #3474.	2025-11-24 21:57:39 +05:30
Jordan Harband	26066c10f4	[Fix] prevent sed errors when pattern contains # ... When `.nvmrc` or alias files contained comments (lines with `#`), the `#` character could end up in the search pattern passed to sed, causing "unterminated regular expression" errors because `#` is used as the sed address delimiter. This commit fixes the issue in two places: 1. `nvm_alias`: Strip comments from alias file contents before returning them, and trim trailing whitespace 2. `nvm_ls`: Escape `#` characters in SEARCH_PATTERN so they're treated as literal characters in the sed address Fixes #3761	2026-01-19 22:58:43 -08:00
Padraic Slattery	34d6d5d6fe	[actions] update outdated GitHub Actions versions	2026-01-19 17:39:42 +01:00
Jordan Harband	80cc4cdd1b	[actions] fix WSL tests: properly handle Debian apt sources issue ... The Debian WSL image has stale apt sources pointing to ftp.debian.org which no longer hosts bullseye-backports. The previous fix ran sed after the first setup-wsl call, but that call already failed because additional-packages triggers apt-get update internally. For wsl_matrix (Debian, Ubuntu): - Ubuntu: install with additional-packages directly (no apt issue) - Debian: install without packages first, fix sources.list with sed, then run apt-get update/upgrade/install manually with retries - Exclude Debian and Ubuntu-20.04 --lts since node v24+ has exec format errors on WSL1 For wsl_matrix_unofficial (Alpine): - Remove the Debian-specific fix entirely (Alpine uses apk, not apt) See https://github.com/Vampire/setup-wsl/issues/76	2026-01-19 22:11:41 -08:00
Jordan Harband	630a01f2e0	[actions] fix workflow permissions; add codeQL	2025-12-03 12:05:43 -08:00
Jordan Harband	b7b7e949aa	[Dev Deps] update markdown-link-check, semver	2025-12-03 12:02:29 -08:00
Jordan Harband	e4e34ec7f9	[Dev Deps] update markdown-link-check, semver	2025-11-10 10:07:02 +07:00
Curt J. Sampson	7c82abdbef	[Fix] install.sh: Force remote name of cloned repo to be 'origin' ... The script assumes that the name of the remote is `origin`, but this is not the case if the user has set `clone.defaultRemoteName` to another value in the ~/.gitconfig (or elsewhere in the configuration). Adding `-o origin` ensures that the remote will be called `origin` regardless of the `clone.defaultRemoteName` setting. Per PR #3341: - The minimum Git version this should work with is v1.7.10. (This is not documented in the repo itself; it's just an implicit requirement.) - The `--origin` option was added to `git clone` in commit 98a4fef3f2 which was released in v1.2.5. From the diff of that commit, the `-o` option was already available at that time. So this easily satisfies the above. - A comment in #3341 indicates that `-o` was added in v1.1.0. I've not verified this, but we probably don't need to track that down since by the above we're already well within requirements.	2025-09-12 18:27:48 +09:00
Jordan Harband	44a3cdb9b8	[actions] temporary fix for WSL issue ... See https://github.com/Vampire/setup-wsl/issues/76	2025-09-05 09:20:08 -07:00
Jordan Harband	34ace599a2	[actions] add new github asset domain to harden-runner	2025-09-05 13:19:27 -07:00
Jordan Harband	18e638e42b	[Fix] sh lacks -O; thanks shellcheck	2025-09-05 13:19:27 -07:00
copilot-swe-agent[bot]	9602f4f959	[meta] Add comprehensive .github/copilot-instructions.md for better AI code assistance ... This comprehensive guide helps GitHub Copilot better understand and navigate the nvm codebase by providing: - Complete architecture explanation of nvm's POSIX-compliant design across multiple shells - Detailed mapping of top-level commands to internal functions (install, use, ls, alias, etc.) - Comprehensive testing infrastructure guide using urchin framework - Shell environment setup for bash, zsh, dash, sh, and ksh - CI environment details for GitHub Actions and Travis CI - shellcheck setup and usage guidelines - Development best practices for POSIX compliance and multi-shell compatibility - Windows support via WSL2, Cygwin, and Git Bash - Complete internal function categorization and debugging techniques The documentation covers all aspects of the codebase to enable more accurate AI assistance when working with nvm's complex shell script architecture.	2025-07-02 17:12:44 +00:00