eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-10-11 00:00:13 +08:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

[Perf] nvm_is_version_installed: check the modern layout's path before the full lookup

Browse Source
This commit is contained in:
Cassidy Marble
2026-10-06 12:43:22 -03:00
committed by Jordan Harband
parent 913b8cb625
commit d211d5fdb8
2 changed files with 57 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nvm.sh
+16
View File
@@ -233,6 +233,22 @@ nvm_is_version_installed() {
if [ -z "${1-}" ]; then
return 1
fi
# Fast path: versions in the modern layout live at a directly-computable
# path. Checking it first avoids forking `nvm_version_path` (and the `awk`
# version comparison inside it) and `nvm_get_os` on shell startup. Versions
# below `v0.12` are skipped, since they must not count from the modern
# layout; those, io.js, and Windows binaries fall through to the full lookup
# below, which also rejects path traversal.
case "/${1}/" in
*/../* | /v0.[0-9].* | /v0.1[01].* | /0.[0-9].* | /0.1[01].*) ;;
*)
if [ -x "${NVM_DIR}/versions/node/${1}/bin/node" ]; then
return 0
fi
;;
esac
local NVM_NODE_BINARY
NVM_NODE_BINARY='node'
if [ "_$(nvm_get_os)" = '_win' ]; then
test/fast/Unit tests/nvm_is_version_installed
+41
View File
@@ -45,6 +45,47 @@ type nvm_is_version_installed > /dev/null 2>&1 || die 'nvm_is_version_installed
check_version '12.0.0' 'node'
# the pre-0.12 layout is still found via the fallback
OLD_VERSION='0.11.15'
mkdir -p "$NVM_DIR/$OLD_VERSION/bin"
touch "$NVM_DIR/$OLD_VERSION/bin/node"
chmod +x "$NVM_DIR/$OLD_VERSION/bin/node"
nvm_is_version_installed "$OLD_VERSION" || die "nvm_is_version_installed $OLD_VERSION should work with the pre-0.12 layout"
# a pre-0.12 version does not count as installed from the modern layout
for STRAY_VERSION in '0.10.48' 'v0.10.48'; do
mkdir -p "$NODE_PATH/$STRAY_VERSION/bin"
touch "$NODE_PATH/$STRAY_VERSION/bin/node"
chmod +x "$NODE_PATH/$STRAY_VERSION/bin/node"
! nvm_is_version_installed "$STRAY_VERSION" || die "nvm_is_version_installed $STRAY_VERSION should not find a pre-0.12 version in the modern layout"
done
# io.js versions live in a separate tree and are still found via the fallback
IOJS_VERSION='v2.0.0'
mkdir -p "$NVM_DIR/versions/io.js/$IOJS_VERSION/bin"
touch "$NVM_DIR/versions/io.js/$IOJS_VERSION/bin/node"
chmod +x "$NVM_DIR/versions/io.js/$IOJS_VERSION/bin/node"
nvm_is_version_installed "iojs-$IOJS_VERSION" || die "nvm_is_version_installed iojs-$IOJS_VERSION should work via the fallback"
# the modern layout is found without shelling out to detect the OS
FAST_VERSION='14.0.0'
! nvm_is_version_installed "$FAST_VERSION" || die "nvm_is_version_installed $FAST_VERSION should fail before it is installed"
nvm_get_os() {
die 'nvm_is_version_installed must not call nvm_get_os when the modern-layout binary exists'
}
mkdir -p "$NODE_PATH/$FAST_VERSION/bin"
touch "$NODE_PATH/$FAST_VERSION/bin/node"
chmod +x "$NODE_PATH/$FAST_VERSION/bin/node"
nvm_is_version_installed "$FAST_VERSION" || die "nvm_is_version_installed $FAST_VERSION should succeed via the fast path"
# 0.12.x is the first version in the modern layout
for FAST_VERSION in '0.12.18' 'v0.12.18'; do
mkdir -p "$NODE_PATH/$FAST_VERSION/bin"
touch "$NODE_PATH/$FAST_VERSION/bin/node"
chmod +x "$NODE_PATH/$FAST_VERSION/bin/node"
nvm_is_version_installed "$FAST_VERSION" || die "nvm_is_version_installed $FAST_VERSION should succeed via the fast path"
done
unset -f nvm_get_os
# Checking for Windows
nvm_get_os() {
echo "win"