Rejecting only ASCII control characters in the LTS codename still lets through a UTF-8 C1 control (like U+009B, a CSI) or a bidi override (like U+202E), which some terminals act on. A row is now kept only if its codename is `-`, empty, or alias-safe, which is the same shape the LTS alias step already requires, and every real codename has. BusyBox `tr` mishandles `-c` with a character class, so on Alpine the expected checksum printed as almost all `?`; an octal range in the C locale works in BusyBox, GNU, and BSD `tr`, and does not make BSD `tr` abort on invalid UTF-8.
58 lines
2.4 KiB
Bash
Executable File
58 lines
2.4 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
WORK="$PWD/ls_remote-cntrl-work.$$"
|
|
export HOME="$WORK/home"
|
|
export NVM_DIR="$HOME/.nvm"
|
|
|
|
cleanup() {
|
|
unset -f die cleanup nvm_download
|
|
rm -rf "$WORK"
|
|
}
|
|
die () { echo "$@" ; cleanup ; exit 1; }
|
|
|
|
mkdir -p "$NVM_DIR/alias"
|
|
|
|
: nvm.sh
|
|
\. ../../../nvm.sh
|
|
|
|
ESC="$(printf '\033')"
|
|
BEL="$(printf '\007')"
|
|
|
|
# a malicious/compromised mirror: the LTS codename field ($10) carries terminal
|
|
# escape sequences (an OSC window-title write and an SGR color change);
|
|
# a valid codename (Iron) is included to prove real rows are still listed;
|
|
# so are a UTF-8 C1 CSI and a right-to-left override, which are not ASCII control characters
|
|
nvm_download() {
|
|
printf 'version\tdate\tfiles\tnpm\tv8\tuv\tzlib\topenssl\tmodules\tlts\tsecurity\n'
|
|
printf 'v23.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\t-\t-\n'
|
|
printf 'v22.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tJod\033]0;PWNED\007\033[31m\t-\n'
|
|
printf 'v21.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tJod\302\23331m\t-\n'
|
|
printf 'v20.1.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tIron\342\200\256\t-\n'
|
|
printf 'v20.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tIron\t-\n'
|
|
}
|
|
|
|
OUTPUT="$(nvm_ls_remote 2>&1)" || true
|
|
case "${OUTPUT}" in
|
|
*"${ESC}"* | *"${BEL}"*) die "nvm_ls_remote printed control characters from the mirror's LTS codename: $(printf '%s' "${OUTPUT}" | od -c | head -5)" ;;
|
|
esac
|
|
case "${OUTPUT}" in
|
|
*'v21.0.0'* | *'v20.1.0'*) die "nvm_ls_remote listed a row with a malformed LTS codename: ${OUTPUT}" ;;
|
|
*'v20.0.0'*'Iron'*'v23.0.0'*) ;;
|
|
*) die "nvm_ls_remote did not list the valid rows: ${OUTPUT}" ;;
|
|
esac
|
|
if [ -f "$NVM_DIR/.lts-status" ] && nvm_grep -q "${ESC}" "$NVM_DIR/.lts-status"; then
|
|
die 'control characters from the mirror were recorded in .lts-status'
|
|
fi
|
|
|
|
# a checksum from the mirror is printed when it does not match; its control characters must not be
|
|
printf 'tarball' > "$WORK/tarball"
|
|
OUTPUT="$(nvm_compare_checksum "$WORK/tarball" "${ESC}]0;PWNED${BEL}${ESC}[31m" 2>&1)" && die 'nvm_compare_checksum accepted a mismatched checksum'
|
|
case "${OUTPUT}" in
|
|
*"${ESC}"* | *"${BEL}"*) die "nvm_compare_checksum printed control characters from the mirror's checksum: $(printf '%s' "${OUTPUT}" | od -c | head -5)" ;;
|
|
*"Checksums do not match"*"?]0;PWNED??[31m' expected."*) ;;
|
|
*) die "unexpected nvm_compare_checksum output: ${OUTPUT}" ;;
|
|
esac
|
|
|
|
cleanup
|
|
echo "nvm_ls_remote LTS codename control characters: passed"
|