mirror of
https://github.com/nvm-sh/nvm.git
synced 2026-02-04 17:02:48 +08:00
26066c10f4
When `.nvmrc` or alias files contained comments (lines with `#`), the `#` character could end up in the search pattern passed to sed, causing "unterminated regular expression" errors because `#` is used as the sed address delimiter. This commit fixes the issue in two places: 1. `nvm_alias`: Strip comments from alias file contents before returning them, and trim trailing whitespace 2. `nvm_ls`: Escape `#` characters in SEARCH_PATTERN so they're treated as literal characters in the sed address Fixes #3761
34 lines
1.2 KiB
Bash
Executable File
34 lines
1.2 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
die () { echo "$@" ; cleanup ; exit 1; }
|
|
|
|
cleanup () {
|
|
rm -rf ../../../alias/test-comment
|
|
rm -rf ../../../alias/test-inline-comment
|
|
rm -rf ../../../alias/test-comment-first
|
|
}
|
|
|
|
\. ../../../nvm.sh
|
|
|
|
# Test: alias file with comment on separate line
|
|
echo "v0.10
|
|
# this is a comment" > ../../../alias/test-comment
|
|
OUTPUT="$(nvm_alias test-comment)"
|
|
EXPECTED_OUTPUT="v0.10"
|
|
[ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] || die "'nvm_alias test-comment' should ignore comment line; expected '$EXPECTED_OUTPUT', got '$OUTPUT'"
|
|
|
|
# Test: alias file with inline comment
|
|
echo "v0.11 # inline comment" > ../../../alias/test-inline-comment
|
|
OUTPUT="$(nvm_alias test-inline-comment)"
|
|
EXPECTED_OUTPUT="v0.11"
|
|
[ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] || die "'nvm_alias test-inline-comment' should strip inline comment; expected '$EXPECTED_OUTPUT', got '$OUTPUT'"
|
|
|
|
# Test: alias file with comment as first line
|
|
echo "# comment first
|
|
v0.12" > ../../../alias/test-comment-first
|
|
OUTPUT="$(nvm_alias test-comment-first)"
|
|
EXPECTED_OUTPUT="v0.12"
|
|
[ "_$OUTPUT" = "_$EXPECTED_OUTPUT" ] || die "'nvm_alias test-comment-first' should skip comment-only first line; expected '$EXPECTED_OUTPUT', got '$OUTPUT'"
|
|
|
|
cleanup
|