Jordan Harband 26066c10f4 [Fix] prevent sed errors when pattern contains # ...

When `.nvmrc` or alias files contained comments (lines with `#`),
the `#` character could end up in the search pattern passed to sed,
causing "unterminated regular expression" errors because `#` is
used as the sed address delimiter.

This commit fixes the issue in two places:
1. `nvm_alias`: Strip comments from alias file contents before
   returning them, and trim trailing whitespace
2. `nvm_ls`: Escape `#` characters in SEARCH_PATTERN so they're
   treated as literal characters in the sed address

Fixes #3761

2026-01-19 22:58:43 -08:00

..

mocks

[Tests] update mocks

2024-10-31 14:23:36 -07:00

nvm install -b

[Fix] nvm install -b: when no binary is available, fail and output a clear message

2024-08-01 13:57:22 -07:00

nvm install with nonlowercase LTS name

[Fix] nvm ls, nvm alias, nvm install: error when an LTS name is invalid

2024-09-04 13:55:11 -07:00

nvm ls-remote

[Tests] ensure that unit tests use only mocked LTS names

2024-10-30 23:41:50 -07:00

nvm set_colors

[New] Added set-colors command. See details below:

2020-08-17 14:56:13 -07:00

nvm version-remote

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_add_iojs_prefix

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_alias

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_alias handles comments

[Fix] prevent sed errors when pattern contains #

2026-01-19 22:58:43 -08:00

nvm_alias LTS-N

[Tests] ensure that unit tests use only mocked LTS names

2024-10-30 23:41:50 -07:00

nvm_alias_path

[Docs] fix spelling

2018-03-06 04:38:01 +00:00

nvm_change_path

[meta] update repo links to point to org

2019-04-24 16:08:34 -07:00

nvm_check_for_help

[Fix] ensure --help is intercepted on any command

2020-08-04 16:32:19 -07:00

nvm_clang_version

Add nvm_clang_version to ensure clang version > 3.5

2016-11-14 12:28:41 +08:00

nvm_command_info

[Tests] nvm_command_info: make error output more helpful

2019-02-25 13:17:10 -08:00

nvm_compare_checksum

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_compute_checksum

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_curl_libz_support

[New] Dynamically detect if curl supports --compressed

2017-03-23 16:51:20 +08:00

nvm_curl_use_compression

[Fix] enable curl compression only on curl >=7.21.0

2017-06-10 15:25:26 +08:00

nvm_curl_version

[Fix] enable curl compression only on curl >=7.21.0

2017-06-10 15:25:26 +08:00

nvm_die_on_prefix

[Fix] nvm_die_on_prefix: filter prefixed env vars on name only, ignoring values

2020-11-28 15:16:35 +01:00

nvm_download

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00

nvm_download_artifact

[Tests] add unit tests for nvm_download_artifact

2023-04-06 09:23:33 -07:00

nvm_ensure_default_set

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_ensure_version_installed

[Fix] nvm install: show proper version in .nvmrc install instructions

2022-03-22 18:58:18 +05:30

nvm_ensure_version_prefix

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_extract_tarball

[Refactor] add nvm_extract_tarball to consolidate extraction logic

2021-12-19 02:58:18 +00:00

nvm_find_project_dir

[Fix] fix directory traversal when workdir path is not readable

2023-04-08 17:24:41 +01:00

nvm_find_up

[Fix] fix directory traversal when workdir path is not readable

2023-04-08 17:24:41 +01:00

nvm_format_version

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_get_arch

[actions] use node/install instead of node/run

2024-08-28 11:28:52 -07:00

nvm_get_arch_unofficial

[Fix] nvm_get_arch: proper value for alpine linux

2023-09-30 23:54:11 +01:00

nvm_get_artifact_compression

[New] maybe support Windows with WSL, MSYS, Cygwin

2021-01-02 00:03:24 +01:00

nvm_get_checksum

[Refactor] add nvm_get_artifact_compression

2021-01-02 00:03:24 +01:00

nvm_get_checksum_alg

[New] add support for $NVM_DIR/default-packages file

2017-03-28 09:37:14 -07:00

nvm_get_checksum_binary

[Refactor] add nvm_get_checksum_binary; use it in nvm debug

2020-07-31 22:13:21 -07:00

nvm_get_colors

[New] Added set-colors command. See details below:

2020-08-17 14:56:13 -07:00

nvm_get_default_packages

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00

nvm_get_download_slug

[Tests] nvm_get_download_slug: add unit tests

2021-12-02 23:33:20 -08:00

nvm_get_latest missing curl or wget

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_get_minor_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_get_mirror

[Fix] nvm_get_mirror: ensure only a valid URL is allowed

2023-12-02 14:44:46 -08:00

nvm_has

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_has_non_aliased

[Refactor] Add nvm_has_non_aliased

2017-03-20 16:57:26 +08:00

nvm_has_solaris_binary

[Docs] fix spelling

2018-03-06 04:38:01 +00:00

nvm_has_system_iojs

[Tests] update most mkdirs to use make_fake_{node,iojs}

2018-06-13 10:38:19 -07:00

nvm_has_system_node

[Tests] update most mkdirs to use make_fake_{node,iojs}

2018-06-13 10:38:19 -07:00

nvm_install_binary_extract

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00

nvm_install_binary_nosource

[New] install: add -b flag to skip building from source

2021-02-16 19:34:23 +05:30

nvm_install_latest_npm

[New] nvm install: add --latest-npm option to automatically try to upgrade to the latest working version of npm.

2017-06-11 14:15:04 -07:00

nvm_install_no_progress_bar

[Fix] nvm ls, nvm alias, nvm install: error when an LTS name is invalid

2024-09-04 13:55:11 -07:00

nvm_iojs_prefix

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_iojs_version_has_solaris_binary

[Refactor] Rename solaris and iojs helper functions to be nvm_ prefixed

2020-05-08 16:08:27 -04:00

nvm_is_alias

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_is_iojs_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_is_merged_node_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_is_natural_num

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_is_valid_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_is_version_installed

[Tests] set proper permissions on test files

2024-08-23 17:23:12 -07:00

nvm_ls handles hash in pattern

[Fix] prevent sed errors when pattern contains #

2026-01-19 22:58:43 -08:00

nvm_ls_current

[Tests] Fix nvm_ls_current fast test

2020-10-13 12:32:41 -04:00

nvm_ls_remote

[Fix] nvm ls-remote: accept versions that end with a dot

2020-09-24 13:46:29 -07:00

nvm_ls_remote LTS aliases

[Tests] update mocks

2021-03-11 13:06:41 -08:00

nvm_ls_remote nightly

[Test] update test mocks

2023-10-23 14:53:39 -07:00

nvm_ls_remote_iojs

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_make_alias

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_node_prefix

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_node_version_has_solaris_binary

[Refactor] Rename solaris and iojs helper functions to be nvm_ prefixed

2020-05-08 16:08:27 -04:00

nvm_normalize_lts

[Tests] ensure that unit tests use only mocked LTS names

2024-10-30 23:41:50 -07:00

nvm_num_version_groups

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_print_alias_path

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_print_color_code

[Refactor] add nvm_wrap_with_color_code; allow no color code

2022-10-13 20:16:42 -07:00

nvm_print_default_alias

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_print_implicit_alias errors

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_print_implicit_alias success

[Tests] update most mkdirs to use make_fake_{node,iojs}

2018-06-13 10:38:19 -07:00

nvm_print_npm_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_process_nvmrc

[Tests] use a better JSON parsing implementation

2024-06-10 11:33:12 -07:00

nvm_remote_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_remote_versions

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_stdout_is_terminal

[Refactor] add nvm_stdout_is_terminal helper

2019-02-24 00:03:19 +01:00

nvm_strip_iojs_prefix

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_strip_path

[Fix] nvm_strip_path: Preserve leading/trailing colons

2023-06-21 15:47:52 +01:00

nvm_supports_xz

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_tree_contains_path

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_use_if_needed

[Fix] nvm install -s: npm detection

2017-03-27 15:00:50 -07:00

nvm_validate_implicit_alias

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_version

[Tests] die() in tests should quote "$@" for echo

2016-11-07 03:34:36 +08:00

nvm_version_dir

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_version_greater

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_version_path

Remove useless trailing newlines

2018-02-26 01:01:30 +08:00

nvm_wrap_with_color_code

[Refactor] add nvm_wrap_with_color_code; allow no color code

2022-10-13 20:16:42 -07:00

nvm_write_nvmrc

[Tests] set proper permissions on test files

2024-08-23 17:23:12 -07:00

Running 'nvm install --save' works as expected'

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00

Running 'nvm use --save' works as expected'

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00

Running 'nvm use --save' works with a .nvmrc in the parent dir

[Tests] set proper permissions on test files

2024-08-23 17:23:12 -07:00

Running 'nvm use --silent --save' doesn't output anything

[Tests] fix broken tests exposed by 863bd63

2024-08-27 12:46:40 -07:00