Six fast tests failed outside of CI's setup,
which runs them as a non-root user with `sudo` and a terminal.
`nvm_download_artifact error propagation` expected `mkdir -p` under `/nonexistent` to fail,
which root can create; it now uses a path under a regular file, which nobody can create.
`nvm_get_arch_unofficial` now only uses `sudo` when it is not already root,
and skips the chroot checks when it can do neither.
`nvm_write_nvmrc`'s permissions check and the `nvm uninstall` permissions test are skipped as root,
since root ignores file permissions.
`nvm_stdout_is_terminal`'s `/dev/tty` checks are skipped when there is no controlling terminal,
as in `docker run` without `-t`.
`nvm_process_nvmrc` now fails with a clear message when the `test/fixtures/nvmrc` submodule is not checked out,
instead of on an unexpanded glob.
This is not a vulnerability fix.
Add `try` and `try_err` helper functions to `test/common.sh` that capture stdout/stderr and exit code from a single invocation, eliminating duplicate command executions in tests.
Convert all existing tests that used the `OUTPUT`/`EXIT_CODE` double-invocation pattern to use the new helpers.
Also fixes a pre-existing bug in the `nvm_die_on_prefix` test where ASCII apostrophes were used instead of U+2019 to match nvm.sh output.
nvm.sh uses `NVM_SCRIPT_SOURCE="$_"` to detect its source location.
Adding `: nvm.sh` before each source line ensures `$_` is set correctly, preventing breakage when the previous command (e.g., `set -ex`) overwrites it.
In theory, `npx nvmrc` can now be used to validate an `.nvmrc` file that `nvm` will support. Allowances have been made for future extensibility, and aliases may no longer contain a `#`.
Fixes#3336. Closes#2288.
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>