[Fix] nvm_ls_remote_index_tab, nvm_compare_checksum: keep control characters from the mirror off the terminal
`index.tab` and `SHASUMS256.txt` are untrusted mirror metadata. An LTS codename (`$10`) carrying ESC/BEL bytes was printed by `nvm ls-remote`, and a mismatched expected checksum was echoed as received. Skip `index.tab` rows whose codename has a control character, next to the existing version check, and show non-printable bytes of the expected checksum as `?`.
This commit is contained in:
1 parent
d66749b21c
commit
f3ad1d23b7
2 files changed
+59
-3
No files matched your search
@@ -0,0 +1,52 @@
|
||||
#!/bin/sh
|
||||
|
||||
WORK="$PWD/ls_remote-cntrl-work.$$"
|
||||
export HOME="$WORK/home"
|
||||
export NVM_DIR="$HOME/.nvm"
|
||||
|
||||
cleanup() {
|
||||
unset -f die cleanup nvm_download
|
||||
rm -rf "$WORK"
|
||||
}
|
||||
die () { echo "$@" ; cleanup ; exit 1; }
|
||||
|
||||
mkdir -p "$NVM_DIR/alias"
|
||||
|
||||
: nvm.sh
|
||||
\. ../../../nvm.sh
|
||||
|
||||
ESC="$(printf '\033')"
|
||||
BEL="$(printf '\007')"
|
||||
|
||||
# a malicious/compromised mirror: the LTS codename field ($10) carries terminal
|
||||
# escape sequences (an OSC window-title write and an SGR color change);
|
||||
# a valid codename (Iron) is included to prove real rows are still listed
|
||||
nvm_download() {
|
||||
printf 'version\tdate\tfiles\tnpm\tv8\tuv\tzlib\topenssl\tmodules\tlts\tsecurity\n'
|
||||
printf 'v22.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tJod\033]0;PWNED\007\033[31m\t-\n'
|
||||
printf 'v20.0.0\t2026-01-01\tlinux-x64\t-\t-\t-\t-\t-\t-\tIron\t-\n'
|
||||
}
|
||||
|
||||
OUTPUT="$(nvm_ls_remote 2>&1)" || true
|
||||
case "${OUTPUT}" in
|
||||
*"${ESC}"* | *"${BEL}"*) die "nvm_ls_remote printed control characters from the mirror's LTS codename: $(printf '%s' "${OUTPUT}" | od -c | head -5)" ;;
|
||||
esac
|
||||
case "${OUTPUT}" in
|
||||
*'v20.0.0'*'Iron'*) ;;
|
||||
*) die "nvm_ls_remote did not list the valid row: ${OUTPUT}" ;;
|
||||
esac
|
||||
if [ -f "$NVM_DIR/.lts-status" ] && nvm_grep -q "${ESC}" "$NVM_DIR/.lts-status"; then
|
||||
die 'control characters from the mirror were recorded in .lts-status'
|
||||
fi
|
||||
|
||||
# a checksum from the mirror is printed when it does not match; its control characters must not be
|
||||
printf 'tarball' > "$WORK/tarball"
|
||||
OUTPUT="$(nvm_compare_checksum "$WORK/tarball" "${ESC}]0;PWNED${BEL}${ESC}[31m" 2>&1)" && die 'nvm_compare_checksum accepted a mismatched checksum'
|
||||
case "${OUTPUT}" in
|
||||
*"${ESC}"* | *"${BEL}"*) die "nvm_compare_checksum printed control characters from the mirror's checksum: $(printf '%s' "${OUTPUT}" | od -c | head -5)" ;;
|
||||
*"Checksums do not match"*"?]0;PWNED??[31m' expected."*) ;;
|
||||
*) die "unexpected nvm_compare_checksum output: ${OUTPUT}" ;;
|
||||
esac
|
||||
|
||||
cleanup
|
||||
echo "nvm_ls_remote LTS codename control characters: passed"
|
||||
Reference in new issue
Block a user