eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-10-11 00:00:13 +08:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

[Perf] nvm use: skip re-resolving an exact, installed version

Browse Source 
When `nvm use` is given an exact `vX.Y.Z` that is already installed,
and no alias with that exact name exists,
use it directly instead of re-resolving it through
`nvm_match_version` and `nvm_ensure_version_installed`,
both of which call `nvm_version`.

`nvm_auto` takes this path on every shell startup with an already-resolved version,
so this removes ~95ms from each new shell
(~330ms -> ~235ms in a clean environment on macOS/zsh).

Fixes #3930
This commit is contained in:
Hridhin Varkey Joseph
2026-10-01 09:51:16 +05:30
committed by Jordan Harband
parent 077156e88f
commit f1f3d463ab
3 changed files with 114 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/fast/Unit tests/nvm_is_installed_exact_version
Executable
+58
View File
@@ -0,0 +1,58 @@
#!/bin/sh
cleanup () {
rm -rf "$NVM_DIR"
unset -f die cleanup
unset NVM_DIR NODE_PATH VERSION
}
die () { echo "$@" ; cleanup ; exit 1; }
: nvm.sh
\. ../../../nvm.sh
set -ex
NVM_DIR=$(mktemp -d)
NODE_PATH="$NVM_DIR/versions/node"
mkdir -p "$NODE_PATH"
if [ -z "$NODE_PATH" ]; then
die 'Unable to create temporary folder'
fi
# nvm_is_installed_exact_version is available
type nvm_is_installed_exact_version > /dev/null 2>&1 || die 'nvm_is_installed_exact_version is not available'
# nvm_is_installed_exact_version with no parameter fails
! nvm_is_installed_exact_version || die 'nvm_is_installed_exact_version without parameter should fail'
# an exact version that is not installed fails
! nvm_is_installed_exact_version 'v12.0.0' || die 'v12.0.0 is not installed and should fail'
# an exact version whose node binary is not executable fails
mkdir -p "$NODE_PATH/v12.0.0/bin"
touch "$NODE_PATH/v12.0.0/bin/node"
! nvm_is_installed_exact_version 'v12.0.0' || die 'v12.0.0 with a non-executable node should fail'
# an exact, installed version succeeds
chmod +x "$NODE_PATH/v12.0.0/bin/node"
nvm_is_installed_exact_version 'v12.0.0' || die 'v12.0.0 is installed and should succeed'
# something shaped almost like vX.Y.Z fails, even when a directory by that name is installed
for VERSION in 'v12.0.0.0' 'v12.0.0.' 'v12..0' 'v.12.0' 'v12.0'; do
mkdir -p "$NODE_PATH/$VERSION/bin"
touch "$NODE_PATH/$VERSION/bin/node"
chmod +x "$NODE_PATH/$VERSION/bin/node"
! nvm_is_installed_exact_version "$VERSION" || die "$VERSION is not an exact version and should fail, even when installed"
done
# anything that is not an exact vX.Y.Z fails, even if it would resolve to an installed version
for VERSION in '12.0.0' '12' 'v12' 'v12.0' 'v12.0.0-rc.1' 'node' 'stable' 'lts/*' 'iojs-v1.0.0' 'system' 'default'; do
! nvm_is_installed_exact_version "$VERSION" || die "$VERSION is not an exact version and should fail"
done
# an alias with the exact same name takes precedence, so the fast path must not apply
mkdir -p "$(nvm_alias_path)"
echo 'v12.0.0' > "$(nvm_alias_path)/v12.0.0"
! nvm_is_installed_exact_version 'v12.0.0' || die 'an alias named v12.0.0 should take precedence'
cleanup