diff --git a/nvm.sh b/nvm.sh index e4bd0548..1403191d 100755 --- a/nvm.sh +++ b/nvm.sh @@ -574,6 +574,22 @@ nvm_validate_install() { return 0 } +# npm applies the npmrc of the project that `$PWD` is in, which is untrusted: +# eg, its `logs-dir` picks where npm writes its debug log. +# run npm from `/` instead, since `--global` alone does not avoid it on npm v7 - v8.2. +nvm_cd_root() { + # `-q` skips zsh's `chpwd` hooks; `$NVM_CD_FLAGS` is not used, since a zsh parent exports it to other shells + if nvm_is_zsh; then + nvm_cd -q / + else + nvm_cd / + fi +} + +nvm_npm() { + (nvm_cd_root && npm "$@") +} + nvm_print_npm_version() { if nvm_has "npm"; then local NPM_VERSION @@ -5234,10 +5250,15 @@ nvm() { unset TEST_TOOLS ADD_TEST_TOOLS local NVM_DEBUG_OUTPUT - for NVM_DEBUG_COMMAND in 'nvm current' 'which node' 'which iojs' 'which npm' 'npm config get prefix' 'npm root -g'; do + for NVM_DEBUG_COMMAND in 'nvm current' 'which node' 'which iojs' 'which npm'; do NVM_DEBUG_OUTPUT="$(${NVM_DEBUG_COMMAND} 2>&1)" nvm_err "${NVM_DEBUG_COMMAND}: $(nvm_sanitize_path "${NVM_DEBUG_OUTPUT}")" done + for NVM_DEBUG_COMMAND in 'config get prefix' 'root -g'; do + # shellcheck disable=SC2086 + NVM_DEBUG_OUTPUT="$(nvm_npm ${NVM_DEBUG_COMMAND} 2>&1)" + nvm_err "npm ${NVM_DEBUG_COMMAND}: $(nvm_sanitize_path "${NVM_DEBUG_OUTPUT}")" + done return 42 ;; @@ -7052,7 +7073,7 @@ nvm() { nvm_download nvm_get_latest nvm_has nvm_has_executable nvm_install_default_packages nvm_get_default_packages \ nvm_curl_use_compression nvm_curl_version \ nvm_auto nvm_supports_xz \ - nvm_echo nvm_err nvm_grep nvm_cd \ + nvm_echo nvm_err nvm_grep nvm_cd nvm_cd_root nvm_npm \ nvm_die_on_prefix nvm_get_make_jobs nvm_get_minor_version \ nvm_has_solaris_binary nvm_is_merged_node_version \ nvm_is_natural_num nvm_is_installed_exact_version nvm_is_version_installed nvm_validate_install \ diff --git a/test/fast/Unit tests/nvm debug does not let npm load the project npmrc b/test/fast/Unit tests/nvm debug does not let npm load the project npmrc new file mode 100755 index 00000000..71df7580 --- /dev/null +++ b/test/fast/Unit tests/nvm debug does not let npm load the project npmrc @@ -0,0 +1,39 @@ +#!/bin/sh + +TMP_DIR='' + +cleanup () { + case "${TMP_DIR}" in + /*) rm -rf "${TMP_DIR}" ;; + esac +} + +die () { echo "$@" ; cleanup ; exit 1; } + +: nvm.sh +\. ../../../nvm.sh + +TMP_DIR="$(mktemp -d)" +mkdir -p "${TMP_DIR}/project" || die 'could not make the project dir' +echo '{}' > "${TMP_DIR}/project/package.json" +echo "logs-dir=${TMP_DIR}/logs" > "${TMP_DIR}/project/.npmrc" + +NPM_CALLS="${TMP_DIR}/npm-calls" +npm() { + echo "$(pwd): $*" >> "${NPM_CALLS}" + echo "npm $*" +} + +OUTPUT="$(cd "${TMP_DIR}/project" && nvm debug 2>&1)" + +EXPECTED_CALLS="/: config get prefix +/: root -g" +CALLS="$(cat "${NPM_CALLS}")" +[ "_${CALLS}" = "_${EXPECTED_CALLS}" ] || die "nvm debug should run npm outside the project: expected >${EXPECTED_CALLS}<; got >${CALLS}<" + +case "${OUTPUT}" in + *"npm config get prefix: npm config get prefix"*"npm root -g: npm root -g"*) ;; + *) die "nvm debug should print npm's prefix and global root; got >${OUTPUT}<" ;; +esac + +cleanup