[Tests] make fast tests pass as root, without sudo, and without a terminal

Six fast tests failed outside of CI's setup,
which runs them as a non-root user with `sudo` and a terminal.
`nvm_download_artifact error propagation` expected `mkdir -p` under `/nonexistent` to fail,
which root can create; it now uses a path under a regular file, which nobody can create.
`nvm_get_arch_unofficial` now only uses `sudo` when it is not already root,
and skips the chroot checks when it can do neither.
`nvm_write_nvmrc`'s permissions check and the `nvm uninstall` permissions test are skipped as root,
since root ignores file permissions.
`nvm_stdout_is_terminal`'s `/dev/tty` checks are skipped when there is no controlling terminal,
as in `docker run` without `-t`.
`nvm_process_nvmrc` now fails with a clear message when the `test/fixtures/nvmrc` submodule is not checked out,
instead of on an unexpanded glob.
This is not a vulnerability fix.
This commit is contained in:
Jordan Harband committed 2026-11-04 14:12:38 -06:00
1 parent c314f1cbb3
commit e1927f5096
6 files changed
+43 -16

No files matched your search

+8 -6
View File
@@ -66,12 +66,14 @@ del_alias
nvm alias test "$TEST_VERSION"
test_version test || die
# 3. fails with invalid permissions
del_nvmrc
touch .nvmrc
chmod 0 .nvmrc
nvm_write_nvmrc $TEST_VERSION 2>/dev/null && die "\`nvm_write_nvmrc $TEST_VERSION\` did not fail with invalid permissions"
del_nvmrc
# 3. fails with invalid permissions (root ignores file permissions, so this can only be checked as another user)
if [ "$(command id -u)" != '0' ]; then
del_nvmrc
touch .nvmrc
chmod 0 .nvmrc
nvm_write_nvmrc $TEST_VERSION 2>/dev/null && die "\`nvm_write_nvmrc $TEST_VERSION\` did not fail with invalid permissions"
del_nvmrc
fi
# 4. respects NVM_SILENT=1
export NVM_SILENT=1