eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-10-11 00:00:13 +08:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

[Perf] nvm_is_valid_version, nvm_validate_implicit_alias: avoid forks

Browse Source
This commit is contained in:
Cassidy Marble
2026-10-06 18:01:38 -03:00
committed by Jordan Harband
parent 66640e6000
commit 9c8cac4a2e
2 changed files with 30 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/fast/Unit tests/nvm_is_valid_version
+19
View File
@@ -41,3 +41,22 @@ nvm_is_valid_version v9.9.1-nightly201803256591d9f761 || die "nvm_is_valid_versi
nvm_is_valid_version v9.0.0-v8-canary201710301f8f3dcf36 || die "nvm_is_valid_version v9.0.0-v8-canary201710301f8f3dcf36 did not return 0"
nvm_is_valid_version v8.16.2-test201910293843c56739f || die "nvm_is_valid_version v8.16.2-test201910293843c56739f did not return 0"
nvm_is_valid_version iojs-v3.2.1-nightly201508291a531b4e44 || die "nvm_is_valid_version iojs-v3.2.1-nightly201508291a531b4e44 did not return 0"
# `nvm_is_valid_version` must not fork a command for a plain version: mock
# `awk`, which the version comparisons used, and fail if it runs. (Prereleases
# still reach the comparison, which is why this checks a release version.)
TEST_DIR="$(pwd)/nvm_is_valid_version_tmp"
[ ! -e "${TEST_DIR}" ] && mkdir "${TEST_DIR}"
MOCK_BIN="${TEST_DIR}/bin"
mkdir -p "${MOCK_BIN}"
{
echo '#!/bin/sh'
echo 'echo "awk was called" >&2'
echo 'exit 1'
} > "${MOCK_BIN}/awk"
chmod +x "${MOCK_BIN}/awk"
PATH="${MOCK_BIN}:${PATH}" nvm_is_valid_version v18.20.0 \
|| die 'nvm_is_valid_version v18.20.0 forked a command'
rm -rf "${TEST_DIR}"