eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2025-10-30 09:18:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Fix] Improve nvm_is_version_installed to check for a node executable instead of root dir

Browse Source
This commit is contained in:
Joshua Li
2018-05-31 15:26:30 -07:00
committed by Jordan Harband
parent a5f42d9cea
commit 0cdc184168
6 changed files with 27 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/installation_node/install hook
View File

@@ -19,6 +19,12 @@ fail() {
! nvm_is_version_installed "${VERSION}" || nvm uninstall "${VERSION}" || die 'uninstall failed'
# an existing but empty VERSION_PATH directory should not be enough to satisfy nvm_is_version_installed
rm -rf "${VERSION_PATH}"
mkdir -p "${VERSION_PATH}"
nvm_is_version_installed "${VERSION}" && die 'nvm_is_version_installed check not strict enough'
rmdir "${VERSION_PATH}"
OUTPUT="$(NVM_INSTALL_THIRD_PARTY_HOOK=succeed nvm install "${VERSION}")"
USE_OUTPUT="$(nvm use "${VERSION}")"
EXPECTED_OUTPUT="${VERSION} node std binary ${VERSION_PATH}