From 015c4f1e3b3bd6fdf6ff1236726170c2420ea77e Mon Sep 17 00:00:00 2001 From: Iain Date: Wed, 11 Nov 2026 12:55:38 +0000 Subject: [PATCH] [Fix] `install-latest-npm`: npm v12 is out --- .github/workflows/latest-npm.yml | 2 ++ nvm.sh | 32 +++++++++++++++++++++ test/fast/Unit tests/nvm_install_latest_npm | 27 +++++++++++++++++ 3 files changed, 61 insertions(+) diff --git a/.github/workflows/latest-npm.yml b/.github/workflows/latest-npm.yml index 1b095ab5..05cad229 100644 --- a/.github/workflows/latest-npm.yml +++ b/.github/workflows/latest-npm.yml @@ -37,6 +37,8 @@ jobs: matrix: node-version: ${{ fromJson(needs.matrix.outputs.latest) }} include: + - node-version: "24.14" + - node-version: "22.22.1" - node-version: "21" - node-version: "20.5" - node-version: "20.4" diff --git a/nvm.sh b/nvm.sh index ffc1941e..106e327e 100755 --- a/nvm.sh +++ b/nvm.sh @@ -680,6 +680,31 @@ nvm_install_latest_npm() { if [ $NVM_IS_21_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 22.9.0; then NVM_IS_22_9_OR_ABOVE=1 fi + local NVM_IS_22_22_2_OR_ABOVE + NVM_IS_22_22_2_OR_ABOVE=0 + if [ $NVM_IS_22_9_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 22.22.2; then + NVM_IS_22_22_2_OR_ABOVE=1 + fi + local NVM_IS_23_OR_ABOVE + NVM_IS_23_OR_ABOVE=0 + if [ $NVM_IS_22_22_2_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 23.0.0; then + NVM_IS_23_OR_ABOVE=1 + fi + local NVM_IS_24_15_OR_ABOVE + NVM_IS_24_15_OR_ABOVE=0 + if [ $NVM_IS_23_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 24.15.0; then + NVM_IS_24_15_OR_ABOVE=1 + fi + local NVM_IS_25_OR_ABOVE + NVM_IS_25_OR_ABOVE=0 + if [ $NVM_IS_24_15_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 25.0.0; then + NVM_IS_25_OR_ABOVE=1 + fi + local NVM_IS_26_OR_ABOVE + NVM_IS_26_OR_ABOVE=0 + if [ $NVM_IS_25_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 26.0.0; then + NVM_IS_26_OR_ABOVE=1 + fi if [ $NVM_IS_4_4_OR_BELOW -eq 1 ] || { [ $NVM_IS_5_OR_ABOVE -eq 1 ] && nvm_version_greater 5.10.0 "${NODE_VERSION}"; \ @@ -734,6 +759,13 @@ nvm_install_latest_npm() { ; then nvm_echo '* `npm` `v10.x` is the last version that works on `node` `< v20.17`, `v21`, or `v22.0` - `v22.8`' $NVM_NPM_CMD install -g npm@10 + elif \ + [ $NVM_IS_22_22_2_OR_ABOVE -eq 0 ] \ + || { [ $NVM_IS_23_OR_ABOVE -eq 1 ] && [ $NVM_IS_24_15_OR_ABOVE -eq 0 ]; } \ + || { [ $NVM_IS_25_OR_ABOVE -eq 1 ] && [ $NVM_IS_26_OR_ABOVE -eq 0 ]; } \ + ; then + nvm_echo '* `npm` `v11.x` is the last version that works on `node` `< v22.22.2`, `v23`, `v24.0` - `v24.14`, or `v25`' + $NVM_NPM_CMD install -g npm@11 else nvm_echo '* Installing latest `npm`; if this does not work on your node version, please report a bug!' $NVM_NPM_CMD install -g npm diff --git a/test/fast/Unit tests/nvm_install_latest_npm b/test/fast/Unit tests/nvm_install_latest_npm index a1f8f0f5..2a4837f3 100755 --- a/test/fast/Unit tests/nvm_install_latest_npm +++ b/test/fast/Unit tests/nvm_install_latest_npm @@ -54,3 +54,30 @@ try_err nvm_install_latest_npm EXPECTED="Unable to obtain npm version." [ "${CAPTURED_STDERR}" = "${EXPECTED}" ] || die "When node is system and npm is unavailable, expected >${EXPECTED}<; got >${CAPTURED_STDERR}" + +nvm_ls_current() { + node --version +} +node() { + echo "${TEST_NODE_VERSION}" +} +npm() { + case "${1-}" in + --version) echo '10.9.0' ;; + *) echo "npm $*" ;; + esac +} +for TEST_NODE_VERSION in v21.7.3 v22.8.0; do + OUTPUT="$(nvm_install_latest_npm | grep 'install -g')" + [ "${OUTPUT}" = 'npm install -g npm@10' ] || die "on node ${TEST_NODE_VERSION}, expected npm@10; got >${OUTPUT}<" +done + +for TEST_NODE_VERSION in v20.17.0 v22.9.0 v22.22.1 v23.0.0 v24.14.1 v25.0.0; do + OUTPUT="$(nvm_install_latest_npm | grep 'install -g')" + [ "${OUTPUT}" = 'npm install -g npm@11' ] || die "on node ${TEST_NODE_VERSION}, expected npm@11; got >${OUTPUT}<" +done + +for TEST_NODE_VERSION in v22.22.2 v24.15.0 v26.0.0; do + OUTPUT="$(nvm_install_latest_npm | grep 'install -g')" + [ "${OUTPUT}" = 'npm install -g npm' ] || die "on node ${TEST_NODE_VERSION}, expected the latest npm; got >${OUTPUT}<" +done