mirror of
https://github.com/instructkr/claw-code.git
synced 2026-04-07 16:44:50 +08:00
Compare commits
2 Commits
rcc/plugin
...
rcc/jsonl-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5cee042e59 | ||
|
|
c80603556d |
12
rust/Cargo.lock
generated
12
rust/Cargo.lock
generated
@@ -111,7 +111,6 @@ dependencies = [
|
|||||||
name = "commands"
|
name = "commands"
|
||||||
version = "0.1.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"plugins",
|
|
||||||
"runtime",
|
"runtime",
|
||||||
]
|
]
|
||||||
|
|
||||||
@@ -826,14 +825,6 @@ dependencies = [
|
|||||||
"time",
|
"time",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
|
||||||
name = "plugins"
|
|
||||||
version = "0.1.0"
|
|
||||||
dependencies = [
|
|
||||||
"serde",
|
|
||||||
"serde_json",
|
|
||||||
]
|
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "potential_utf"
|
name = "potential_utf"
|
||||||
version = "0.1.4"
|
version = "0.1.4"
|
||||||
@@ -1101,7 +1092,6 @@ name = "runtime"
|
|||||||
version = "0.1.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"glob",
|
"glob",
|
||||||
"plugins",
|
|
||||||
"regex",
|
"regex",
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
@@ -1191,7 +1181,6 @@ dependencies = [
|
|||||||
"commands",
|
"commands",
|
||||||
"compat-harness",
|
"compat-harness",
|
||||||
"crossterm",
|
"crossterm",
|
||||||
"plugins",
|
|
||||||
"pulldown-cmark",
|
"pulldown-cmark",
|
||||||
"runtime",
|
"runtime",
|
||||||
"rustyline",
|
"rustyline",
|
||||||
@@ -1557,7 +1546,6 @@ name = "tools"
|
|||||||
version = "0.1.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"api",
|
"api",
|
||||||
"plugins",
|
|
||||||
"reqwest",
|
"reqwest",
|
||||||
"runtime",
|
"runtime",
|
||||||
"serde",
|
"serde",
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
# 🦞 Claw Code — Rust Implementation
|
# 🦞 Claw Code — Rust Implementation
|
||||||
|
|
||||||
A high-performance Rust rewrite of the Claw Code CLI agent harness. Built for speed, safety, and native tool execution.
|
A high-performance Rust rewrite of the Claude Code CLI agent harness. Built for speed, safety, and native tool execution.
|
||||||
|
|
||||||
## Quick Start
|
## Quick Start
|
||||||
|
|
||||||
|
|||||||
@@ -216,64 +216,4 @@ mod tests {
|
|||||||
))
|
))
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn parses_thinking_content_block_start() {
|
|
||||||
let frame = concat!(
|
|
||||||
"event: content_block_start\n",
|
|
||||||
"data: {\"type\":\"content_block_start\",\"index\":0,\"content_block\":{\"type\":\"thinking\",\"thinking\":\"\",\"signature\":null}}\n\n"
|
|
||||||
);
|
|
||||||
|
|
||||||
let event = parse_frame(frame).expect("frame should parse");
|
|
||||||
assert_eq!(
|
|
||||||
event,
|
|
||||||
Some(StreamEvent::ContentBlockStart(
|
|
||||||
crate::types::ContentBlockStartEvent {
|
|
||||||
index: 0,
|
|
||||||
content_block: OutputContentBlock::Thinking {
|
|
||||||
thinking: String::new(),
|
|
||||||
signature: None,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
))
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn parses_thinking_related_deltas() {
|
|
||||||
let thinking = concat!(
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"thinking_delta\",\"thinking\":\"step 1\"}}\n\n"
|
|
||||||
);
|
|
||||||
let signature = concat!(
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"signature_delta\",\"signature\":\"sig_123\"}}\n\n"
|
|
||||||
);
|
|
||||||
|
|
||||||
let thinking_event = parse_frame(thinking).expect("thinking delta should parse");
|
|
||||||
let signature_event = parse_frame(signature).expect("signature delta should parse");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
thinking_event,
|
|
||||||
Some(StreamEvent::ContentBlockDelta(
|
|
||||||
crate::types::ContentBlockDeltaEvent {
|
|
||||||
index: 0,
|
|
||||||
delta: ContentBlockDelta::ThinkingDelta {
|
|
||||||
thinking: "step 1".to_string(),
|
|
||||||
},
|
|
||||||
}
|
|
||||||
))
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
signature_event,
|
|
||||||
Some(StreamEvent::ContentBlockDelta(
|
|
||||||
crate::types::ContentBlockDeltaEvent {
|
|
||||||
index: 0,
|
|
||||||
delta: ContentBlockDelta::SignatureDelta {
|
|
||||||
signature: "sig_123".to_string(),
|
|
||||||
},
|
|
||||||
}
|
|
||||||
))
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -135,15 +135,6 @@ pub enum OutputContentBlock {
|
|||||||
name: String,
|
name: String,
|
||||||
input: Value,
|
input: Value,
|
||||||
},
|
},
|
||||||
Thinking {
|
|
||||||
#[serde(default)]
|
|
||||||
thinking: String,
|
|
||||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
||||||
signature: Option<String>,
|
|
||||||
},
|
|
||||||
RedactedThinking {
|
|
||||||
data: Value,
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
||||||
@@ -199,8 +190,6 @@ pub struct ContentBlockDeltaEvent {
|
|||||||
pub enum ContentBlockDelta {
|
pub enum ContentBlockDelta {
|
||||||
TextDelta { text: String },
|
TextDelta { text: String },
|
||||||
InputJsonDelta { partial_json: String },
|
InputJsonDelta { partial_json: String },
|
||||||
ThinkingDelta { thinking: String },
|
|
||||||
SignatureDelta { signature: String },
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
||||||
|
|||||||
@@ -75,48 +75,6 @@ async fn send_message_posts_json_and_parses_response() {
|
|||||||
assert_eq!(body["tool_choice"]["type"], json!("auto"));
|
assert_eq!(body["tool_choice"]["type"], json!("auto"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn send_message_parses_response_with_thinking_blocks() {
|
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
|
||||||
let body = concat!(
|
|
||||||
"{",
|
|
||||||
"\"id\":\"msg_thinking\",",
|
|
||||||
"\"type\":\"message\",",
|
|
||||||
"\"role\":\"assistant\",",
|
|
||||||
"\"content\":[",
|
|
||||||
"{\"type\":\"thinking\",\"thinking\":\"step 1\",\"signature\":\"sig_123\"},",
|
|
||||||
"{\"type\":\"text\",\"text\":\"Final answer\"}",
|
|
||||||
"],",
|
|
||||||
"\"model\":\"claude-3-7-sonnet-latest\",",
|
|
||||||
"\"stop_reason\":\"end_turn\",",
|
|
||||||
"\"stop_sequence\":null,",
|
|
||||||
"\"usage\":{\"input_tokens\":12,\"output_tokens\":4}",
|
|
||||||
"}"
|
|
||||||
);
|
|
||||||
let server = spawn_server(
|
|
||||||
state,
|
|
||||||
vec![http_response("200 OK", "application/json", body)],
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
let client = AnthropicClient::new("test-key").with_base_url(server.base_url());
|
|
||||||
let response = client
|
|
||||||
.send_message(&sample_request(false))
|
|
||||||
.await
|
|
||||||
.expect("request should succeed");
|
|
||||||
|
|
||||||
assert_eq!(response.content.len(), 2);
|
|
||||||
assert!(matches!(
|
|
||||||
&response.content[0],
|
|
||||||
OutputContentBlock::Thinking { thinking, signature }
|
|
||||||
if thinking == "step 1" && signature.as_deref() == Some("sig_123")
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&response.content[1],
|
|
||||||
OutputContentBlock::Text { text } if text == "Final answer"
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn stream_message_parses_sse_events_with_tool_use() {
|
async fn stream_message_parses_sse_events_with_tool_use() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
@@ -204,85 +162,6 @@ async fn stream_message_parses_sse_events_with_tool_use() {
|
|||||||
assert!(request.body.contains("\"stream\":true"));
|
assert!(request.body.contains("\"stream\":true"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn stream_message_parses_sse_events_with_thinking_blocks() {
|
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
|
||||||
let sse = concat!(
|
|
||||||
"event: message_start\n",
|
|
||||||
"data: {\"type\":\"message_start\",\"message\":{\"id\":\"msg_stream_thinking\",\"type\":\"message\",\"role\":\"assistant\",\"content\":[],\"model\":\"claude-3-7-sonnet-latest\",\"stop_reason\":null,\"stop_sequence\":null,\"usage\":{\"input_tokens\":8,\"output_tokens\":0}}}\n\n",
|
|
||||||
"event: content_block_start\n",
|
|
||||||
"data: {\"type\":\"content_block_start\",\"index\":0,\"content_block\":{\"type\":\"thinking\",\"thinking\":\"\"}}\n\n",
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"thinking_delta\",\"thinking\":\"step 1\"}}\n\n",
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"signature_delta\",\"signature\":\"sig_123\"}}\n\n",
|
|
||||||
"event: content_block_stop\n",
|
|
||||||
"data: {\"type\":\"content_block_stop\",\"index\":0}\n\n",
|
|
||||||
"event: content_block_start\n",
|
|
||||||
"data: {\"type\":\"content_block_start\",\"index\":1,\"content_block\":{\"type\":\"text\",\"text\":\"Final answer\"}}\n\n",
|
|
||||||
"event: content_block_stop\n",
|
|
||||||
"data: {\"type\":\"content_block_stop\",\"index\":1}\n\n",
|
|
||||||
"event: message_delta\n",
|
|
||||||
"data: {\"type\":\"message_delta\",\"delta\":{\"stop_reason\":\"end_turn\",\"stop_sequence\":null},\"usage\":{\"input_tokens\":8,\"output_tokens\":1}}\n\n",
|
|
||||||
"event: message_stop\n",
|
|
||||||
"data: {\"type\":\"message_stop\"}\n\n",
|
|
||||||
"data: [DONE]\n\n"
|
|
||||||
);
|
|
||||||
let server = spawn_server(
|
|
||||||
state,
|
|
||||||
vec![http_response("200 OK", "text/event-stream", sse)],
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
let client = AnthropicClient::new("test-key").with_base_url(server.base_url());
|
|
||||||
let mut stream = client
|
|
||||||
.stream_message(&sample_request(false))
|
|
||||||
.await
|
|
||||||
.expect("stream should start");
|
|
||||||
|
|
||||||
let mut events = Vec::new();
|
|
||||||
while let Some(event) = stream
|
|
||||||
.next_event()
|
|
||||||
.await
|
|
||||||
.expect("stream event should parse")
|
|
||||||
{
|
|
||||||
events.push(event);
|
|
||||||
}
|
|
||||||
|
|
||||||
assert_eq!(events.len(), 9);
|
|
||||||
assert!(matches!(
|
|
||||||
&events[1],
|
|
||||||
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
|
||||||
content_block: OutputContentBlock::Thinking { thinking, signature },
|
|
||||||
..
|
|
||||||
}) if thinking.is_empty() && signature.is_none()
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[2],
|
|
||||||
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
|
||||||
delta: ContentBlockDelta::ThinkingDelta { thinking },
|
|
||||||
..
|
|
||||||
}) if thinking == "step 1"
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[3],
|
|
||||||
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
|
||||||
delta: ContentBlockDelta::SignatureDelta { signature },
|
|
||||||
..
|
|
||||||
}) if signature == "sig_123"
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[5],
|
|
||||||
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
|
||||||
content_block: OutputContentBlock::Text { text },
|
|
||||||
..
|
|
||||||
}) if text == "Final answer"
|
|
||||||
));
|
|
||||||
assert!(matches!(events[6], StreamEvent::ContentBlockStop(_)));
|
|
||||||
assert!(matches!(events[7], StreamEvent::MessageDelta(_)));
|
|
||||||
assert!(matches!(events[8], StreamEvent::MessageStop(_)));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn retries_retryable_failures_before_succeeding() {
|
async fn retries_retryable_failures_before_succeeding() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
|||||||
@@ -9,5 +9,4 @@ publish.workspace = true
|
|||||||
workspace = true
|
workspace = true
|
||||||
|
|
||||||
[dependencies]
|
[dependencies]
|
||||||
plugins = { path = "../plugins" }
|
|
||||||
runtime = { path = "../runtime" }
|
runtime = { path = "../runtime" }
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -70,12 +70,16 @@ fn upstream_repo_candidates(primary_repo_root: &Path) -> Vec<PathBuf> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
for ancestor in primary_repo_root.ancestors().take(4) {
|
for ancestor in primary_repo_root.ancestors().take(4) {
|
||||||
candidates.push(ancestor.join("claw-code"));
|
candidates.push(ancestor.join("claude-code"));
|
||||||
candidates.push(ancestor.join("clawd-code"));
|
candidates.push(ancestor.join("clawd-code"));
|
||||||
}
|
}
|
||||||
|
|
||||||
candidates.push(primary_repo_root.join("reference-source").join("claw-code"));
|
candidates.push(
|
||||||
candidates.push(primary_repo_root.join("vendor").join("claw-code"));
|
primary_repo_root
|
||||||
|
.join("reference-source")
|
||||||
|
.join("claude-code"),
|
||||||
|
);
|
||||||
|
candidates.push(primary_repo_root.join("vendor").join("claude-code"));
|
||||||
|
|
||||||
let mut deduped = Vec::new();
|
let mut deduped = Vec::new();
|
||||||
for candidate in candidates {
|
for candidate in candidates {
|
||||||
|
|||||||
@@ -1,13 +0,0 @@
|
|||||||
[package]
|
|
||||||
name = "plugins"
|
|
||||||
version.workspace = true
|
|
||||||
edition.workspace = true
|
|
||||||
license.workspace = true
|
|
||||||
publish.workspace = true
|
|
||||||
|
|
||||||
[dependencies]
|
|
||||||
serde = { version = "1", features = ["derive"] }
|
|
||||||
serde_json = "1"
|
|
||||||
|
|
||||||
[lints]
|
|
||||||
workspace = true
|
|
||||||
@@ -1,10 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "example-bundled",
|
|
||||||
"version": "0.1.0",
|
|
||||||
"description": "Example bundled plugin scaffold for the Rust plugin system",
|
|
||||||
"defaultEnabled": false,
|
|
||||||
"hooks": {
|
|
||||||
"PreToolUse": ["./hooks/pre.sh"],
|
|
||||||
"PostToolUse": ["./hooks/post.sh"]
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
printf '%s\n' 'example bundled post hook'
|
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
printf '%s\n' 'example bundled pre hook'
|
|
||||||
@@ -1,10 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "sample-hooks",
|
|
||||||
"version": "0.1.0",
|
|
||||||
"description": "Bundled sample plugin scaffold for hook integration tests.",
|
|
||||||
"defaultEnabled": false,
|
|
||||||
"hooks": {
|
|
||||||
"PreToolUse": ["./hooks/pre.sh"],
|
|
||||||
"PostToolUse": ["./hooks/post.sh"]
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
printf 'sample bundled post hook'
|
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
printf 'sample bundled pre hook'
|
|
||||||
@@ -1,395 +0,0 @@
|
|||||||
use std::ffi::OsStr;
|
|
||||||
use std::path::Path;
|
|
||||||
use std::process::Command;
|
|
||||||
|
|
||||||
use serde_json::json;
|
|
||||||
|
|
||||||
use crate::{PluginError, PluginHooks, PluginRegistry};
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
|
||||||
pub enum HookEvent {
|
|
||||||
PreToolUse,
|
|
||||||
PostToolUse,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl HookEvent {
|
|
||||||
fn as_str(self) -> &'static str {
|
|
||||||
match self {
|
|
||||||
Self::PreToolUse => "PreToolUse",
|
|
||||||
Self::PostToolUse => "PostToolUse",
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
||||||
pub struct HookRunResult {
|
|
||||||
denied: bool,
|
|
||||||
messages: Vec<String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl HookRunResult {
|
|
||||||
#[must_use]
|
|
||||||
pub fn allow(messages: Vec<String>) -> Self {
|
|
||||||
Self {
|
|
||||||
denied: false,
|
|
||||||
messages,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn is_denied(&self) -> bool {
|
|
||||||
self.denied
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn messages(&self) -> &[String] {
|
|
||||||
&self.messages
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
|
||||||
pub struct HookRunner {
|
|
||||||
hooks: PluginHooks,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl HookRunner {
|
|
||||||
#[must_use]
|
|
||||||
pub fn new(hooks: PluginHooks) -> Self {
|
|
||||||
Self { hooks }
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn from_registry(plugin_registry: &PluginRegistry) -> Result<Self, PluginError> {
|
|
||||||
Ok(Self::new(plugin_registry.aggregated_hooks()?))
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn run_pre_tool_use(&self, tool_name: &str, tool_input: &str) -> HookRunResult {
|
|
||||||
self.run_commands(
|
|
||||||
HookEvent::PreToolUse,
|
|
||||||
&self.hooks.pre_tool_use,
|
|
||||||
tool_name,
|
|
||||||
tool_input,
|
|
||||||
None,
|
|
||||||
false,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn run_post_tool_use(
|
|
||||||
&self,
|
|
||||||
tool_name: &str,
|
|
||||||
tool_input: &str,
|
|
||||||
tool_output: &str,
|
|
||||||
is_error: bool,
|
|
||||||
) -> HookRunResult {
|
|
||||||
self.run_commands(
|
|
||||||
HookEvent::PostToolUse,
|
|
||||||
&self.hooks.post_tool_use,
|
|
||||||
tool_name,
|
|
||||||
tool_input,
|
|
||||||
Some(tool_output),
|
|
||||||
is_error,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn run_commands(
|
|
||||||
&self,
|
|
||||||
event: HookEvent,
|
|
||||||
commands: &[String],
|
|
||||||
tool_name: &str,
|
|
||||||
tool_input: &str,
|
|
||||||
tool_output: Option<&str>,
|
|
||||||
is_error: bool,
|
|
||||||
) -> HookRunResult {
|
|
||||||
if commands.is_empty() {
|
|
||||||
return HookRunResult::allow(Vec::new());
|
|
||||||
}
|
|
||||||
|
|
||||||
let payload = json!({
|
|
||||||
"hook_event_name": event.as_str(),
|
|
||||||
"tool_name": tool_name,
|
|
||||||
"tool_input": parse_tool_input(tool_input),
|
|
||||||
"tool_input_json": tool_input,
|
|
||||||
"tool_output": tool_output,
|
|
||||||
"tool_result_is_error": is_error,
|
|
||||||
})
|
|
||||||
.to_string();
|
|
||||||
|
|
||||||
let mut messages = Vec::new();
|
|
||||||
|
|
||||||
for command in commands {
|
|
||||||
match self.run_command(
|
|
||||||
command,
|
|
||||||
event,
|
|
||||||
tool_name,
|
|
||||||
tool_input,
|
|
||||||
tool_output,
|
|
||||||
is_error,
|
|
||||||
&payload,
|
|
||||||
) {
|
|
||||||
HookCommandOutcome::Allow { message } => {
|
|
||||||
if let Some(message) = message {
|
|
||||||
messages.push(message);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
HookCommandOutcome::Deny { message } => {
|
|
||||||
messages.push(message.unwrap_or_else(|| {
|
|
||||||
format!("{} hook denied tool `{tool_name}`", event.as_str())
|
|
||||||
}));
|
|
||||||
return HookRunResult {
|
|
||||||
denied: true,
|
|
||||||
messages,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
HookCommandOutcome::Warn { message } => messages.push(message),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
HookRunResult::allow(messages)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::too_many_arguments, clippy::unused_self)]
|
|
||||||
fn run_command(
|
|
||||||
&self,
|
|
||||||
command: &str,
|
|
||||||
event: HookEvent,
|
|
||||||
tool_name: &str,
|
|
||||||
tool_input: &str,
|
|
||||||
tool_output: Option<&str>,
|
|
||||||
is_error: bool,
|
|
||||||
payload: &str,
|
|
||||||
) -> HookCommandOutcome {
|
|
||||||
let mut child = shell_command(command);
|
|
||||||
child.stdin(std::process::Stdio::piped());
|
|
||||||
child.stdout(std::process::Stdio::piped());
|
|
||||||
child.stderr(std::process::Stdio::piped());
|
|
||||||
child.env("HOOK_EVENT", event.as_str());
|
|
||||||
child.env("HOOK_TOOL_NAME", tool_name);
|
|
||||||
child.env("HOOK_TOOL_INPUT", tool_input);
|
|
||||||
child.env("HOOK_TOOL_IS_ERROR", if is_error { "1" } else { "0" });
|
|
||||||
if let Some(tool_output) = tool_output {
|
|
||||||
child.env("HOOK_TOOL_OUTPUT", tool_output);
|
|
||||||
}
|
|
||||||
|
|
||||||
match child.output_with_stdin(payload.as_bytes()) {
|
|
||||||
Ok(output) => {
|
|
||||||
let stdout = String::from_utf8_lossy(&output.stdout).trim().to_string();
|
|
||||||
let stderr = String::from_utf8_lossy(&output.stderr).trim().to_string();
|
|
||||||
let message = (!stdout.is_empty()).then_some(stdout);
|
|
||||||
match output.status.code() {
|
|
||||||
Some(0) => HookCommandOutcome::Allow { message },
|
|
||||||
Some(2) => HookCommandOutcome::Deny { message },
|
|
||||||
Some(code) => HookCommandOutcome::Warn {
|
|
||||||
message: format_hook_warning(
|
|
||||||
command,
|
|
||||||
code,
|
|
||||||
message.as_deref(),
|
|
||||||
stderr.as_str(),
|
|
||||||
),
|
|
||||||
},
|
|
||||||
None => HookCommandOutcome::Warn {
|
|
||||||
message: format!(
|
|
||||||
"{} hook `{command}` terminated by signal while handling `{tool_name}`",
|
|
||||||
event.as_str()
|
|
||||||
),
|
|
||||||
},
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Err(error) => HookCommandOutcome::Warn {
|
|
||||||
message: format!(
|
|
||||||
"{} hook `{command}` failed to start for `{tool_name}`: {error}",
|
|
||||||
event.as_str()
|
|
||||||
),
|
|
||||||
},
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
enum HookCommandOutcome {
|
|
||||||
Allow { message: Option<String> },
|
|
||||||
Deny { message: Option<String> },
|
|
||||||
Warn { message: String },
|
|
||||||
}
|
|
||||||
|
|
||||||
fn parse_tool_input(tool_input: &str) -> serde_json::Value {
|
|
||||||
serde_json::from_str(tool_input).unwrap_or_else(|_| json!({ "raw": tool_input }))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn format_hook_warning(command: &str, code: i32, stdout: Option<&str>, stderr: &str) -> String {
|
|
||||||
let mut message =
|
|
||||||
format!("Hook `{command}` exited with status {code}; allowing tool execution to continue");
|
|
||||||
if let Some(stdout) = stdout.filter(|stdout| !stdout.is_empty()) {
|
|
||||||
message.push_str(": ");
|
|
||||||
message.push_str(stdout);
|
|
||||||
} else if !stderr.is_empty() {
|
|
||||||
message.push_str(": ");
|
|
||||||
message.push_str(stderr);
|
|
||||||
}
|
|
||||||
message
|
|
||||||
}
|
|
||||||
|
|
||||||
fn shell_command(command: &str) -> CommandWithStdin {
|
|
||||||
#[cfg(windows)]
|
|
||||||
let command_builder = {
|
|
||||||
let mut command_builder = Command::new("cmd");
|
|
||||||
command_builder.arg("/C").arg(command);
|
|
||||||
CommandWithStdin::new(command_builder)
|
|
||||||
};
|
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
|
||||||
let command_builder = if Path::new(command).exists() {
|
|
||||||
let mut command_builder = Command::new("sh");
|
|
||||||
command_builder.arg(command);
|
|
||||||
CommandWithStdin::new(command_builder)
|
|
||||||
} else {
|
|
||||||
let mut command_builder = Command::new("sh");
|
|
||||||
command_builder.arg("-lc").arg(command);
|
|
||||||
CommandWithStdin::new(command_builder)
|
|
||||||
};
|
|
||||||
|
|
||||||
command_builder
|
|
||||||
}
|
|
||||||
|
|
||||||
struct CommandWithStdin {
|
|
||||||
command: Command,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl CommandWithStdin {
|
|
||||||
fn new(command: Command) -> Self {
|
|
||||||
Self { command }
|
|
||||||
}
|
|
||||||
|
|
||||||
fn stdin(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
|
||||||
self.command.stdin(cfg);
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
fn stdout(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
|
||||||
self.command.stdout(cfg);
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
fn stderr(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
|
||||||
self.command.stderr(cfg);
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
fn env<K, V>(&mut self, key: K, value: V) -> &mut Self
|
|
||||||
where
|
|
||||||
K: AsRef<OsStr>,
|
|
||||||
V: AsRef<OsStr>,
|
|
||||||
{
|
|
||||||
self.command.env(key, value);
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
fn output_with_stdin(&mut self, stdin: &[u8]) -> std::io::Result<std::process::Output> {
|
|
||||||
let mut child = self.command.spawn()?;
|
|
||||||
if let Some(mut child_stdin) = child.stdin.take() {
|
|
||||||
use std::io::Write as _;
|
|
||||||
child_stdin.write_all(stdin)?;
|
|
||||||
}
|
|
||||||
child.wait_with_output()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod tests {
|
|
||||||
use super::{HookRunResult, HookRunner};
|
|
||||||
use crate::{PluginManager, PluginManagerConfig};
|
|
||||||
use std::fs;
|
|
||||||
use std::path::{Path, PathBuf};
|
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
|
||||||
|
|
||||||
fn temp_dir(label: &str) -> PathBuf {
|
|
||||||
let nanos = SystemTime::now()
|
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.expect("time should be after epoch")
|
|
||||||
.as_nanos();
|
|
||||||
std::env::temp_dir().join(format!("plugins-hook-runner-{label}-{nanos}"))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn write_hook_plugin(root: &Path, name: &str, pre_message: &str, post_message: &str) {
|
|
||||||
fs::create_dir_all(root.join(".claude-plugin")).expect("manifest dir");
|
|
||||||
fs::create_dir_all(root.join("hooks")).expect("hooks dir");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("pre.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{pre_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write pre hook");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("post.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{post_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write post hook");
|
|
||||||
fs::write(
|
|
||||||
root.join(".claude-plugin").join("plugin.json"),
|
|
||||||
format!(
|
|
||||||
"{{\n \"name\": \"{name}\",\n \"version\": \"1.0.0\",\n \"description\": \"hook plugin\",\n \"hooks\": {{\n \"PreToolUse\": [\"./hooks/pre.sh\"],\n \"PostToolUse\": [\"./hooks/post.sh\"]\n }}\n}}"
|
|
||||||
),
|
|
||||||
)
|
|
||||||
.expect("write plugin manifest");
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn collects_and_runs_hooks_from_enabled_plugins() {
|
|
||||||
let config_home = temp_dir("config");
|
|
||||||
let first_source_root = temp_dir("source-a");
|
|
||||||
let second_source_root = temp_dir("source-b");
|
|
||||||
write_hook_plugin(
|
|
||||||
&first_source_root,
|
|
||||||
"first",
|
|
||||||
"plugin pre one",
|
|
||||||
"plugin post one",
|
|
||||||
);
|
|
||||||
write_hook_plugin(
|
|
||||||
&second_source_root,
|
|
||||||
"second",
|
|
||||||
"plugin pre two",
|
|
||||||
"plugin post two",
|
|
||||||
);
|
|
||||||
|
|
||||||
let mut manager = PluginManager::new(PluginManagerConfig::new(&config_home));
|
|
||||||
manager
|
|
||||||
.install(first_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("first plugin install should succeed");
|
|
||||||
manager
|
|
||||||
.install(second_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("second plugin install should succeed");
|
|
||||||
let registry = manager.plugin_registry().expect("registry should build");
|
|
||||||
|
|
||||||
let runner = HookRunner::from_registry(®istry).expect("plugin hooks should load");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
runner.run_pre_tool_use("Read", r#"{"path":"README.md"}"#),
|
|
||||||
HookRunResult::allow(vec![
|
|
||||||
"plugin pre one".to_string(),
|
|
||||||
"plugin pre two".to_string(),
|
|
||||||
])
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
runner.run_post_tool_use("Read", r#"{"path":"README.md"}"#, "ok", false),
|
|
||||||
HookRunResult::allow(vec![
|
|
||||||
"plugin post one".to_string(),
|
|
||||||
"plugin post two".to_string(),
|
|
||||||
])
|
|
||||||
);
|
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(config_home);
|
|
||||||
let _ = fs::remove_dir_all(first_source_root);
|
|
||||||
let _ = fs::remove_dir_all(second_source_root);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn pre_tool_use_denies_when_plugin_hook_exits_two() {
|
|
||||||
let runner = HookRunner::new(crate::PluginHooks {
|
|
||||||
pre_tool_use: vec!["printf 'blocked by plugin'; exit 2".to_string()],
|
|
||||||
post_tool_use: Vec::new(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let result = runner.run_pre_tool_use("Bash", r#"{"command":"pwd"}"#);
|
|
||||||
|
|
||||||
assert!(result.is_denied());
|
|
||||||
assert_eq!(result.messages(), &["blocked by plugin".to_string()]);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
File diff suppressed because it is too large
Load Diff
@@ -8,7 +8,6 @@ publish.workspace = true
|
|||||||
[dependencies]
|
[dependencies]
|
||||||
sha2 = "0.10"
|
sha2 = "0.10"
|
||||||
glob = "0.3"
|
glob = "0.3"
|
||||||
plugins = { path = "../plugins" }
|
|
||||||
regex = "1"
|
regex = "1"
|
||||||
serde = { version = "1", features = ["derive"] }
|
serde = { version = "1", features = ["derive"] }
|
||||||
serde_json = "1"
|
serde_json = "1"
|
||||||
|
|||||||
@@ -1,10 +1,5 @@
|
|||||||
use crate::session::{ContentBlock, ConversationMessage, MessageRole, Session};
|
use crate::session::{ContentBlock, ConversationMessage, MessageRole, Session};
|
||||||
|
|
||||||
const COMPACT_CONTINUATION_PREAMBLE: &str =
|
|
||||||
"This session is being continued from a previous conversation that ran out of context. The summary below covers the earlier portion of the conversation.\n\n";
|
|
||||||
const COMPACT_RECENT_MESSAGES_NOTE: &str = "Recent messages are preserved verbatim.";
|
|
||||||
const COMPACT_DIRECT_RESUME_INSTRUCTION: &str = "Continue the conversation from where it left off without asking the user any further questions. Resume directly — do not acknowledge the summary, do not recap what was happening, and do not preface with continuation text.";
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
pub struct CompactionConfig {
|
pub struct CompactionConfig {
|
||||||
pub preserve_recent_messages: usize,
|
pub preserve_recent_messages: usize,
|
||||||
@@ -35,15 +30,8 @@ pub fn estimate_session_tokens(session: &Session) -> usize {
|
|||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn should_compact(session: &Session, config: CompactionConfig) -> bool {
|
pub fn should_compact(session: &Session, config: CompactionConfig) -> bool {
|
||||||
let start = compacted_summary_prefix_len(session);
|
session.messages.len() > config.preserve_recent_messages
|
||||||
let compactable = &session.messages[start..];
|
&& estimate_session_tokens(session) >= config.max_estimated_tokens
|
||||||
|
|
||||||
compactable.len() > config.preserve_recent_messages
|
|
||||||
&& compactable
|
|
||||||
.iter()
|
|
||||||
.map(estimate_message_tokens)
|
|
||||||
.sum::<usize>()
|
|
||||||
>= config.max_estimated_tokens
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
@@ -68,18 +56,16 @@ pub fn get_compact_continuation_message(
|
|||||||
recent_messages_preserved: bool,
|
recent_messages_preserved: bool,
|
||||||
) -> String {
|
) -> String {
|
||||||
let mut base = format!(
|
let mut base = format!(
|
||||||
"{COMPACT_CONTINUATION_PREAMBLE}{}",
|
"This session is being continued from a previous conversation that ran out of context. The summary below covers the earlier portion of the conversation.\n\n{}",
|
||||||
format_compact_summary(summary)
|
format_compact_summary(summary)
|
||||||
);
|
);
|
||||||
|
|
||||||
if recent_messages_preserved {
|
if recent_messages_preserved {
|
||||||
base.push_str("\n\n");
|
base.push_str("\n\nRecent messages are preserved verbatim.");
|
||||||
base.push_str(COMPACT_RECENT_MESSAGES_NOTE);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if suppress_follow_up_questions {
|
if suppress_follow_up_questions {
|
||||||
base.push('\n');
|
base.push_str("\nContinue the conversation from where it left off without asking the user any further questions. Resume directly — do not acknowledge the summary, do not recap what was happening, and do not preface with continuation text.");
|
||||||
base.push_str(COMPACT_DIRECT_RESUME_INSTRUCTION);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
base
|
base
|
||||||
@@ -96,19 +82,13 @@ pub fn compact_session(session: &Session, config: CompactionConfig) -> Compactio
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
let existing_summary = session
|
|
||||||
.messages
|
|
||||||
.first()
|
|
||||||
.and_then(extract_existing_compacted_summary);
|
|
||||||
let compacted_prefix_len = usize::from(existing_summary.is_some());
|
|
||||||
let keep_from = session
|
let keep_from = session
|
||||||
.messages
|
.messages
|
||||||
.len()
|
.len()
|
||||||
.saturating_sub(config.preserve_recent_messages);
|
.saturating_sub(config.preserve_recent_messages);
|
||||||
let removed = &session.messages[compacted_prefix_len..keep_from];
|
let removed = &session.messages[..keep_from];
|
||||||
let preserved = session.messages[keep_from..].to_vec();
|
let preserved = session.messages[keep_from..].to_vec();
|
||||||
let summary =
|
let summary = summarize_messages(removed);
|
||||||
merge_compact_summaries(existing_summary.as_deref(), &summarize_messages(removed));
|
|
||||||
let formatted_summary = format_compact_summary(&summary);
|
let formatted_summary = format_compact_summary(&summary);
|
||||||
let continuation = get_compact_continuation_message(&summary, true, !preserved.is_empty());
|
let continuation = get_compact_continuation_message(&summary, true, !preserved.is_empty());
|
||||||
|
|
||||||
@@ -119,27 +99,18 @@ pub fn compact_session(session: &Session, config: CompactionConfig) -> Compactio
|
|||||||
}];
|
}];
|
||||||
compacted_messages.extend(preserved);
|
compacted_messages.extend(preserved);
|
||||||
|
|
||||||
|
let mut compacted_session = session.clone();
|
||||||
|
compacted_session.messages = compacted_messages;
|
||||||
|
compacted_session.record_compaction(summary.clone(), removed.len());
|
||||||
|
|
||||||
CompactionResult {
|
CompactionResult {
|
||||||
summary,
|
summary,
|
||||||
formatted_summary,
|
formatted_summary,
|
||||||
compacted_session: Session {
|
compacted_session,
|
||||||
version: session.version,
|
|
||||||
messages: compacted_messages,
|
|
||||||
},
|
|
||||||
removed_message_count: removed.len(),
|
removed_message_count: removed.len(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn compacted_summary_prefix_len(session: &Session) -> usize {
|
|
||||||
usize::from(
|
|
||||||
session
|
|
||||||
.messages
|
|
||||||
.first()
|
|
||||||
.and_then(extract_existing_compacted_summary)
|
|
||||||
.is_some(),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn summarize_messages(messages: &[ConversationMessage]) -> String {
|
fn summarize_messages(messages: &[ConversationMessage]) -> String {
|
||||||
let user_messages = messages
|
let user_messages = messages
|
||||||
.iter()
|
.iter()
|
||||||
@@ -227,41 +198,6 @@ fn summarize_messages(messages: &[ConversationMessage]) -> String {
|
|||||||
lines.join("\n")
|
lines.join("\n")
|
||||||
}
|
}
|
||||||
|
|
||||||
fn merge_compact_summaries(existing_summary: Option<&str>, new_summary: &str) -> String {
|
|
||||||
let Some(existing_summary) = existing_summary else {
|
|
||||||
return new_summary.to_string();
|
|
||||||
};
|
|
||||||
|
|
||||||
let previous_highlights = extract_summary_highlights(existing_summary);
|
|
||||||
let new_formatted_summary = format_compact_summary(new_summary);
|
|
||||||
let new_highlights = extract_summary_highlights(&new_formatted_summary);
|
|
||||||
let new_timeline = extract_summary_timeline(&new_formatted_summary);
|
|
||||||
|
|
||||||
let mut lines = vec!["<summary>".to_string(), "Conversation summary:".to_string()];
|
|
||||||
|
|
||||||
if !previous_highlights.is_empty() {
|
|
||||||
lines.push("- Previously compacted context:".to_string());
|
|
||||||
lines.extend(
|
|
||||||
previous_highlights
|
|
||||||
.into_iter()
|
|
||||||
.map(|line| format!(" {line}")),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
if !new_highlights.is_empty() {
|
|
||||||
lines.push("- Newly compacted context:".to_string());
|
|
||||||
lines.extend(new_highlights.into_iter().map(|line| format!(" {line}")));
|
|
||||||
}
|
|
||||||
|
|
||||||
if !new_timeline.is_empty() {
|
|
||||||
lines.push("- Key timeline:".to_string());
|
|
||||||
lines.extend(new_timeline.into_iter().map(|line| format!(" {line}")));
|
|
||||||
}
|
|
||||||
|
|
||||||
lines.push("</summary>".to_string());
|
|
||||||
lines.join("\n")
|
|
||||||
}
|
|
||||||
|
|
||||||
fn summarize_block(block: &ContentBlock) -> String {
|
fn summarize_block(block: &ContentBlock) -> String {
|
||||||
let raw = match block {
|
let raw = match block {
|
||||||
ContentBlock::Text { text } => text.clone(),
|
ContentBlock::Text { text } => text.clone(),
|
||||||
@@ -439,71 +375,11 @@ fn collapse_blank_lines(content: &str) -> String {
|
|||||||
result
|
result
|
||||||
}
|
}
|
||||||
|
|
||||||
fn extract_existing_compacted_summary(message: &ConversationMessage) -> Option<String> {
|
|
||||||
if message.role != MessageRole::System {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
let text = first_text_block(message)?;
|
|
||||||
let summary = text.strip_prefix(COMPACT_CONTINUATION_PREAMBLE)?;
|
|
||||||
let summary = summary
|
|
||||||
.split_once(&format!("\n\n{COMPACT_RECENT_MESSAGES_NOTE}"))
|
|
||||||
.map_or(summary, |(value, _)| value);
|
|
||||||
let summary = summary
|
|
||||||
.split_once(&format!("\n{COMPACT_DIRECT_RESUME_INSTRUCTION}"))
|
|
||||||
.map_or(summary, |(value, _)| value);
|
|
||||||
Some(summary.trim().to_string())
|
|
||||||
}
|
|
||||||
|
|
||||||
fn extract_summary_highlights(summary: &str) -> Vec<String> {
|
|
||||||
let mut lines = Vec::new();
|
|
||||||
let mut in_timeline = false;
|
|
||||||
|
|
||||||
for line in format_compact_summary(summary).lines() {
|
|
||||||
let trimmed = line.trim_end();
|
|
||||||
if trimmed.is_empty() || trimmed == "Summary:" || trimmed == "Conversation summary:" {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if trimmed == "- Key timeline:" {
|
|
||||||
in_timeline = true;
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if in_timeline {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
lines.push(trimmed.to_string());
|
|
||||||
}
|
|
||||||
|
|
||||||
lines
|
|
||||||
}
|
|
||||||
|
|
||||||
fn extract_summary_timeline(summary: &str) -> Vec<String> {
|
|
||||||
let mut lines = Vec::new();
|
|
||||||
let mut in_timeline = false;
|
|
||||||
|
|
||||||
for line in format_compact_summary(summary).lines() {
|
|
||||||
let trimmed = line.trim_end();
|
|
||||||
if trimmed == "- Key timeline:" {
|
|
||||||
in_timeline = true;
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if !in_timeline {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if trimmed.is_empty() {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
lines.push(trimmed.to_string());
|
|
||||||
}
|
|
||||||
|
|
||||||
lines
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
collect_key_files, compact_session, estimate_session_tokens, format_compact_summary,
|
collect_key_files, compact_session, estimate_session_tokens, format_compact_summary,
|
||||||
get_compact_continuation_message, infer_pending_work, should_compact, CompactionConfig,
|
infer_pending_work, should_compact, CompactionConfig,
|
||||||
};
|
};
|
||||||
use crate::session::{ContentBlock, ConversationMessage, MessageRole, Session};
|
use crate::session::{ContentBlock, ConversationMessage, MessageRole, Session};
|
||||||
|
|
||||||
@@ -515,10 +391,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn leaves_small_sessions_unchanged() {
|
fn leaves_small_sessions_unchanged() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![ConversationMessage::user_text("hello")];
|
||||||
messages: vec![ConversationMessage::user_text("hello")],
|
|
||||||
};
|
|
||||||
|
|
||||||
let result = compact_session(&session, CompactionConfig::default());
|
let result = compact_session(&session, CompactionConfig::default());
|
||||||
assert_eq!(result.removed_message_count, 0);
|
assert_eq!(result.removed_message_count, 0);
|
||||||
@@ -529,9 +403,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn compacts_older_messages_into_a_system_summary() {
|
fn compacts_older_messages_into_a_system_summary() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![
|
||||||
messages: vec![
|
|
||||||
ConversationMessage::user_text("one ".repeat(200)),
|
ConversationMessage::user_text("one ".repeat(200)),
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
text: "two ".repeat(200),
|
text: "two ".repeat(200),
|
||||||
@@ -544,8 +417,7 @@ mod tests {
|
|||||||
}],
|
}],
|
||||||
usage: None,
|
usage: None,
|
||||||
},
|
},
|
||||||
],
|
];
|
||||||
};
|
|
||||||
|
|
||||||
let result = compact_session(
|
let result = compact_session(
|
||||||
&session,
|
&session,
|
||||||
@@ -578,98 +450,6 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn keeps_previous_compacted_context_when_compacting_again() {
|
|
||||||
let initial_session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
ConversationMessage::user_text("Investigate rust/crates/runtime/src/compact.rs"),
|
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "I will inspect the compact flow.".to_string(),
|
|
||||||
}]),
|
|
||||||
ConversationMessage::user_text(
|
|
||||||
"Also update rust/crates/runtime/src/conversation.rs",
|
|
||||||
),
|
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "Next: preserve prior summary context during auto compact.".to_string(),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
let config = CompactionConfig {
|
|
||||||
preserve_recent_messages: 2,
|
|
||||||
max_estimated_tokens: 1,
|
|
||||||
};
|
|
||||||
|
|
||||||
let first = compact_session(&initial_session, config);
|
|
||||||
let mut follow_up_messages = first.compacted_session.messages.clone();
|
|
||||||
follow_up_messages.extend([
|
|
||||||
ConversationMessage::user_text("Please add regression tests for compaction."),
|
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "Working on regression coverage now.".to_string(),
|
|
||||||
}]),
|
|
||||||
]);
|
|
||||||
|
|
||||||
let second = compact_session(
|
|
||||||
&Session {
|
|
||||||
version: 1,
|
|
||||||
messages: follow_up_messages,
|
|
||||||
},
|
|
||||||
config,
|
|
||||||
);
|
|
||||||
|
|
||||||
assert!(second
|
|
||||||
.formatted_summary
|
|
||||||
.contains("Previously compacted context:"));
|
|
||||||
assert!(second
|
|
||||||
.formatted_summary
|
|
||||||
.contains("Scope: 2 earlier messages compacted"));
|
|
||||||
assert!(second
|
|
||||||
.formatted_summary
|
|
||||||
.contains("Newly compacted context:"));
|
|
||||||
assert!(second
|
|
||||||
.formatted_summary
|
|
||||||
.contains("Also update rust/crates/runtime/src/conversation.rs"));
|
|
||||||
assert!(matches!(
|
|
||||||
&second.compacted_session.messages[0].blocks[0],
|
|
||||||
ContentBlock::Text { text }
|
|
||||||
if text.contains("Previously compacted context:")
|
|
||||||
&& text.contains("Newly compacted context:")
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&second.compacted_session.messages[1].blocks[0],
|
|
||||||
ContentBlock::Text { text } if text.contains("Please add regression tests for compaction.")
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn ignores_existing_compacted_summary_when_deciding_to_recompact() {
|
|
||||||
let summary = "<summary>Conversation summary:\n- Scope: earlier work preserved.\n- Key timeline:\n - user: large preserved context\n</summary>";
|
|
||||||
let session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
ConversationMessage {
|
|
||||||
role: MessageRole::System,
|
|
||||||
blocks: vec![ContentBlock::Text {
|
|
||||||
text: get_compact_continuation_message(summary, true, true),
|
|
||||||
}],
|
|
||||||
usage: None,
|
|
||||||
},
|
|
||||||
ConversationMessage::user_text("tiny"),
|
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "recent".to_string(),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
assert!(!should_compact(
|
|
||||||
&session,
|
|
||||||
CompactionConfig {
|
|
||||||
preserve_recent_messages: 2,
|
|
||||||
max_estimated_tokens: 1,
|
|
||||||
}
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn truncates_long_blocks_in_summary() {
|
fn truncates_long_blocks_in_summary() {
|
||||||
let summary = super::summarize_block(&ContentBlock::Text {
|
let summary = super::summarize_block(&ContentBlock::Text {
|
||||||
|
|||||||
@@ -35,19 +35,9 @@ pub struct RuntimeConfig {
|
|||||||
feature_config: RuntimeFeatureConfig,
|
feature_config: RuntimeFeatureConfig,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
|
||||||
pub struct RuntimePluginConfig {
|
|
||||||
enabled_plugins: BTreeMap<String, bool>,
|
|
||||||
external_directories: Vec<String>,
|
|
||||||
install_root: Option<String>,
|
|
||||||
registry_path: Option<String>,
|
|
||||||
bundled_root: Option<String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
pub struct RuntimeFeatureConfig {
|
pub struct RuntimeFeatureConfig {
|
||||||
hooks: RuntimeHookConfig,
|
hooks: RuntimeHookConfig,
|
||||||
plugins: RuntimePluginConfig,
|
|
||||||
mcp: McpConfigCollection,
|
mcp: McpConfigCollection,
|
||||||
oauth: Option<OAuthConfig>,
|
oauth: Option<OAuthConfig>,
|
||||||
model: Option<String>,
|
model: Option<String>,
|
||||||
@@ -184,15 +174,13 @@ impl ConfigLoader {
|
|||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn default_for(cwd: impl Into<PathBuf>) -> Self {
|
pub fn default_for(cwd: impl Into<PathBuf>) -> Self {
|
||||||
let cwd = cwd.into();
|
let cwd = cwd.into();
|
||||||
let config_home = default_config_home();
|
let config_home = std::env::var_os("CLAUDE_CONFIG_HOME")
|
||||||
|
.map(PathBuf::from)
|
||||||
|
.or_else(|| std::env::var_os("HOME").map(|home| PathBuf::from(home).join(".claude")))
|
||||||
|
.unwrap_or_else(|| PathBuf::from(".claude"));
|
||||||
Self { cwd, config_home }
|
Self { cwd, config_home }
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn config_home(&self) -> &Path {
|
|
||||||
&self.config_home
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn discover(&self) -> Vec<ConfigEntry> {
|
pub fn discover(&self) -> Vec<ConfigEntry> {
|
||||||
let user_legacy_path = self.config_home.parent().map_or_else(
|
let user_legacy_path = self.config_home.parent().map_or_else(
|
||||||
@@ -241,7 +229,6 @@ impl ConfigLoader {
|
|||||||
|
|
||||||
let feature_config = RuntimeFeatureConfig {
|
let feature_config = RuntimeFeatureConfig {
|
||||||
hooks: parse_optional_hooks_config(&merged_value)?,
|
hooks: parse_optional_hooks_config(&merged_value)?,
|
||||||
plugins: parse_optional_plugin_config(&merged_value)?,
|
|
||||||
mcp: McpConfigCollection {
|
mcp: McpConfigCollection {
|
||||||
servers: mcp_servers,
|
servers: mcp_servers,
|
||||||
},
|
},
|
||||||
@@ -304,11 +291,6 @@ impl RuntimeConfig {
|
|||||||
&self.feature_config.hooks
|
&self.feature_config.hooks
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn plugins(&self) -> &RuntimePluginConfig {
|
|
||||||
&self.feature_config.plugins
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
||||||
self.feature_config.oauth.as_ref()
|
self.feature_config.oauth.as_ref()
|
||||||
@@ -337,22 +319,11 @@ impl RuntimeFeatureConfig {
|
|||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn with_plugins(mut self, plugins: RuntimePluginConfig) -> Self {
|
|
||||||
self.plugins = plugins;
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn hooks(&self) -> &RuntimeHookConfig {
|
pub fn hooks(&self) -> &RuntimeHookConfig {
|
||||||
&self.hooks
|
&self.hooks
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn plugins(&self) -> &RuntimePluginConfig {
|
|
||||||
&self.plugins
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn mcp(&self) -> &McpConfigCollection {
|
pub fn mcp(&self) -> &McpConfigCollection {
|
||||||
&self.mcp
|
&self.mcp
|
||||||
@@ -379,53 +350,6 @@ impl RuntimeFeatureConfig {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl RuntimePluginConfig {
|
|
||||||
#[must_use]
|
|
||||||
pub fn enabled_plugins(&self) -> &BTreeMap<String, bool> {
|
|
||||||
&self.enabled_plugins
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn external_directories(&self) -> &[String] {
|
|
||||||
&self.external_directories
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn install_root(&self) -> Option<&str> {
|
|
||||||
self.install_root.as_deref()
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn registry_path(&self) -> Option<&str> {
|
|
||||||
self.registry_path.as_deref()
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn bundled_root(&self) -> Option<&str> {
|
|
||||||
self.bundled_root.as_deref()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn set_plugin_state(&mut self, plugin_id: String, enabled: bool) {
|
|
||||||
self.enabled_plugins.insert(plugin_id, enabled);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn state_for(&self, plugin_id: &str, default_enabled: bool) -> bool {
|
|
||||||
self.enabled_plugins
|
|
||||||
.get(plugin_id)
|
|
||||||
.copied()
|
|
||||||
.unwrap_or(default_enabled)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn default_config_home() -> PathBuf {
|
|
||||||
std::env::var_os("CLAUDE_CONFIG_HOME")
|
|
||||||
.map(PathBuf::from)
|
|
||||||
.or_else(|| std::env::var_os("HOME").map(|home| PathBuf::from(home).join(".claude")))
|
|
||||||
.unwrap_or_else(|| PathBuf::from(".claude"))
|
|
||||||
}
|
|
||||||
|
|
||||||
impl RuntimeHookConfig {
|
impl RuntimeHookConfig {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn new(pre_tool_use: Vec<String>, post_tool_use: Vec<String>) -> Self {
|
pub fn new(pre_tool_use: Vec<String>, post_tool_use: Vec<String>) -> Self {
|
||||||
@@ -444,18 +368,6 @@ impl RuntimeHookConfig {
|
|||||||
pub fn post_tool_use(&self) -> &[String] {
|
pub fn post_tool_use(&self) -> &[String] {
|
||||||
&self.post_tool_use
|
&self.post_tool_use
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn merged(&self, other: &Self) -> Self {
|
|
||||||
let mut merged = self.clone();
|
|
||||||
merged.extend(other);
|
|
||||||
merged
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn extend(&mut self, other: &Self) {
|
|
||||||
extend_unique(&mut self.pre_tool_use, other.pre_tool_use());
|
|
||||||
extend_unique(&mut self.post_tool_use, other.post_tool_use());
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl McpConfigCollection {
|
impl McpConfigCollection {
|
||||||
@@ -572,36 +484,6 @@ fn parse_optional_hooks_config(root: &JsonValue) -> Result<RuntimeHookConfig, Co
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
fn parse_optional_plugin_config(root: &JsonValue) -> Result<RuntimePluginConfig, ConfigError> {
|
|
||||||
let Some(object) = root.as_object() else {
|
|
||||||
return Ok(RuntimePluginConfig::default());
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut config = RuntimePluginConfig::default();
|
|
||||||
if let Some(enabled_plugins) = object.get("enabledPlugins") {
|
|
||||||
config.enabled_plugins = parse_bool_map(enabled_plugins, "merged settings.enabledPlugins")?;
|
|
||||||
}
|
|
||||||
|
|
||||||
let Some(plugins_value) = object.get("plugins") else {
|
|
||||||
return Ok(config);
|
|
||||||
};
|
|
||||||
let plugins = expect_object(plugins_value, "merged settings.plugins")?;
|
|
||||||
|
|
||||||
if let Some(enabled_value) = plugins.get("enabled") {
|
|
||||||
config.enabled_plugins = parse_bool_map(enabled_value, "merged settings.plugins.enabled")?;
|
|
||||||
}
|
|
||||||
config.external_directories =
|
|
||||||
optional_string_array(plugins, "externalDirectories", "merged settings.plugins")?
|
|
||||||
.unwrap_or_default();
|
|
||||||
config.install_root =
|
|
||||||
optional_string(plugins, "installRoot", "merged settings.plugins")?.map(str::to_string);
|
|
||||||
config.registry_path =
|
|
||||||
optional_string(plugins, "registryPath", "merged settings.plugins")?.map(str::to_string);
|
|
||||||
config.bundled_root =
|
|
||||||
optional_string(plugins, "bundledRoot", "merged settings.plugins")?.map(str::to_string);
|
|
||||||
Ok(config)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn parse_optional_permission_mode(
|
fn parse_optional_permission_mode(
|
||||||
root: &JsonValue,
|
root: &JsonValue,
|
||||||
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
||||||
@@ -834,24 +716,6 @@ fn optional_u16(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn parse_bool_map(value: &JsonValue, context: &str) -> Result<BTreeMap<String, bool>, ConfigError> {
|
|
||||||
let Some(map) = value.as_object() else {
|
|
||||||
return Err(ConfigError::Parse(format!(
|
|
||||||
"{context}: expected JSON object"
|
|
||||||
)));
|
|
||||||
};
|
|
||||||
map.iter()
|
|
||||||
.map(|(key, value)| {
|
|
||||||
value
|
|
||||||
.as_bool()
|
|
||||||
.map(|enabled| (key.clone(), enabled))
|
|
||||||
.ok_or_else(|| {
|
|
||||||
ConfigError::Parse(format!("{context}: field {key} must be a boolean"))
|
|
||||||
})
|
|
||||||
})
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn optional_string_array(
|
fn optional_string_array(
|
||||||
object: &BTreeMap<String, JsonValue>,
|
object: &BTreeMap<String, JsonValue>,
|
||||||
key: &str,
|
key: &str,
|
||||||
@@ -926,18 +790,6 @@ fn deep_merge_objects(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn extend_unique(target: &mut Vec<String>, values: &[String]) {
|
|
||||||
for value in values {
|
|
||||||
push_unique(target, value.clone());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn push_unique(target: &mut Vec<String>, value: String) {
|
|
||||||
if !target.iter().any(|existing| existing == &value) {
|
|
||||||
target.push(value);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
@@ -1181,96 +1033,6 @@ mod tests {
|
|||||||
fs::remove_dir_all(root).expect("cleanup temp dir");
|
fs::remove_dir_all(root).expect("cleanup temp dir");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn parses_plugin_config_from_enabled_plugins() {
|
|
||||||
let root = temp_dir();
|
|
||||||
let cwd = root.join("project");
|
|
||||||
let home = root.join("home").join(".claude");
|
|
||||||
fs::create_dir_all(cwd.join(".claude")).expect("project config dir");
|
|
||||||
fs::create_dir_all(&home).expect("home config dir");
|
|
||||||
|
|
||||||
fs::write(
|
|
||||||
home.join("settings.json"),
|
|
||||||
r#"{
|
|
||||||
"enabledPlugins": {
|
|
||||||
"tool-guard@builtin": true,
|
|
||||||
"sample-plugin@external": false
|
|
||||||
}
|
|
||||||
}"#,
|
|
||||||
)
|
|
||||||
.expect("write user settings");
|
|
||||||
|
|
||||||
let loaded = ConfigLoader::new(&cwd, &home)
|
|
||||||
.load()
|
|
||||||
.expect("config should load");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
loaded.plugins().enabled_plugins().get("tool-guard@builtin"),
|
|
||||||
Some(&true)
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
loaded
|
|
||||||
.plugins()
|
|
||||||
.enabled_plugins()
|
|
||||||
.get("sample-plugin@external"),
|
|
||||||
Some(&false)
|
|
||||||
);
|
|
||||||
|
|
||||||
fs::remove_dir_all(root).expect("cleanup temp dir");
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn parses_plugin_config() {
|
|
||||||
let root = temp_dir();
|
|
||||||
let cwd = root.join("project");
|
|
||||||
let home = root.join("home").join(".claude");
|
|
||||||
fs::create_dir_all(cwd.join(".claude")).expect("project config dir");
|
|
||||||
fs::create_dir_all(&home).expect("home config dir");
|
|
||||||
|
|
||||||
fs::write(
|
|
||||||
home.join("settings.json"),
|
|
||||||
r#"{
|
|
||||||
"enabledPlugins": {
|
|
||||||
"core-helpers@builtin": true
|
|
||||||
},
|
|
||||||
"plugins": {
|
|
||||||
"externalDirectories": ["./external-plugins"],
|
|
||||||
"installRoot": "plugin-cache/installed",
|
|
||||||
"registryPath": "plugin-cache/installed.json",
|
|
||||||
"bundledRoot": "./bundled-plugins"
|
|
||||||
}
|
|
||||||
}"#,
|
|
||||||
)
|
|
||||||
.expect("write plugin settings");
|
|
||||||
|
|
||||||
let loaded = ConfigLoader::new(&cwd, &home)
|
|
||||||
.load()
|
|
||||||
.expect("config should load");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
loaded
|
|
||||||
.plugins()
|
|
||||||
.enabled_plugins()
|
|
||||||
.get("core-helpers@builtin"),
|
|
||||||
Some(&true)
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
loaded.plugins().external_directories(),
|
|
||||||
&["./external-plugins".to_string()]
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
loaded.plugins().install_root(),
|
|
||||||
Some("plugin-cache/installed")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
loaded.plugins().registry_path(),
|
|
||||||
Some("plugin-cache/installed.json")
|
|
||||||
);
|
|
||||||
assert_eq!(loaded.plugins().bundled_root(), Some("./bundled-plugins"));
|
|
||||||
|
|
||||||
fs::remove_dir_all(root).expect("cleanup temp dir");
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn rejects_invalid_mcp_server_shapes() {
|
fn rejects_invalid_mcp_server_shapes() {
|
||||||
let root = temp_dir();
|
let root = temp_dir();
|
||||||
|
|||||||
@@ -1,20 +1,15 @@
|
|||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
use std::fmt::{Display, Formatter};
|
use std::fmt::{Display, Formatter};
|
||||||
|
|
||||||
use plugins::{HookRunner as PluginHookRunner, PluginRegistry};
|
|
||||||
|
|
||||||
use crate::compact::{
|
use crate::compact::{
|
||||||
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
||||||
};
|
};
|
||||||
use crate::config::RuntimeFeatureConfig;
|
use crate::config::RuntimeFeatureConfig;
|
||||||
use crate::hooks::HookRunner;
|
use crate::hooks::{HookRunResult, HookRunner};
|
||||||
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
||||||
use crate::session::{ContentBlock, ConversationMessage, Session};
|
use crate::session::{ContentBlock, ConversationMessage, Session};
|
||||||
use crate::usage::{TokenUsage, UsageTracker};
|
use crate::usage::{TokenUsage, UsageTracker};
|
||||||
|
|
||||||
const DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD: u32 = 200_000;
|
|
||||||
const AUTO_COMPACTION_THRESHOLD_ENV_VAR: &str = "CLAUDE_CODE_AUTO_COMPACT_INPUT_TOKENS";
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
pub struct ApiRequest {
|
pub struct ApiRequest {
|
||||||
pub system_prompt: Vec<String>,
|
pub system_prompt: Vec<String>,
|
||||||
@@ -91,12 +86,6 @@ pub struct TurnSummary {
|
|||||||
pub tool_results: Vec<ConversationMessage>,
|
pub tool_results: Vec<ConversationMessage>,
|
||||||
pub iterations: usize,
|
pub iterations: usize,
|
||||||
pub usage: TokenUsage,
|
pub usage: TokenUsage,
|
||||||
pub auto_compaction: Option<AutoCompactionEvent>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
|
||||||
pub struct AutoCompactionEvent {
|
|
||||||
pub removed_message_count: usize,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct ConversationRuntime<C, T> {
|
pub struct ConversationRuntime<C, T> {
|
||||||
@@ -108,25 +97,6 @@ pub struct ConversationRuntime<C, T> {
|
|||||||
max_iterations: usize,
|
max_iterations: usize,
|
||||||
usage_tracker: UsageTracker,
|
usage_tracker: UsageTracker,
|
||||||
hook_runner: HookRunner,
|
hook_runner: HookRunner,
|
||||||
auto_compaction_input_tokens_threshold: u32,
|
|
||||||
plugin_hook_runner: Option<PluginHookRunner>,
|
|
||||||
plugin_registry: Option<PluginRegistry>,
|
|
||||||
plugins_shutdown: bool,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T> {
|
|
||||||
fn shutdown_registered_plugins(&mut self) -> Result<(), RuntimeError> {
|
|
||||||
if self.plugins_shutdown {
|
|
||||||
return Ok(());
|
|
||||||
}
|
|
||||||
if let Some(registry) = &self.plugin_registry {
|
|
||||||
registry
|
|
||||||
.shutdown()
|
|
||||||
.map_err(|error| RuntimeError::new(format!("plugin shutdown failed: {error}")))?;
|
|
||||||
}
|
|
||||||
self.plugins_shutdown = true;
|
|
||||||
Ok(())
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T>
|
impl<C, T> ConversationRuntime<C, T>
|
||||||
@@ -153,7 +123,6 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
#[allow(clippy::needless_pass_by_value)]
|
|
||||||
pub fn new_with_features(
|
pub fn new_with_features(
|
||||||
session: Session,
|
session: Session,
|
||||||
api_client: C,
|
api_client: C,
|
||||||
@@ -172,69 +141,27 @@ where
|
|||||||
max_iterations: usize::MAX,
|
max_iterations: usize::MAX,
|
||||||
usage_tracker,
|
usage_tracker,
|
||||||
hook_runner: HookRunner::from_feature_config(&feature_config),
|
hook_runner: HookRunner::from_feature_config(&feature_config),
|
||||||
auto_compaction_input_tokens_threshold: auto_compaction_threshold_from_env(),
|
|
||||||
plugin_hook_runner: None,
|
|
||||||
plugin_registry: None,
|
|
||||||
plugins_shutdown: false,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::needless_pass_by_value)]
|
|
||||||
pub fn new_with_plugins(
|
|
||||||
session: Session,
|
|
||||||
api_client: C,
|
|
||||||
tool_executor: T,
|
|
||||||
permission_policy: PermissionPolicy,
|
|
||||||
system_prompt: Vec<String>,
|
|
||||||
feature_config: RuntimeFeatureConfig,
|
|
||||||
plugin_registry: PluginRegistry,
|
|
||||||
) -> Result<Self, RuntimeError> {
|
|
||||||
let plugin_hook_runner =
|
|
||||||
PluginHookRunner::from_registry(&plugin_registry).map_err(|error| {
|
|
||||||
RuntimeError::new(format!("plugin hook registration failed: {error}"))
|
|
||||||
})?;
|
|
||||||
plugin_registry
|
|
||||||
.initialize()
|
|
||||||
.map_err(|error| RuntimeError::new(format!("plugin initialization failed: {error}")))?;
|
|
||||||
let mut runtime = Self::new_with_features(
|
|
||||||
session,
|
|
||||||
api_client,
|
|
||||||
tool_executor,
|
|
||||||
permission_policy,
|
|
||||||
system_prompt,
|
|
||||||
feature_config,
|
|
||||||
);
|
|
||||||
runtime.plugin_hook_runner = Some(plugin_hook_runner);
|
|
||||||
runtime.plugin_registry = Some(plugin_registry);
|
|
||||||
Ok(runtime)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn with_max_iterations(mut self, max_iterations: usize) -> Self {
|
pub fn with_max_iterations(mut self, max_iterations: usize) -> Self {
|
||||||
self.max_iterations = max_iterations;
|
self.max_iterations = max_iterations;
|
||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn with_auto_compaction_input_tokens_threshold(mut self, threshold: u32) -> Self {
|
|
||||||
self.auto_compaction_input_tokens_threshold = threshold;
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::too_many_lines)]
|
|
||||||
pub fn run_turn(
|
pub fn run_turn(
|
||||||
&mut self,
|
&mut self,
|
||||||
user_input: impl Into<String>,
|
user_input: impl Into<String>,
|
||||||
mut prompter: Option<&mut dyn PermissionPrompter>,
|
mut prompter: Option<&mut dyn PermissionPrompter>,
|
||||||
) -> Result<TurnSummary, RuntimeError> {
|
) -> Result<TurnSummary, RuntimeError> {
|
||||||
self.session
|
self.session
|
||||||
.messages
|
.push_user_text(user_input.into())
|
||||||
.push(ConversationMessage::user_text(user_input.into()));
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
|
|
||||||
let mut assistant_messages = Vec::new();
|
let mut assistant_messages = Vec::new();
|
||||||
let mut tool_results = Vec::new();
|
let mut tool_results = Vec::new();
|
||||||
let mut iterations = 0;
|
let mut iterations = 0;
|
||||||
let mut max_turn_input_tokens = 0;
|
|
||||||
|
|
||||||
loop {
|
loop {
|
||||||
iterations += 1;
|
iterations += 1;
|
||||||
@@ -251,7 +178,6 @@ where
|
|||||||
let events = self.api_client.stream(request)?;
|
let events = self.api_client.stream(request)?;
|
||||||
let (assistant_message, usage) = build_assistant_message(events)?;
|
let (assistant_message, usage) = build_assistant_message(events)?;
|
||||||
if let Some(usage) = usage {
|
if let Some(usage) = usage {
|
||||||
max_turn_input_tokens = max_turn_input_tokens.max(usage.input_tokens);
|
|
||||||
self.usage_tracker.record(usage);
|
self.usage_tracker.record(usage);
|
||||||
}
|
}
|
||||||
let pending_tool_uses = assistant_message
|
let pending_tool_uses = assistant_message
|
||||||
@@ -265,7 +191,9 @@ where
|
|||||||
})
|
})
|
||||||
.collect::<Vec<_>>();
|
.collect::<Vec<_>>();
|
||||||
|
|
||||||
self.session.messages.push(assistant_message.clone());
|
self.session
|
||||||
|
.push_message(assistant_message.clone())
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
assistant_messages.push(assistant_message);
|
assistant_messages.push(assistant_message);
|
||||||
|
|
||||||
if pending_tool_uses.is_empty() {
|
if pending_tool_uses.is_empty() {
|
||||||
@@ -288,21 +216,7 @@ where
|
|||||||
ConversationMessage::tool_result(
|
ConversationMessage::tool_result(
|
||||||
tool_use_id,
|
tool_use_id,
|
||||||
tool_name,
|
tool_name,
|
||||||
format_hook_message(pre_hook_result.messages(), &deny_message),
|
format_hook_message(&pre_hook_result, &deny_message),
|
||||||
true,
|
|
||||||
)
|
|
||||||
} else {
|
|
||||||
let plugin_pre_hook_result =
|
|
||||||
self.run_plugin_pre_tool_use(&tool_name, &input);
|
|
||||||
if plugin_pre_hook_result.is_denied() {
|
|
||||||
let deny_message =
|
|
||||||
format!("PreToolUse hook denied tool `{tool_name}`");
|
|
||||||
let mut messages = pre_hook_result.messages().to_vec();
|
|
||||||
messages.extend(plugin_pre_hook_result.messages().iter().cloned());
|
|
||||||
ConversationMessage::tool_result(
|
|
||||||
tool_use_id,
|
|
||||||
tool_name,
|
|
||||||
format_hook_message(&messages, &deny_message),
|
|
||||||
true,
|
true,
|
||||||
)
|
)
|
||||||
} else {
|
} else {
|
||||||
@@ -311,43 +225,19 @@ where
|
|||||||
Ok(output) => (output, false),
|
Ok(output) => (output, false),
|
||||||
Err(error) => (error.to_string(), true),
|
Err(error) => (error.to_string(), true),
|
||||||
};
|
};
|
||||||
output =
|
output = merge_hook_feedback(pre_hook_result.messages(), output, false);
|
||||||
merge_hook_feedback(pre_hook_result.messages(), output, false);
|
|
||||||
output = merge_hook_feedback(
|
|
||||||
plugin_pre_hook_result.messages(),
|
|
||||||
output,
|
|
||||||
false,
|
|
||||||
);
|
|
||||||
|
|
||||||
let hook_output = output.clone();
|
let post_hook_result = self
|
||||||
let post_hook_result = self.hook_runner.run_post_tool_use(
|
.hook_runner
|
||||||
&tool_name,
|
.run_post_tool_use(&tool_name, &input, &output, is_error);
|
||||||
&input,
|
|
||||||
&hook_output,
|
|
||||||
is_error,
|
|
||||||
);
|
|
||||||
let plugin_post_hook_result = self.run_plugin_post_tool_use(
|
|
||||||
&tool_name,
|
|
||||||
&input,
|
|
||||||
&hook_output,
|
|
||||||
is_error,
|
|
||||||
);
|
|
||||||
if post_hook_result.is_denied() {
|
if post_hook_result.is_denied() {
|
||||||
is_error = true;
|
is_error = true;
|
||||||
}
|
}
|
||||||
if plugin_post_hook_result.is_denied() {
|
|
||||||
is_error = true;
|
|
||||||
}
|
|
||||||
output = merge_hook_feedback(
|
output = merge_hook_feedback(
|
||||||
post_hook_result.messages(),
|
post_hook_result.messages(),
|
||||||
output,
|
output,
|
||||||
post_hook_result.is_denied(),
|
post_hook_result.is_denied(),
|
||||||
);
|
);
|
||||||
output = merge_hook_feedback(
|
|
||||||
plugin_post_hook_result.messages(),
|
|
||||||
output,
|
|
||||||
plugin_post_hook_result.is_denied(),
|
|
||||||
);
|
|
||||||
|
|
||||||
ConversationMessage::tool_result(
|
ConversationMessage::tool_result(
|
||||||
tool_use_id,
|
tool_use_id,
|
||||||
@@ -357,24 +247,22 @@ where
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
PermissionOutcome::Deny { reason } => {
|
PermissionOutcome::Deny { reason } => {
|
||||||
ConversationMessage::tool_result(tool_use_id, tool_name, reason, true)
|
ConversationMessage::tool_result(tool_use_id, tool_name, reason, true)
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
self.session.messages.push(result_message.clone());
|
self.session
|
||||||
|
.push_message(result_message.clone())
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
tool_results.push(result_message);
|
tool_results.push(result_message);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let auto_compaction = self.maybe_auto_compact(max_turn_input_tokens);
|
|
||||||
|
|
||||||
Ok(TurnSummary {
|
Ok(TurnSummary {
|
||||||
assistant_messages,
|
assistant_messages,
|
||||||
tool_results,
|
tool_results,
|
||||||
iterations,
|
iterations,
|
||||||
usage: self.usage_tracker.cumulative_usage(),
|
usage: self.usage_tracker.cumulative_usage(),
|
||||||
auto_compaction,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -399,81 +287,14 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn into_session(mut self) -> Session {
|
pub fn fork_session(&self, branch_name: Option<String>) -> Session {
|
||||||
let _ = self.shutdown_registered_plugins();
|
self.session.fork(branch_name)
|
||||||
std::mem::take(&mut self.session)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn shutdown_plugins(&mut self) -> Result<(), RuntimeError> {
|
#[must_use]
|
||||||
self.shutdown_registered_plugins()
|
pub fn into_session(self) -> Session {
|
||||||
|
self.session
|
||||||
}
|
}
|
||||||
|
|
||||||
fn run_plugin_pre_tool_use(&self, tool_name: &str, input: &str) -> plugins::HookRunResult {
|
|
||||||
self.plugin_hook_runner.as_ref().map_or_else(
|
|
||||||
|| plugins::HookRunResult::allow(Vec::new()),
|
|
||||||
|runner| runner.run_pre_tool_use(tool_name, input),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn run_plugin_post_tool_use(
|
|
||||||
&self,
|
|
||||||
tool_name: &str,
|
|
||||||
input: &str,
|
|
||||||
output: &str,
|
|
||||||
is_error: bool,
|
|
||||||
) -> plugins::HookRunResult {
|
|
||||||
self.plugin_hook_runner.as_ref().map_or_else(
|
|
||||||
|| plugins::HookRunResult::allow(Vec::new()),
|
|
||||||
|runner| runner.run_post_tool_use(tool_name, input, output, is_error),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn maybe_auto_compact(&mut self, turn_input_tokens: u32) -> Option<AutoCompactionEvent> {
|
|
||||||
if turn_input_tokens < self.auto_compaction_input_tokens_threshold {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
let result = compact_session(
|
|
||||||
&self.session,
|
|
||||||
CompactionConfig {
|
|
||||||
max_estimated_tokens: usize::try_from(self.auto_compaction_input_tokens_threshold)
|
|
||||||
.unwrap_or(usize::MAX),
|
|
||||||
..CompactionConfig::default()
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
if result.removed_message_count == 0 {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
self.session = result.compacted_session;
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: result.removed_message_count,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl<C, T> Drop for ConversationRuntime<C, T> {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
let _ = self.shutdown_registered_plugins();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn auto_compaction_threshold_from_env() -> u32 {
|
|
||||||
parse_auto_compaction_threshold(
|
|
||||||
std::env::var(AUTO_COMPACTION_THRESHOLD_ENV_VAR)
|
|
||||||
.ok()
|
|
||||||
.as_deref(),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
fn parse_auto_compaction_threshold(value: Option<&str>) -> u32 {
|
|
||||||
value
|
|
||||||
.and_then(|raw| raw.trim().parse::<u32>().ok())
|
|
||||||
.filter(|threshold| *threshold > 0)
|
|
||||||
.unwrap_or(DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn build_assistant_message(
|
fn build_assistant_message(
|
||||||
@@ -523,11 +344,11 @@ fn flush_text_block(text: &mut String, blocks: &mut Vec<ContentBlock>) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn format_hook_message(messages: &[String], fallback: &str) -> String {
|
fn format_hook_message(result: &HookRunResult, fallback: &str) -> String {
|
||||||
if messages.is_empty() {
|
if result.messages().is_empty() {
|
||||||
fallback.to_string()
|
fallback.to_string()
|
||||||
} else {
|
} else {
|
||||||
messages.join("\n")
|
result.messages().join("\n")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -584,9 +405,8 @@ impl ToolExecutor for StaticToolExecutor {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
parse_auto_compaction_threshold, ApiClient, ApiRequest, AssistantEvent,
|
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError,
|
||||||
AutoCompactionEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
StaticToolExecutor,
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD,
|
|
||||||
};
|
};
|
||||||
use crate::compact::CompactionConfig;
|
use crate::compact::CompactionConfig;
|
||||||
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
@@ -597,11 +417,7 @@ mod tests {
|
|||||||
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
||||||
use crate::session::{ContentBlock, MessageRole, Session};
|
use crate::session::{ContentBlock, MessageRole, Session};
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
use plugins::{PluginManager, PluginManagerConfig};
|
|
||||||
use std::fs;
|
use std::fs;
|
||||||
#[cfg(unix)]
|
|
||||||
use std::os::unix::fs::PermissionsExt;
|
|
||||||
use std::path::Path;
|
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
@@ -665,68 +481,6 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn temp_dir(label: &str) -> PathBuf {
|
|
||||||
let nanos = SystemTime::now()
|
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.expect("time should be after epoch")
|
|
||||||
.as_nanos();
|
|
||||||
std::env::temp_dir().join(format!("runtime-plugin-{label}-{nanos}"))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn write_lifecycle_plugin(root: &Path, name: &str) -> PathBuf {
|
|
||||||
fs::create_dir_all(root.join(".claude-plugin")).expect("manifest dir");
|
|
||||||
fs::create_dir_all(root.join("lifecycle")).expect("lifecycle dir");
|
|
||||||
let log_path = root.join("lifecycle.log");
|
|
||||||
fs::write(
|
|
||||||
root.join("lifecycle").join("init.sh"),
|
|
||||||
"#!/bin/sh\nprintf 'init\\n' >> lifecycle.log\n",
|
|
||||||
)
|
|
||||||
.expect("write init script");
|
|
||||||
fs::write(
|
|
||||||
root.join("lifecycle").join("shutdown.sh"),
|
|
||||||
"#!/bin/sh\nprintf 'shutdown\\n' >> lifecycle.log\n",
|
|
||||||
)
|
|
||||||
.expect("write shutdown script");
|
|
||||||
fs::write(
|
|
||||||
root.join(".claude-plugin").join("plugin.json"),
|
|
||||||
format!(
|
|
||||||
"{{\n \"name\": \"{name}\",\n \"version\": \"1.0.0\",\n \"description\": \"runtime lifecycle plugin\",\n \"lifecycle\": {{\n \"Init\": [\"./lifecycle/init.sh\"],\n \"Shutdown\": [\"./lifecycle/shutdown.sh\"]\n }}\n}}"
|
|
||||||
),
|
|
||||||
)
|
|
||||||
.expect("write plugin manifest");
|
|
||||||
log_path
|
|
||||||
}
|
|
||||||
|
|
||||||
fn write_hook_plugin(root: &Path, name: &str, pre_message: &str, post_message: &str) {
|
|
||||||
fs::create_dir_all(root.join(".claude-plugin")).expect("manifest dir");
|
|
||||||
fs::create_dir_all(root.join("hooks")).expect("hooks dir");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("pre.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{pre_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write pre hook");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("post.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{post_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write post hook");
|
|
||||||
#[cfg(unix)]
|
|
||||||
{
|
|
||||||
let exec_mode = fs::Permissions::from_mode(0o755);
|
|
||||||
fs::set_permissions(root.join("hooks").join("pre.sh"), exec_mode.clone())
|
|
||||||
.expect("chmod pre hook");
|
|
||||||
fs::set_permissions(root.join("hooks").join("post.sh"), exec_mode)
|
|
||||||
.expect("chmod post hook");
|
|
||||||
}
|
|
||||||
fs::write(
|
|
||||||
root.join(".claude-plugin").join("plugin.json"),
|
|
||||||
format!(
|
|
||||||
"{{\n \"name\": \"{name}\",\n \"version\": \"1.0.0\",\n \"description\": \"runtime hook plugin\",\n \"hooks\": {{\n \"PreToolUse\": [\"./hooks/pre.sh\"],\n \"PostToolUse\": [\"./hooks/post.sh\"]\n }}\n}}"
|
|
||||||
),
|
|
||||||
)
|
|
||||||
.expect("write plugin manifest");
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn runs_user_to_tool_to_result_loop_end_to_end_and_tracks_usage() {
|
fn runs_user_to_tool_to_result_loop_end_to_end_and_tracks_usage() {
|
||||||
let api_client = ScriptedApiClient { call_count: 0 };
|
let api_client = ScriptedApiClient { call_count: 0 };
|
||||||
@@ -765,7 +519,6 @@ mod tests {
|
|||||||
assert_eq!(summary.tool_results.len(), 1);
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
assert_eq!(runtime.session().messages.len(), 4);
|
assert_eq!(runtime.session().messages.len(), 4);
|
||||||
assert_eq!(summary.usage.output_tokens, 10);
|
assert_eq!(summary.usage.output_tokens, 10);
|
||||||
assert_eq!(summary.auto_compaction, None);
|
|
||||||
assert!(matches!(
|
assert!(matches!(
|
||||||
runtime.session().messages[1].blocks[1],
|
runtime.session().messages[1].blocks[1],
|
||||||
ContentBlock::ToolUse { .. }
|
ContentBlock::ToolUse { .. }
|
||||||
@@ -955,7 +708,7 @@ mod tests {
|
|||||||
"post hook should preserve non-error result: {output:?}"
|
"post hook should preserve non-error result: {output:?}"
|
||||||
);
|
);
|
||||||
assert!(
|
assert!(
|
||||||
output.contains('4'),
|
output.contains("4"),
|
||||||
"tool output missing value: {output:?}"
|
"tool output missing value: {output:?}"
|
||||||
);
|
);
|
||||||
assert!(
|
assert!(
|
||||||
@@ -968,153 +721,6 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn initializes_and_shuts_down_plugins_with_runtime_lifecycle() {
|
|
||||||
let config_home = temp_dir("config");
|
|
||||||
let source_root = temp_dir("source");
|
|
||||||
let _ = write_lifecycle_plugin(&source_root, "runtime-lifecycle");
|
|
||||||
|
|
||||||
let mut manager = PluginManager::new(PluginManagerConfig::new(&config_home));
|
|
||||||
let install = manager
|
|
||||||
.install(source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("install should succeed");
|
|
||||||
let log_path = install.install_path.join("lifecycle.log");
|
|
||||||
let registry = manager.plugin_registry().expect("registry should load");
|
|
||||||
|
|
||||||
{
|
|
||||||
let runtime = ConversationRuntime::new_with_plugins(
|
|
||||||
Session::new(),
|
|
||||||
ScriptedApiClient { call_count: 0 },
|
|
||||||
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
|
||||||
PermissionPolicy::new(PermissionMode::WorkspaceWrite),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
RuntimeFeatureConfig::default(),
|
|
||||||
registry,
|
|
||||||
)
|
|
||||||
.expect("runtime should initialize plugins");
|
|
||||||
|
|
||||||
let log = fs::read_to_string(&log_path).expect("init log should exist");
|
|
||||||
assert_eq!(log, "init\n");
|
|
||||||
drop(runtime);
|
|
||||||
}
|
|
||||||
|
|
||||||
let log = fs::read_to_string(&log_path).expect("shutdown log should exist");
|
|
||||||
assert_eq!(log, "init\nshutdown\n");
|
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(config_home);
|
|
||||||
let _ = fs::remove_dir_all(source_root);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn executes_hooks_from_installed_plugins_during_tool_use() {
|
|
||||||
struct TwoCallApiClient {
|
|
||||||
calls: usize,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl ApiClient for TwoCallApiClient {
|
|
||||||
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
self.calls += 1;
|
|
||||||
match self.calls {
|
|
||||||
1 => Ok(vec![
|
|
||||||
AssistantEvent::ToolUse {
|
|
||||||
id: "tool-1".to_string(),
|
|
||||||
name: "add".to_string(),
|
|
||||||
input: r#"{"lhs":2,"rhs":2}"#.to_string(),
|
|
||||||
},
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
]),
|
|
||||||
2 => {
|
|
||||||
assert!(request
|
|
||||||
.messages
|
|
||||||
.iter()
|
|
||||||
.any(|message| message.role == MessageRole::Tool));
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
_ => Err(RuntimeError::new("unexpected extra API call")),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let config_home = temp_dir("hook-config");
|
|
||||||
let first_source_root = temp_dir("hook-source-a");
|
|
||||||
let second_source_root = temp_dir("hook-source-b");
|
|
||||||
write_hook_plugin(
|
|
||||||
&first_source_root,
|
|
||||||
"first",
|
|
||||||
"plugin pre one",
|
|
||||||
"plugin post one",
|
|
||||||
);
|
|
||||||
write_hook_plugin(
|
|
||||||
&second_source_root,
|
|
||||||
"second",
|
|
||||||
"plugin pre two",
|
|
||||||
"plugin post two",
|
|
||||||
);
|
|
||||||
|
|
||||||
let mut manager = PluginManager::new(PluginManagerConfig::new(&config_home));
|
|
||||||
manager
|
|
||||||
.install(first_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("first plugin install should succeed");
|
|
||||||
manager
|
|
||||||
.install(second_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("second plugin install should succeed");
|
|
||||||
let registry = manager.plugin_registry().expect("registry should load");
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new_with_plugins(
|
|
||||||
Session::new(),
|
|
||||||
TwoCallApiClient { calls: 0 },
|
|
||||||
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
RuntimeFeatureConfig::default(),
|
|
||||||
registry,
|
|
||||||
)
|
|
||||||
.expect("runtime should load plugin hooks");
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("use add", None)
|
|
||||||
.expect("tool loop succeeds");
|
|
||||||
|
|
||||||
assert_eq!(summary.tool_results.len(), 1);
|
|
||||||
let ContentBlock::ToolResult {
|
|
||||||
is_error, output, ..
|
|
||||||
} = &summary.tool_results[0].blocks[0]
|
|
||||||
else {
|
|
||||||
panic!("expected tool result block");
|
|
||||||
};
|
|
||||||
assert!(
|
|
||||||
!*is_error,
|
|
||||||
"plugin hooks should not force an error: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains('4'),
|
|
||||||
"tool output missing value: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin pre one"),
|
|
||||||
"tool output missing first pre hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin pre two"),
|
|
||||||
"tool output missing second pre hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin post one"),
|
|
||||||
"tool output missing first post hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin post two"),
|
|
||||||
"tool output missing second post hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(config_home);
|
|
||||||
let _ = fs::remove_dir_all(first_source_root);
|
|
||||||
let _ = fs::remove_dir_all(second_source_root);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_tracker_from_restored_session() {
|
fn reconstructs_usage_tracker_from_restored_session() {
|
||||||
struct SimpleApi;
|
struct SimpleApi;
|
||||||
@@ -1192,6 +798,86 @@ mod tests {
|
|||||||
result.compacted_session.messages[0].role,
|
result.compacted_session.messages[0].role,
|
||||||
MessageRole::System
|
MessageRole::System
|
||||||
);
|
);
|
||||||
|
assert_eq!(
|
||||||
|
result.compacted_session.session_id,
|
||||||
|
runtime.session().session_id
|
||||||
|
);
|
||||||
|
assert!(result.compacted_session.compaction.is_some());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn persists_conversation_turn_messages_to_jsonl_session() {
|
||||||
|
struct SimpleApi;
|
||||||
|
impl ApiClient for SimpleApi {
|
||||||
|
fn stream(
|
||||||
|
&mut self,
|
||||||
|
_request: ApiRequest,
|
||||||
|
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("done".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let path = temp_session_path("persisted-turn");
|
||||||
|
let session = Session::new().with_persistence_path(path.clone());
|
||||||
|
let mut runtime = ConversationRuntime::new(
|
||||||
|
session,
|
||||||
|
SimpleApi,
|
||||||
|
StaticToolExecutor::new(),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
);
|
||||||
|
|
||||||
|
runtime
|
||||||
|
.run_turn("persist this turn", None)
|
||||||
|
.expect("turn should succeed");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("persisted session should reload");
|
||||||
|
fs::remove_file(&path).expect("temp session file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 2);
|
||||||
|
assert_eq!(restored.messages[0].role, MessageRole::User);
|
||||||
|
assert_eq!(restored.messages[1].role, MessageRole::Assistant);
|
||||||
|
assert_eq!(restored.session_id, runtime.session().session_id);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn forks_runtime_session_without_mutating_original() {
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("branch me")
|
||||||
|
.expect("message should append");
|
||||||
|
|
||||||
|
let runtime = ConversationRuntime::new(
|
||||||
|
session.clone(),
|
||||||
|
ScriptedApiClient { call_count: 0 },
|
||||||
|
StaticToolExecutor::new(),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
);
|
||||||
|
|
||||||
|
let forked = runtime.fork_session(Some("alt-path".to_string()));
|
||||||
|
|
||||||
|
assert_eq!(forked.messages, session.messages);
|
||||||
|
assert_ne!(forked.session_id, session.session_id);
|
||||||
|
assert_eq!(
|
||||||
|
forked
|
||||||
|
.fork
|
||||||
|
.as_ref()
|
||||||
|
.map(|fork| (fork.parent_session_id.as_str(), fork.branch_name.as_deref())),
|
||||||
|
Some((session.session_id.as_str(), Some("alt-path")))
|
||||||
|
);
|
||||||
|
assert!(runtime.session().fork.is_none());
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temp_session_path(label: &str) -> PathBuf {
|
||||||
|
let nanos = SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.expect("system time should be after epoch")
|
||||||
|
.as_nanos();
|
||||||
|
std::env::temp_dir().join(format!("runtime-conversation-{label}-{nanos}.json"))
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(windows)]
|
#[cfg(windows)]
|
||||||
@@ -1203,177 +889,4 @@ mod tests {
|
|||||||
fn shell_snippet(script: &str) -> String {
|
fn shell_snippet(script: &str) -> String {
|
||||||
script.to_string()
|
script.to_string()
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compacts_when_turn_input_threshold_is_crossed() {
|
|
||||||
struct SimpleApi;
|
|
||||||
impl ApiClient for SimpleApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens: 120_000,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
crate::session::ConversationMessage::user_text("one ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "two ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
crate::session::ConversationMessage::user_text("three ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "four ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
session,
|
|
||||||
SimpleApi,
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("turn should succeed");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
summary.auto_compaction,
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: 2,
|
|
||||||
})
|
|
||||||
);
|
|
||||||
assert_eq!(runtime.session().messages[0].role, MessageRole::System);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compaction_does_not_repeat_after_context_is_already_compacted() {
|
|
||||||
struct SequentialUsageApi {
|
|
||||||
call_count: usize,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl ApiClient for SequentialUsageApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
self.call_count += 1;
|
|
||||||
let input_tokens = if self.call_count == 1 { 120_000 } else { 64 };
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
crate::session::ConversationMessage::user_text("one ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "two ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
crate::session::ConversationMessage::user_text("three ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "four ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
session,
|
|
||||||
SequentialUsageApi { call_count: 0 },
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let first = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("first turn should succeed");
|
|
||||||
assert_eq!(
|
|
||||||
first.auto_compaction,
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: 2,
|
|
||||||
})
|
|
||||||
);
|
|
||||||
|
|
||||||
let second = runtime
|
|
||||||
.run_turn("continue", None)
|
|
||||||
.expect("second turn should succeed");
|
|
||||||
assert_eq!(second.auto_compaction, None);
|
|
||||||
assert_eq!(runtime.session().messages[0].role, MessageRole::System);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn skips_auto_compaction_below_threshold() {
|
|
||||||
struct SimpleApi;
|
|
||||||
impl ApiClient for SimpleApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens: 99_999,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
Session::new(),
|
|
||||||
SimpleApi,
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("turn should succeed");
|
|
||||||
assert_eq!(summary.auto_compaction, None);
|
|
||||||
assert_eq!(runtime.session().messages.len(), 2);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compaction_threshold_defaults_and_parses_values() {
|
|
||||||
assert_eq!(
|
|
||||||
parse_auto_compaction_threshold(None),
|
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD
|
|
||||||
);
|
|
||||||
assert_eq!(parse_auto_compaction_threshold(Some("4321")), 4321);
|
|
||||||
assert_eq!(
|
|
||||||
parse_auto_compaction_threshold(Some("not-a-number")),
|
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
use std::ffi::OsStr;
|
use std::ffi::OsStr;
|
||||||
use std::path::Path;
|
|
||||||
use std::process::Command;
|
use std::process::Command;
|
||||||
|
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
@@ -150,7 +149,6 @@ impl HookRunner {
|
|||||||
HookRunResult::allow(messages)
|
HookRunResult::allow(messages)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::too_many_arguments, clippy::unused_self)]
|
|
||||||
fn run_command(
|
fn run_command(
|
||||||
&self,
|
&self,
|
||||||
command: &str,
|
command: &str,
|
||||||
@@ -239,11 +237,7 @@ fn shell_command(command: &str) -> CommandWithStdin {
|
|||||||
};
|
};
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
#[cfg(not(windows))]
|
||||||
let command_builder = if Path::new(command).exists() {
|
let command_builder = {
|
||||||
let mut command_builder = Command::new("sh");
|
|
||||||
command_builder.arg(command);
|
|
||||||
CommandWithStdin::new(command_builder)
|
|
||||||
} else {
|
|
||||||
let mut command_builder = Command::new("sh");
|
let mut command_builder = Command::new("sh");
|
||||||
command_builder.arg("-lc").arg(command);
|
command_builder.arg("-lc").arg(command);
|
||||||
CommandWithStdin::new(command_builder)
|
CommandWithStdin::new(command_builder)
|
||||||
|
|||||||
@@ -28,11 +28,11 @@ pub use config::{
|
|||||||
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
||||||
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
||||||
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, RuntimeHookConfig,
|
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, RuntimeHookConfig,
|
||||||
RuntimePluginConfig, ScopedMcpServerConfig, CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
ScopedMcpServerConfig, CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
||||||
};
|
};
|
||||||
pub use conversation::{
|
pub use conversation::{
|
||||||
auto_compaction_threshold_from_env, ApiClient, ApiRequest, AssistantEvent, AutoCompactionEvent,
|
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
||||||
ConversationRuntime, RuntimeError, StaticToolExecutor, ToolError, ToolExecutor, TurnSummary,
|
ToolError, ToolExecutor, TurnSummary,
|
||||||
};
|
};
|
||||||
pub use file_ops::{
|
pub use file_ops::{
|
||||||
edit_file, glob_search, grep_search, read_file, write_file, EditFileOutput, GlobSearchOutput,
|
edit_file, glob_search, grep_search, read_file, write_file, EditFileOutput, GlobSearchOutput,
|
||||||
@@ -76,7 +76,10 @@ pub use remote::{
|
|||||||
RemoteSessionContext, UpstreamProxyBootstrap, UpstreamProxyState, DEFAULT_REMOTE_BASE_URL,
|
RemoteSessionContext, UpstreamProxyBootstrap, UpstreamProxyState, DEFAULT_REMOTE_BASE_URL,
|
||||||
DEFAULT_SESSION_TOKEN_PATH, DEFAULT_SYSTEM_CA_BUNDLE, NO_PROXY_HOSTS, UPSTREAM_PROXY_ENV_KEYS,
|
DEFAULT_SESSION_TOKEN_PATH, DEFAULT_SYSTEM_CA_BUNDLE, NO_PROXY_HOSTS, UPSTREAM_PROXY_ENV_KEYS,
|
||||||
};
|
};
|
||||||
pub use session::{ContentBlock, ConversationMessage, MessageRole, Session, SessionError};
|
pub use session::{
|
||||||
|
ContentBlock, ConversationMessage, MessageRole, Session, SessionCompaction, SessionError,
|
||||||
|
SessionFork,
|
||||||
|
};
|
||||||
pub use usage::{
|
pub use usage::{
|
||||||
format_usd, pricing_for_model, ModelPricing, TokenUsage, UsageCostEstimate, UsageTracker,
|
format_usd, pricing_for_model, ModelPricing, TokenUsage, UsageCostEstimate, UsageTracker,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -421,7 +421,7 @@ fn render_config_section(config: &RuntimeConfig) -> String {
|
|||||||
let mut lines = vec!["# Runtime config".to_string()];
|
let mut lines = vec!["# Runtime config".to_string()];
|
||||||
if config.loaded_entries().is_empty() {
|
if config.loaded_entries().is_empty() {
|
||||||
lines.extend(prepend_bullets(vec![
|
lines.extend(prepend_bullets(vec![
|
||||||
"No Claw Code settings files loaded.".to_string()
|
"No Claude Code settings files loaded.".to_string(),
|
||||||
]));
|
]));
|
||||||
return lines.join("\n");
|
return lines.join("\n");
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,11 +1,19 @@
|
|||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
use std::fmt::{Display, Formatter};
|
use std::fmt::{Display, Formatter};
|
||||||
use std::fs;
|
use std::fs::{self, OpenOptions};
|
||||||
use std::path::Path;
|
use std::io::Write;
|
||||||
|
use std::path::{Path, PathBuf};
|
||||||
|
use std::sync::atomic::{AtomicU64, Ordering};
|
||||||
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
use crate::json::{JsonError, JsonValue};
|
use crate::json::{JsonError, JsonValue};
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
|
|
||||||
|
const SESSION_VERSION: u32 = 1;
|
||||||
|
const ROTATE_AFTER_BYTES: u64 = 256 * 1024;
|
||||||
|
const MAX_ROTATED_FILES: usize = 3;
|
||||||
|
static SESSION_ID_COUNTER: AtomicU64 = AtomicU64::new(0);
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
pub enum MessageRole {
|
pub enum MessageRole {
|
||||||
System,
|
System,
|
||||||
@@ -40,11 +48,49 @@ pub struct ConversationMessage {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct SessionCompaction {
|
||||||
|
pub count: u32,
|
||||||
|
pub removed_message_count: usize,
|
||||||
|
pub summary: String,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct SessionFork {
|
||||||
|
pub parent_session_id: String,
|
||||||
|
pub branch_name: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct SessionPersistence {
|
||||||
|
path: PathBuf,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone)]
|
||||||
pub struct Session {
|
pub struct Session {
|
||||||
pub version: u32,
|
pub version: u32,
|
||||||
|
pub session_id: String,
|
||||||
|
pub created_at_ms: u64,
|
||||||
|
pub updated_at_ms: u64,
|
||||||
pub messages: Vec<ConversationMessage>,
|
pub messages: Vec<ConversationMessage>,
|
||||||
|
pub compaction: Option<SessionCompaction>,
|
||||||
|
pub fork: Option<SessionFork>,
|
||||||
|
persistence: Option<SessionPersistence>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl PartialEq for Session {
|
||||||
|
fn eq(&self, other: &Self) -> bool {
|
||||||
|
self.version == other.version
|
||||||
|
&& self.session_id == other.session_id
|
||||||
|
&& self.created_at_ms == other.created_at_ms
|
||||||
|
&& self.updated_at_ms == other.updated_at_ms
|
||||||
|
&& self.messages == other.messages
|
||||||
|
&& self.compaction == other.compaction
|
||||||
|
&& self.fork == other.fork
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Eq for Session {}
|
||||||
|
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub enum SessionError {
|
pub enum SessionError {
|
||||||
Io(std::io::Error),
|
Io(std::io::Error),
|
||||||
@@ -79,20 +125,84 @@ impl From<JsonError> for SessionError {
|
|||||||
impl Session {
|
impl Session {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn new() -> Self {
|
pub fn new() -> Self {
|
||||||
|
let now = current_time_millis();
|
||||||
Self {
|
Self {
|
||||||
version: 1,
|
version: SESSION_VERSION,
|
||||||
|
session_id: generate_session_id(),
|
||||||
|
created_at_ms: now,
|
||||||
|
updated_at_ms: now,
|
||||||
messages: Vec::new(),
|
messages: Vec::new(),
|
||||||
|
compaction: None,
|
||||||
|
fork: None,
|
||||||
|
persistence: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_persistence_path(mut self, path: impl Into<PathBuf>) -> Self {
|
||||||
|
self.persistence = Some(SessionPersistence { path: path.into() });
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn persistence_path(&self) -> Option<&Path> {
|
||||||
|
self.persistence.as_ref().map(|value| value.path.as_path())
|
||||||
|
}
|
||||||
|
|
||||||
pub fn save_to_path(&self, path: impl AsRef<Path>) -> Result<(), SessionError> {
|
pub fn save_to_path(&self, path: impl AsRef<Path>) -> Result<(), SessionError> {
|
||||||
fs::write(path, self.to_json().render())?;
|
let path = path.as_ref();
|
||||||
|
rotate_session_file_if_needed(path)?;
|
||||||
|
write_atomic(path, &self.render_jsonl_snapshot())?;
|
||||||
|
cleanup_rotated_logs(path)?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn load_from_path(path: impl AsRef<Path>) -> Result<Self, SessionError> {
|
pub fn load_from_path(path: impl AsRef<Path>) -> Result<Self, SessionError> {
|
||||||
|
let path = path.as_ref();
|
||||||
let contents = fs::read_to_string(path)?;
|
let contents = fs::read_to_string(path)?;
|
||||||
Self::from_json(&JsonValue::parse(&contents)?)
|
let session = match JsonValue::parse(&contents) {
|
||||||
|
Ok(value) => Self::from_json(&value)?,
|
||||||
|
Err(_) => Self::from_jsonl(&contents)?,
|
||||||
|
};
|
||||||
|
Ok(session.with_persistence_path(path.to_path_buf()))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn push_message(&mut self, message: ConversationMessage) -> Result<(), SessionError> {
|
||||||
|
self.touch();
|
||||||
|
self.messages.push(message.clone());
|
||||||
|
self.append_persisted_message(&message)
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn push_user_text(&mut self, text: impl Into<String>) -> Result<(), SessionError> {
|
||||||
|
self.push_message(ConversationMessage::user_text(text))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn record_compaction(&mut self, summary: impl Into<String>, removed_message_count: usize) {
|
||||||
|
self.touch();
|
||||||
|
let count = self.compaction.as_ref().map_or(1, |value| value.count + 1);
|
||||||
|
self.compaction = Some(SessionCompaction {
|
||||||
|
count,
|
||||||
|
removed_message_count,
|
||||||
|
summary: summary.into(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn fork(&self, branch_name: Option<String>) -> Self {
|
||||||
|
let now = current_time_millis();
|
||||||
|
Self {
|
||||||
|
version: self.version,
|
||||||
|
session_id: generate_session_id(),
|
||||||
|
created_at_ms: now,
|
||||||
|
updated_at_ms: now,
|
||||||
|
messages: self.messages.clone(),
|
||||||
|
compaction: self.compaction.clone(),
|
||||||
|
fork: Some(SessionFork {
|
||||||
|
parent_session_id: self.session_id.clone(),
|
||||||
|
branch_name: normalize_optional_string(branch_name),
|
||||||
|
}),
|
||||||
|
persistence: None,
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
@@ -102,6 +212,18 @@ impl Session {
|
|||||||
"version".to_string(),
|
"version".to_string(),
|
||||||
JsonValue::Number(i64::from(self.version)),
|
JsonValue::Number(i64::from(self.version)),
|
||||||
);
|
);
|
||||||
|
object.insert(
|
||||||
|
"session_id".to_string(),
|
||||||
|
JsonValue::String(self.session_id.clone()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"created_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.created_at_ms, "created_at_ms")),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"updated_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.updated_at_ms, "updated_at_ms")),
|
||||||
|
);
|
||||||
object.insert(
|
object.insert(
|
||||||
"messages".to_string(),
|
"messages".to_string(),
|
||||||
JsonValue::Array(
|
JsonValue::Array(
|
||||||
@@ -111,6 +233,12 @@ impl Session {
|
|||||||
.collect(),
|
.collect(),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
if let Some(compaction) = &self.compaction {
|
||||||
|
object.insert("compaction".to_string(), compaction.to_json());
|
||||||
|
}
|
||||||
|
if let Some(fork) = &self.fork {
|
||||||
|
object.insert("fork".to_string(), fork.to_json());
|
||||||
|
}
|
||||||
JsonValue::Object(object)
|
JsonValue::Object(object)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -131,7 +259,179 @@ impl Session {
|
|||||||
.iter()
|
.iter()
|
||||||
.map(ConversationMessage::from_json)
|
.map(ConversationMessage::from_json)
|
||||||
.collect::<Result<Vec<_>, _>>()?;
|
.collect::<Result<Vec<_>, _>>()?;
|
||||||
Ok(Self { version, messages })
|
let now = current_time_millis();
|
||||||
|
let session_id = object
|
||||||
|
.get("session_id")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.map(ToOwned::to_owned)
|
||||||
|
.unwrap_or_else(generate_session_id);
|
||||||
|
let created_at_ms = object
|
||||||
|
.get("created_at_ms")
|
||||||
|
.map(|value| required_u64_from_value(value, "created_at_ms"))
|
||||||
|
.transpose()?
|
||||||
|
.unwrap_or(now);
|
||||||
|
let updated_at_ms = object
|
||||||
|
.get("updated_at_ms")
|
||||||
|
.map(|value| required_u64_from_value(value, "updated_at_ms"))
|
||||||
|
.transpose()?
|
||||||
|
.unwrap_or(created_at_ms);
|
||||||
|
let compaction = object
|
||||||
|
.get("compaction")
|
||||||
|
.map(SessionCompaction::from_json)
|
||||||
|
.transpose()?;
|
||||||
|
let fork = object.get("fork").map(SessionFork::from_json).transpose()?;
|
||||||
|
Ok(Self {
|
||||||
|
version,
|
||||||
|
session_id,
|
||||||
|
created_at_ms,
|
||||||
|
updated_at_ms,
|
||||||
|
messages,
|
||||||
|
compaction,
|
||||||
|
fork,
|
||||||
|
persistence: None,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_jsonl(contents: &str) -> Result<Self, SessionError> {
|
||||||
|
let mut version = SESSION_VERSION;
|
||||||
|
let mut session_id = None;
|
||||||
|
let mut created_at_ms = None;
|
||||||
|
let mut updated_at_ms = None;
|
||||||
|
let mut messages = Vec::new();
|
||||||
|
let mut compaction = None;
|
||||||
|
let mut fork = None;
|
||||||
|
|
||||||
|
for (line_number, raw_line) in contents.lines().enumerate() {
|
||||||
|
let line = raw_line.trim();
|
||||||
|
if line.is_empty() {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
let value = JsonValue::parse(line).map_err(|error| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"invalid JSONL record at line {}: {}",
|
||||||
|
line_number + 1,
|
||||||
|
error
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
let object = value.as_object().ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} must be an object",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
match object
|
||||||
|
.get("type")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} missing type",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})? {
|
||||||
|
"session_meta" => {
|
||||||
|
version = required_u32(object, "version")?;
|
||||||
|
session_id = Some(required_string(object, "session_id")?);
|
||||||
|
created_at_ms = Some(required_u64(object, "created_at_ms")?);
|
||||||
|
updated_at_ms = Some(required_u64(object, "updated_at_ms")?);
|
||||||
|
fork = object.get("fork").map(SessionFork::from_json).transpose()?;
|
||||||
|
}
|
||||||
|
"message" => {
|
||||||
|
let message_value = object.get("message").ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} missing message",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
messages.push(ConversationMessage::from_json(message_value)?);
|
||||||
|
}
|
||||||
|
"compaction" => {
|
||||||
|
compaction = Some(SessionCompaction::from_json(&JsonValue::Object(
|
||||||
|
object.clone(),
|
||||||
|
))?);
|
||||||
|
}
|
||||||
|
other => {
|
||||||
|
return Err(SessionError::Format(format!(
|
||||||
|
"unsupported JSONL record type at line {}: {other}",
|
||||||
|
line_number + 1
|
||||||
|
)))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let now = current_time_millis();
|
||||||
|
Ok(Self {
|
||||||
|
version,
|
||||||
|
session_id: session_id.unwrap_or_else(generate_session_id),
|
||||||
|
created_at_ms: created_at_ms.unwrap_or(now),
|
||||||
|
updated_at_ms: updated_at_ms.unwrap_or(created_at_ms.unwrap_or(now)),
|
||||||
|
messages,
|
||||||
|
compaction,
|
||||||
|
fork,
|
||||||
|
persistence: None,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_jsonl_snapshot(&self) -> String {
|
||||||
|
let mut lines = vec![self.meta_record().render()];
|
||||||
|
if let Some(compaction) = &self.compaction {
|
||||||
|
lines.push(compaction.to_jsonl_record().render());
|
||||||
|
}
|
||||||
|
lines.extend(
|
||||||
|
self.messages
|
||||||
|
.iter()
|
||||||
|
.map(|message| message_record(message).render()),
|
||||||
|
);
|
||||||
|
let mut rendered = lines.join("\n");
|
||||||
|
rendered.push('\n');
|
||||||
|
rendered
|
||||||
|
}
|
||||||
|
|
||||||
|
fn append_persisted_message(&self, message: &ConversationMessage) -> Result<(), SessionError> {
|
||||||
|
let Some(path) = self.persistence_path() else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
|
||||||
|
let needs_bootstrap = !path.exists() || fs::metadata(path)?.len() == 0;
|
||||||
|
if needs_bootstrap {
|
||||||
|
self.save_to_path(path)?;
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut file = OpenOptions::new().append(true).open(path)?;
|
||||||
|
writeln!(file, "{}", message_record(message).render())?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn meta_record(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"type".to_string(),
|
||||||
|
JsonValue::String("session_meta".to_string()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"version".to_string(),
|
||||||
|
JsonValue::Number(i64::from(self.version)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"session_id".to_string(),
|
||||||
|
JsonValue::String(self.session_id.clone()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"created_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.created_at_ms, "created_at_ms")),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"updated_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.updated_at_ms, "updated_at_ms")),
|
||||||
|
);
|
||||||
|
if let Some(fork) = &self.fork {
|
||||||
|
object.insert("fork".to_string(), fork.to_json());
|
||||||
|
}
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn touch(&mut self) {
|
||||||
|
self.updated_at_ms = current_time_millis();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -324,6 +624,92 @@ impl ContentBlock {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl SessionCompaction {
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_json(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"count".to_string(),
|
||||||
|
JsonValue::Number(i64::from(self.count)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"removed_message_count".to_string(),
|
||||||
|
JsonValue::Number(i64_from_usize(
|
||||||
|
self.removed_message_count,
|
||||||
|
"removed_message_count",
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"summary".to_string(),
|
||||||
|
JsonValue::String(self.summary.clone()),
|
||||||
|
);
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_jsonl_record(&self) -> JsonValue {
|
||||||
|
let mut object = self
|
||||||
|
.to_json()
|
||||||
|
.as_object()
|
||||||
|
.cloned()
|
||||||
|
.expect("compaction should render to object");
|
||||||
|
object.insert(
|
||||||
|
"type".to_string(),
|
||||||
|
JsonValue::String("compaction".to_string()),
|
||||||
|
);
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_json(value: &JsonValue) -> Result<Self, SessionError> {
|
||||||
|
let object = value
|
||||||
|
.as_object()
|
||||||
|
.ok_or_else(|| SessionError::Format("compaction must be an object".to_string()))?;
|
||||||
|
Ok(Self {
|
||||||
|
count: required_u32(object, "count")?,
|
||||||
|
removed_message_count: required_usize(object, "removed_message_count")?,
|
||||||
|
summary: required_string(object, "summary")?,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl SessionFork {
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_json(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"parent_session_id".to_string(),
|
||||||
|
JsonValue::String(self.parent_session_id.clone()),
|
||||||
|
);
|
||||||
|
if let Some(branch_name) = &self.branch_name {
|
||||||
|
object.insert(
|
||||||
|
"branch_name".to_string(),
|
||||||
|
JsonValue::String(branch_name.clone()),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_json(value: &JsonValue) -> Result<Self, SessionError> {
|
||||||
|
let object = value
|
||||||
|
.as_object()
|
||||||
|
.ok_or_else(|| SessionError::Format("fork metadata must be an object".to_string()))?;
|
||||||
|
Ok(Self {
|
||||||
|
parent_session_id: required_string(object, "parent_session_id")?,
|
||||||
|
branch_name: object
|
||||||
|
.get("branch_name")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.map(ToOwned::to_owned),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn message_record(message: &ConversationMessage) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert("type".to_string(), JsonValue::String("message".to_string()));
|
||||||
|
object.insert("message".to_string(), message.to_json());
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
fn usage_to_json(usage: TokenUsage) -> JsonValue {
|
fn usage_to_json(usage: TokenUsage) -> JsonValue {
|
||||||
let mut object = BTreeMap::new();
|
let mut object = BTreeMap::new();
|
||||||
object.insert(
|
object.insert(
|
||||||
@@ -376,22 +762,155 @@ fn required_u32(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<u32,
|
|||||||
u32::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
u32::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn required_u64(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<u64, SessionError> {
|
||||||
|
let value = object
|
||||||
|
.get(key)
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
required_u64_from_value(value, key)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn required_u64_from_value(value: &JsonValue, key: &str) -> Result<u64, SessionError> {
|
||||||
|
let value = value
|
||||||
|
.as_i64()
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
u64::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn required_usize(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<usize, SessionError> {
|
||||||
|
let value = object
|
||||||
|
.get(key)
|
||||||
|
.and_then(JsonValue::as_i64)
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
usize::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn i64_from_u64(value: u64, key: &str) -> i64 {
|
||||||
|
i64::try_from(value).unwrap_or_else(|_| panic!("{key} out of range for JSON number"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn i64_from_usize(value: usize, key: &str) -> i64 {
|
||||||
|
i64::try_from(value).unwrap_or_else(|_| panic!("{key} out of range for JSON number"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn normalize_optional_string(value: Option<String>) -> Option<String> {
|
||||||
|
value.and_then(|value| {
|
||||||
|
let trimmed = value.trim();
|
||||||
|
if trimmed.is_empty() {
|
||||||
|
None
|
||||||
|
} else {
|
||||||
|
Some(trimmed.to_string())
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn current_time_millis() -> u64 {
|
||||||
|
SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.map(|duration| duration.as_millis() as u64)
|
||||||
|
.unwrap_or_default()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn generate_session_id() -> String {
|
||||||
|
let millis = current_time_millis();
|
||||||
|
let counter = SESSION_ID_COUNTER.fetch_add(1, Ordering::Relaxed);
|
||||||
|
format!("session-{millis}-{counter}")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn write_atomic(path: &Path, contents: &str) -> Result<(), SessionError> {
|
||||||
|
if let Some(parent) = path.parent() {
|
||||||
|
fs::create_dir_all(parent)?;
|
||||||
|
}
|
||||||
|
let temp_path = temporary_path_for(path);
|
||||||
|
fs::write(&temp_path, contents)?;
|
||||||
|
fs::rename(temp_path, path)?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temporary_path_for(path: &Path) -> PathBuf {
|
||||||
|
let file_name = path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
path.with_file_name(format!(
|
||||||
|
"{file_name}.tmp-{}-{}",
|
||||||
|
current_time_millis(),
|
||||||
|
SESSION_ID_COUNTER.fetch_add(1, Ordering::Relaxed)
|
||||||
|
))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotate_session_file_if_needed(path: &Path) -> Result<(), SessionError> {
|
||||||
|
let Ok(metadata) = fs::metadata(path) else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
if metadata.len() < ROTATE_AFTER_BYTES {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
let rotated_path = rotated_log_path(path);
|
||||||
|
fs::rename(path, rotated_path)?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotated_log_path(path: &Path) -> PathBuf {
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
path.with_file_name(format!("{stem}.rot-{}.jsonl", current_time_millis()))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn cleanup_rotated_logs(path: &Path) -> Result<(), SessionError> {
|
||||||
|
let Some(parent) = path.parent() else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
let prefix = format!("{stem}.rot-");
|
||||||
|
let mut rotated_paths = fs::read_dir(parent)?
|
||||||
|
.filter_map(Result::ok)
|
||||||
|
.map(|entry| entry.path())
|
||||||
|
.filter(|entry_path| {
|
||||||
|
entry_path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.is_some_and(|name| name.starts_with(&prefix) && name.ends_with(".jsonl"))
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
|
|
||||||
|
rotated_paths.sort_by_key(|entry_path| {
|
||||||
|
fs::metadata(entry_path)
|
||||||
|
.and_then(|metadata| metadata.modified())
|
||||||
|
.unwrap_or(UNIX_EPOCH)
|
||||||
|
});
|
||||||
|
|
||||||
|
let remove_count = rotated_paths.len().saturating_sub(MAX_ROTATED_FILES);
|
||||||
|
for stale_path in rotated_paths.into_iter().take(remove_count) {
|
||||||
|
fs::remove_file(stale_path)?;
|
||||||
|
}
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{ContentBlock, ConversationMessage, MessageRole, Session};
|
use super::{
|
||||||
|
cleanup_rotated_logs, rotate_session_file_if_needed, ContentBlock, ConversationMessage,
|
||||||
|
MessageRole, Session, SessionFork,
|
||||||
|
};
|
||||||
|
use crate::json::JsonValue;
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
use std::fs;
|
use std::fs;
|
||||||
|
use std::path::PathBuf;
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn persists_and_restores_session_json() {
|
fn persists_and_restores_session_jsonl() {
|
||||||
let mut session = Session::new();
|
let mut session = Session::new();
|
||||||
session
|
session
|
||||||
.messages
|
.push_user_text("hello")
|
||||||
.push(ConversationMessage::user_text("hello"));
|
.expect("user message should append");
|
||||||
session
|
session
|
||||||
.messages
|
.push_message(ConversationMessage::assistant_with_usage(
|
||||||
.push(ConversationMessage::assistant_with_usage(
|
|
||||||
vec![
|
vec![
|
||||||
ContentBlock::Text {
|
ContentBlock::Text {
|
||||||
text: "thinking".to_string(),
|
text: "thinking".to_string(),
|
||||||
@@ -408,16 +927,15 @@ mod tests {
|
|||||||
cache_creation_input_tokens: 1,
|
cache_creation_input_tokens: 1,
|
||||||
cache_read_input_tokens: 2,
|
cache_read_input_tokens: 2,
|
||||||
}),
|
}),
|
||||||
));
|
))
|
||||||
session.messages.push(ConversationMessage::tool_result(
|
.expect("assistant message should append");
|
||||||
|
session
|
||||||
|
.push_message(ConversationMessage::tool_result(
|
||||||
"tool-1", "bash", "hi", false,
|
"tool-1", "bash", "hi", false,
|
||||||
));
|
))
|
||||||
|
.expect("tool result should append");
|
||||||
|
|
||||||
let nanos = SystemTime::now()
|
let path = temp_session_path("jsonl");
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.expect("system time should be after epoch")
|
|
||||||
.as_nanos();
|
|
||||||
let path = std::env::temp_dir().join(format!("runtime-session-{nanos}.json"));
|
|
||||||
session.save_to_path(&path).expect("session should save");
|
session.save_to_path(&path).expect("session should save");
|
||||||
let restored = Session::load_from_path(&path).expect("session should load");
|
let restored = Session::load_from_path(&path).expect("session should load");
|
||||||
fs::remove_file(&path).expect("temp file should be removable");
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
@@ -428,5 +946,157 @@ mod tests {
|
|||||||
restored.messages[1].usage.expect("usage").total_tokens(),
|
restored.messages[1].usage.expect("usage").total_tokens(),
|
||||||
17
|
17
|
||||||
);
|
);
|
||||||
|
assert_eq!(restored.session_id, session.session_id);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn loads_legacy_session_json_object() {
|
||||||
|
let path = temp_session_path("legacy");
|
||||||
|
let legacy = JsonValue::Object(
|
||||||
|
[
|
||||||
|
("version".to_string(), JsonValue::Number(1)),
|
||||||
|
(
|
||||||
|
"messages".to_string(),
|
||||||
|
JsonValue::Array(vec![ConversationMessage::user_text("legacy").to_json()]),
|
||||||
|
),
|
||||||
|
]
|
||||||
|
.into_iter()
|
||||||
|
.collect(),
|
||||||
|
);
|
||||||
|
fs::write(&path, legacy.render()).expect("legacy file should write");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("legacy session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 1);
|
||||||
|
assert_eq!(
|
||||||
|
restored.messages[0],
|
||||||
|
ConversationMessage::user_text("legacy")
|
||||||
|
);
|
||||||
|
assert!(!restored.session_id.is_empty());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn appends_messages_to_persisted_jsonl_session() {
|
||||||
|
let path = temp_session_path("append");
|
||||||
|
let mut session = Session::new().with_persistence_path(path.clone());
|
||||||
|
session
|
||||||
|
.save_to_path(&path)
|
||||||
|
.expect("initial save should succeed");
|
||||||
|
session
|
||||||
|
.push_user_text("hi")
|
||||||
|
.expect("user append should succeed");
|
||||||
|
session
|
||||||
|
.push_message(ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
|
text: "hello".to_string(),
|
||||||
|
}]))
|
||||||
|
.expect("assistant append should succeed");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("session should replay from jsonl");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 2);
|
||||||
|
assert_eq!(restored.messages[0], ConversationMessage::user_text("hi"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn persists_compaction_metadata() {
|
||||||
|
let path = temp_session_path("compaction");
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("before")
|
||||||
|
.expect("message should append");
|
||||||
|
session.record_compaction("summarized earlier work", 4);
|
||||||
|
session.save_to_path(&path).expect("session should save");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
let compaction = restored.compaction.expect("compaction metadata");
|
||||||
|
assert_eq!(compaction.count, 1);
|
||||||
|
assert_eq!(compaction.removed_message_count, 4);
|
||||||
|
assert!(compaction.summary.contains("summarized"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn forks_sessions_with_branch_metadata_and_persists_it() {
|
||||||
|
let path = temp_session_path("fork");
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("before fork")
|
||||||
|
.expect("message should append");
|
||||||
|
|
||||||
|
let forked = session
|
||||||
|
.fork(Some("investigation".to_string()))
|
||||||
|
.with_persistence_path(path.clone());
|
||||||
|
forked
|
||||||
|
.save_to_path(&path)
|
||||||
|
.expect("forked session should save");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("forked session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_ne!(restored.session_id, session.session_id);
|
||||||
|
assert_eq!(
|
||||||
|
restored.fork,
|
||||||
|
Some(SessionFork {
|
||||||
|
parent_session_id: session.session_id,
|
||||||
|
branch_name: Some("investigation".to_string()),
|
||||||
|
})
|
||||||
|
);
|
||||||
|
assert_eq!(restored.messages, forked.messages);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn rotates_and_cleans_up_large_session_logs() {
|
||||||
|
let path = temp_session_path("rotation");
|
||||||
|
fs::write(&path, "x".repeat((super::ROTATE_AFTER_BYTES + 10) as usize))
|
||||||
|
.expect("oversized file should write");
|
||||||
|
rotate_session_file_if_needed(&path).expect("rotation should succeed");
|
||||||
|
assert!(
|
||||||
|
!path.exists(),
|
||||||
|
"original path should be rotated away before rewrite"
|
||||||
|
);
|
||||||
|
|
||||||
|
for _ in 0..5 {
|
||||||
|
let rotated = super::rotated_log_path(&path);
|
||||||
|
fs::write(&rotated, "old").expect("rotated file should write");
|
||||||
|
}
|
||||||
|
cleanup_rotated_logs(&path).expect("cleanup should succeed");
|
||||||
|
|
||||||
|
let rotated_count = rotation_files(&path).len();
|
||||||
|
assert!(rotated_count <= super::MAX_ROTATED_FILES);
|
||||||
|
for rotated in rotation_files(&path) {
|
||||||
|
fs::remove_file(rotated).expect("rotated file should be removable");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temp_session_path(label: &str) -> PathBuf {
|
||||||
|
let nanos = SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.expect("system time should be after epoch")
|
||||||
|
.as_nanos();
|
||||||
|
std::env::temp_dir().join(format!("runtime-session-{label}-{nanos}.json"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotation_files(path: &PathBuf) -> Vec<PathBuf> {
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.expect("temp path should have file stem")
|
||||||
|
.to_string();
|
||||||
|
fs::read_dir(path.parent().expect("temp path should have parent"))
|
||||||
|
.expect("temp dir should read")
|
||||||
|
.filter_map(Result::ok)
|
||||||
|
.map(|entry| entry.path())
|
||||||
|
.filter(|entry_path| {
|
||||||
|
entry_path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.is_some_and(|name| {
|
||||||
|
name.starts_with(&format!("{stem}.rot-")) && name.ends_with(".jsonl")
|
||||||
|
})
|
||||||
|
})
|
||||||
|
.collect()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -286,9 +286,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_from_session_messages() {
|
fn reconstructs_usage_from_session_messages() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![ConversationMessage {
|
||||||
messages: vec![ConversationMessage {
|
|
||||||
role: MessageRole::Assistant,
|
role: MessageRole::Assistant,
|
||||||
blocks: vec![ContentBlock::Text {
|
blocks: vec![ContentBlock::Text {
|
||||||
text: "done".to_string(),
|
text: "done".to_string(),
|
||||||
@@ -299,8 +298,7 @@ mod tests {
|
|||||||
cache_creation_input_tokens: 1,
|
cache_creation_input_tokens: 1,
|
||||||
cache_read_input_tokens: 0,
|
cache_read_input_tokens: 0,
|
||||||
}),
|
}),
|
||||||
}],
|
}];
|
||||||
};
|
|
||||||
|
|
||||||
let tracker = UsageTracker::from_session(&session);
|
let tracker = UsageTracker::from_session(&session);
|
||||||
assert_eq!(tracker.turns(), 1);
|
assert_eq!(tracker.turns(), 1);
|
||||||
|
|||||||
@@ -17,7 +17,6 @@ crossterm = "0.28"
|
|||||||
pulldown-cmark = "0.13"
|
pulldown-cmark = "0.13"
|
||||||
rustyline = "15"
|
rustyline = "15"
|
||||||
runtime = { path = "../runtime" }
|
runtime = { path = "../runtime" }
|
||||||
plugins = { path = "../plugins" }
|
|
||||||
serde_json = "1"
|
serde_json = "1"
|
||||||
syntect = "5"
|
syntect = "5"
|
||||||
tokio = { version = "1", features = ["rt-multi-thread", "time"] }
|
tokio = { version = "1", features = ["rt-multi-thread", "time"] }
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ const STARTER_CLAUDE_JSON: &str = concat!(
|
|||||||
" }\n",
|
" }\n",
|
||||||
"}\n",
|
"}\n",
|
||||||
);
|
);
|
||||||
const GITIGNORE_COMMENT: &str = "# Claw Code local artifacts";
|
const GITIGNORE_COMMENT: &str = "# Claude Code local artifacts";
|
||||||
const GITIGNORE_ENTRIES: [&str; 2] = [".claude/settings.local.json", ".claude/sessions/"];
|
const GITIGNORE_ENTRIES: [&str; 2] = [".claude/settings.local.json", ".claude/sessions/"];
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
@@ -164,7 +164,7 @@ pub(crate) fn render_init_claude_md(cwd: &Path) -> String {
|
|||||||
let mut lines = vec![
|
let mut lines = vec![
|
||||||
"# CLAUDE.md".to_string(),
|
"# CLAUDE.md".to_string(),
|
||||||
String::new(),
|
String::new(),
|
||||||
"This file provides guidance to Claw Code (clawcode.dev) when working with code in this repository.".to_string(),
|
"This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.".to_string(),
|
||||||
String::new(),
|
String::new(),
|
||||||
];
|
];
|
||||||
|
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -286,7 +286,7 @@ impl TerminalRenderer {
|
|||||||
) {
|
) {
|
||||||
match event {
|
match event {
|
||||||
Event::Start(Tag::Heading { level, .. }) => {
|
Event::Start(Tag::Heading { level, .. }) => {
|
||||||
self.start_heading(state, level as u8, output);
|
self.start_heading(state, level as u8, output)
|
||||||
}
|
}
|
||||||
Event::End(TagEnd::Paragraph) => output.push_str("\n\n"),
|
Event::End(TagEnd::Paragraph) => output.push_str("\n\n"),
|
||||||
Event::Start(Tag::BlockQuote(..)) => self.start_quote(state, output),
|
Event::Start(Tag::BlockQuote(..)) => self.start_quote(state, output),
|
||||||
@@ -426,7 +426,6 @@ impl TerminalRenderer {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::unused_self)]
|
|
||||||
fn start_heading(&self, state: &mut RenderState, level: u8, output: &mut String) {
|
fn start_heading(&self, state: &mut RenderState, level: u8, output: &mut String) {
|
||||||
state.heading_level = Some(level);
|
state.heading_level = Some(level);
|
||||||
if !output.is_empty() {
|
if !output.is_empty() {
|
||||||
|
|||||||
@@ -7,7 +7,6 @@ publish.workspace = true
|
|||||||
|
|
||||||
[dependencies]
|
[dependencies]
|
||||||
api = { path = "../api" }
|
api = { path = "../api" }
|
||||||
plugins = { path = "../plugins" }
|
|
||||||
runtime = { path = "../runtime" }
|
runtime = { path = "../runtime" }
|
||||||
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
|
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
|
||||||
serde = { version = "1", features = ["derive"] }
|
serde = { version = "1", features = ["derive"] }
|
||||||
|
|||||||
@@ -8,13 +8,12 @@ use api::{
|
|||||||
MessageRequest, MessageResponse, OutputContentBlock, StreamEvent as ApiStreamEvent, ToolChoice,
|
MessageRequest, MessageResponse, OutputContentBlock, StreamEvent as ApiStreamEvent, ToolChoice,
|
||||||
ToolDefinition, ToolResultContentBlock,
|
ToolDefinition, ToolResultContentBlock,
|
||||||
};
|
};
|
||||||
use plugins::{PluginManager, PluginManagerConfig, PluginTool};
|
|
||||||
use reqwest::blocking::Client;
|
use reqwest::blocking::Client;
|
||||||
use runtime::{
|
use runtime::{
|
||||||
edit_file, execute_bash, glob_search, grep_search, load_system_prompt, read_file, write_file,
|
edit_file, execute_bash, glob_search, grep_search, load_system_prompt, read_file, write_file,
|
||||||
ApiClient, ApiRequest, AssistantEvent, BashCommandInput, ConfigLoader, ContentBlock,
|
ApiClient, ApiRequest, AssistantEvent, BashCommandInput, ContentBlock, ConversationMessage,
|
||||||
ConversationMessage, ConversationRuntime, GrepSearchInput, MessageRole, PermissionMode,
|
ConversationRuntime, GrepSearchInput, MessageRole, PermissionMode, PermissionPolicy,
|
||||||
PermissionPolicy, RuntimeConfig, RuntimeError, Session, TokenUsage, ToolError, ToolExecutor,
|
RuntimeError, Session, TokenUsage, ToolError, ToolExecutor,
|
||||||
};
|
};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use serde_json::{json, Value};
|
use serde_json::{json, Value};
|
||||||
@@ -56,239 +55,6 @@ pub struct ToolSpec {
|
|||||||
pub required_permission: PermissionMode,
|
pub required_permission: PermissionMode,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
pub struct RegisteredTool {
|
|
||||||
pub definition: ToolDefinition,
|
|
||||||
pub required_permission: PermissionMode,
|
|
||||||
handler: RegisteredToolHandler,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::large_enum_variant)]
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
enum RegisteredToolHandler {
|
|
||||||
Builtin,
|
|
||||||
Plugin(PluginTool),
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
pub struct GlobalToolRegistry {
|
|
||||||
entries: Vec<RegisteredTool>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl GlobalToolRegistry {
|
|
||||||
#[must_use]
|
|
||||||
pub fn builtin() -> Self {
|
|
||||||
Self {
|
|
||||||
entries: mvp_tool_specs()
|
|
||||||
.into_iter()
|
|
||||||
.map(|spec| RegisteredTool {
|
|
||||||
definition: ToolDefinition {
|
|
||||||
name: spec.name.to_string(),
|
|
||||||
description: Some(spec.description.to_string()),
|
|
||||||
input_schema: spec.input_schema,
|
|
||||||
},
|
|
||||||
required_permission: spec.required_permission,
|
|
||||||
handler: RegisteredToolHandler::Builtin,
|
|
||||||
})
|
|
||||||
.collect(),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn with_plugin_tools(plugin_tools: Vec<PluginTool>) -> Result<Self, String> {
|
|
||||||
let mut registry = Self::builtin();
|
|
||||||
let mut seen = registry
|
|
||||||
.entries
|
|
||||||
.iter()
|
|
||||||
.map(|entry| {
|
|
||||||
(
|
|
||||||
normalize_registry_tool_name(&entry.definition.name),
|
|
||||||
entry.definition.name.clone(),
|
|
||||||
)
|
|
||||||
})
|
|
||||||
.collect::<BTreeMap<_, _>>();
|
|
||||||
|
|
||||||
for tool in plugin_tools {
|
|
||||||
let normalized = normalize_registry_tool_name(&tool.definition().name);
|
|
||||||
if let Some(existing) = seen.get(&normalized) {
|
|
||||||
return Err(format!(
|
|
||||||
"plugin tool `{}` from `{}` conflicts with already-registered tool `{existing}`",
|
|
||||||
tool.definition().name,
|
|
||||||
tool.plugin_id()
|
|
||||||
));
|
|
||||||
}
|
|
||||||
seen.insert(normalized, tool.definition().name.clone());
|
|
||||||
registry.entries.push(RegisteredTool {
|
|
||||||
definition: ToolDefinition {
|
|
||||||
name: tool.definition().name.clone(),
|
|
||||||
description: tool.definition().description.clone(),
|
|
||||||
input_schema: tool.definition().input_schema.clone(),
|
|
||||||
},
|
|
||||||
required_permission: permission_mode_from_plugin_tool(tool.required_permission())?,
|
|
||||||
handler: RegisteredToolHandler::Plugin(tool),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(registry)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn entries(&self) -> &[RegisteredTool] {
|
|
||||||
&self.entries
|
|
||||||
}
|
|
||||||
|
|
||||||
fn find_entry(&self, name: &str) -> Option<&RegisteredTool> {
|
|
||||||
let normalized = normalize_registry_tool_name(name);
|
|
||||||
self.entries.iter().find(|entry| {
|
|
||||||
normalize_registry_tool_name(entry.definition.name.as_str()) == normalized
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn definitions(&self, allowed_tools: Option<&BTreeSet<String>>) -> Vec<ToolDefinition> {
|
|
||||||
self.entries
|
|
||||||
.iter()
|
|
||||||
.filter(|entry| {
|
|
||||||
allowed_tools.is_none_or(|allowed| allowed.contains(entry.definition.name.as_str()))
|
|
||||||
})
|
|
||||||
.map(|entry| entry.definition.clone())
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn permission_specs(
|
|
||||||
&self,
|
|
||||||
allowed_tools: Option<&BTreeSet<String>>,
|
|
||||||
) -> Vec<(String, PermissionMode)> {
|
|
||||||
self.entries
|
|
||||||
.iter()
|
|
||||||
.filter(|entry| {
|
|
||||||
allowed_tools.is_none_or(|allowed| allowed.contains(entry.definition.name.as_str()))
|
|
||||||
})
|
|
||||||
.map(|entry| (entry.definition.name.clone(), entry.required_permission))
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn normalize_allowed_tools(
|
|
||||||
&self,
|
|
||||||
values: &[String],
|
|
||||||
) -> Result<Option<BTreeSet<String>>, String> {
|
|
||||||
if values.is_empty() {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
|
|
||||||
let canonical_names = self
|
|
||||||
.entries
|
|
||||||
.iter()
|
|
||||||
.map(|entry| entry.definition.name.clone())
|
|
||||||
.collect::<Vec<_>>();
|
|
||||||
let mut name_map = canonical_names
|
|
||||||
.iter()
|
|
||||||
.map(|name| (normalize_registry_tool_name(name), name.clone()))
|
|
||||||
.collect::<BTreeMap<_, _>>();
|
|
||||||
|
|
||||||
for (alias, canonical) in [
|
|
||||||
("read", "read_file"),
|
|
||||||
("write", "write_file"),
|
|
||||||
("edit", "edit_file"),
|
|
||||||
("glob", "glob_search"),
|
|
||||||
("grep", "grep_search"),
|
|
||||||
] {
|
|
||||||
if canonical_names.iter().any(|name| name == canonical) {
|
|
||||||
name_map.insert(alias.to_string(), canonical.to_string());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut allowed = BTreeSet::new();
|
|
||||||
for value in values {
|
|
||||||
for token in value
|
|
||||||
.split(|ch: char| ch == ',' || ch.is_whitespace())
|
|
||||||
.filter(|token| !token.is_empty())
|
|
||||||
{
|
|
||||||
let normalized = normalize_registry_tool_name(token);
|
|
||||||
let canonical = name_map.get(&normalized).ok_or_else(|| {
|
|
||||||
format!(
|
|
||||||
"unsupported tool in --allowedTools: {token} (expected one of: {})",
|
|
||||||
canonical_names.join(", ")
|
|
||||||
)
|
|
||||||
})?;
|
|
||||||
allowed.insert(canonical.clone());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(Some(allowed))
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn execute(&self, name: &str, input: &Value) -> Result<String, String> {
|
|
||||||
let entry = self
|
|
||||||
.find_entry(name)
|
|
||||||
.ok_or_else(|| format!("unsupported tool: {name}"))?;
|
|
||||||
match &entry.handler {
|
|
||||||
RegisteredToolHandler::Builtin => execute_tool(&entry.definition.name, input),
|
|
||||||
RegisteredToolHandler::Plugin(tool) => {
|
|
||||||
tool.execute(input).map_err(|error| error.to_string())
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Default for GlobalToolRegistry {
|
|
||||||
fn default() -> Self {
|
|
||||||
Self::builtin()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn normalize_registry_tool_name(value: &str) -> String {
|
|
||||||
let trimmed = value.trim();
|
|
||||||
let chars = trimmed.chars().collect::<Vec<_>>();
|
|
||||||
let mut normalized = String::new();
|
|
||||||
|
|
||||||
for (index, ch) in chars.iter().copied().enumerate() {
|
|
||||||
if matches!(ch, '-' | ' ' | '\t' | '\n') {
|
|
||||||
if !normalized.ends_with('_') {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
if ch == '_' {
|
|
||||||
if !normalized.ends_with('_') {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
if ch.is_uppercase() {
|
|
||||||
let prev = chars.get(index.wrapping_sub(1)).copied();
|
|
||||||
let next = chars.get(index + 1).copied();
|
|
||||||
let needs_separator = index > 0
|
|
||||||
&& !normalized.ends_with('_')
|
|
||||||
&& (prev.is_some_and(|prev| prev.is_lowercase() || prev.is_ascii_digit())
|
|
||||||
|| (prev.is_some_and(char::is_uppercase)
|
|
||||||
&& next.is_some_and(char::is_lowercase)));
|
|
||||||
if needs_separator {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
normalized.extend(ch.to_lowercase());
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
normalized.push(ch.to_ascii_lowercase());
|
|
||||||
}
|
|
||||||
|
|
||||||
normalized.trim_matches('_').to_string()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn permission_mode_from_plugin_tool(value: &str) -> Result<PermissionMode, String> {
|
|
||||||
match value {
|
|
||||||
"read-only" => Ok(PermissionMode::ReadOnly),
|
|
||||||
"workspace-write" => Ok(PermissionMode::WorkspaceWrite),
|
|
||||||
"danger-full-access" => Ok(PermissionMode::DangerFullAccess),
|
|
||||||
other => Err(format!(
|
|
||||||
"unsupported plugin tool permission `{other}` (expected read-only, workspace-write, or danger-full-access)"
|
|
||||||
)),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
#[allow(clippy::too_many_lines)]
|
#[allow(clippy::too_many_lines)]
|
||||||
pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
||||||
@@ -557,7 +323,7 @@ pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
|||||||
},
|
},
|
||||||
ToolSpec {
|
ToolSpec {
|
||||||
name: "Config",
|
name: "Config",
|
||||||
description: "Get or set Claw Code settings.",
|
description: "Get or set Claude Code settings.",
|
||||||
input_schema: json!({
|
input_schema: json!({
|
||||||
"type": "object",
|
"type": "object",
|
||||||
"properties": {
|
"properties": {
|
||||||
@@ -1700,15 +1466,13 @@ fn build_agent_runtime(
|
|||||||
.clone()
|
.clone()
|
||||||
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
||||||
let allowed_tools = job.allowed_tools.clone();
|
let allowed_tools = job.allowed_tools.clone();
|
||||||
let tool_registry = current_tool_registry()?;
|
let api_client = AnthropicRuntimeClient::new(model, allowed_tools.clone())?;
|
||||||
let api_client =
|
let tool_executor = SubagentToolExecutor::new(allowed_tools);
|
||||||
AnthropicRuntimeClient::new(model, allowed_tools.clone(), tool_registry.clone())?;
|
|
||||||
let tool_executor = SubagentToolExecutor::new(allowed_tools, tool_registry.clone());
|
|
||||||
Ok(ConversationRuntime::new(
|
Ok(ConversationRuntime::new(
|
||||||
Session::new(),
|
Session::new(),
|
||||||
api_client,
|
api_client,
|
||||||
tool_executor,
|
tool_executor,
|
||||||
agent_permission_policy(&tool_registry),
|
agent_permission_policy(),
|
||||||
job.system_prompt.clone(),
|
job.system_prompt.clone(),
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
@@ -1773,7 +1537,7 @@ fn allowed_tools_for_subagent(subagent_type: &str) -> BTreeSet<String> {
|
|||||||
"SendUserMessage",
|
"SendUserMessage",
|
||||||
"PowerShell",
|
"PowerShell",
|
||||||
],
|
],
|
||||||
"claw-code-guide" => vec![
|
"claude-code-guide" => vec![
|
||||||
"read_file",
|
"read_file",
|
||||||
"glob_search",
|
"glob_search",
|
||||||
"grep_search",
|
"grep_search",
|
||||||
@@ -1817,12 +1581,10 @@ fn allowed_tools_for_subagent(subagent_type: &str) -> BTreeSet<String> {
|
|||||||
tools.into_iter().map(str::to_string).collect()
|
tools.into_iter().map(str::to_string).collect()
|
||||||
}
|
}
|
||||||
|
|
||||||
fn agent_permission_policy(tool_registry: &GlobalToolRegistry) -> PermissionPolicy {
|
fn agent_permission_policy() -> PermissionPolicy {
|
||||||
tool_registry.permission_specs(None).into_iter().fold(
|
mvp_tool_specs().into_iter().fold(
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|policy, (name, required_permission)| {
|
|policy, spec| policy.with_tool_requirement(spec.name, spec.required_permission),
|
||||||
policy.with_tool_requirement(name, required_permission)
|
|
||||||
},
|
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1878,15 +1640,10 @@ struct AnthropicRuntimeClient {
|
|||||||
client: AnthropicClient,
|
client: AnthropicClient,
|
||||||
model: String,
|
model: String,
|
||||||
allowed_tools: BTreeSet<String>,
|
allowed_tools: BTreeSet<String>,
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AnthropicRuntimeClient {
|
impl AnthropicRuntimeClient {
|
||||||
fn new(
|
fn new(model: String, allowed_tools: BTreeSet<String>) -> Result<Self, String> {
|
||||||
model: String,
|
|
||||||
allowed_tools: BTreeSet<String>,
|
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
) -> Result<Self, String> {
|
|
||||||
let client = AnthropicClient::from_env()
|
let client = AnthropicClient::from_env()
|
||||||
.map_err(|error| error.to_string())?
|
.map_err(|error| error.to_string())?
|
||||||
.with_base_url(read_base_url());
|
.with_base_url(read_base_url());
|
||||||
@@ -1895,14 +1652,20 @@ impl AnthropicRuntimeClient {
|
|||||||
client,
|
client,
|
||||||
model,
|
model,
|
||||||
allowed_tools,
|
allowed_tools,
|
||||||
tool_registry,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ApiClient for AnthropicRuntimeClient {
|
impl ApiClient for AnthropicRuntimeClient {
|
||||||
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
let tools = self.tool_registry.definitions(Some(&self.allowed_tools));
|
let tools = tool_specs_for_allowed_tools(Some(&self.allowed_tools))
|
||||||
|
.into_iter()
|
||||||
|
.map(|spec| ToolDefinition {
|
||||||
|
name: spec.name.to_string(),
|
||||||
|
description: Some(spec.description.to_string()),
|
||||||
|
input_schema: spec.input_schema,
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
let message_request = MessageRequest {
|
let message_request = MessageRequest {
|
||||||
model: self.model.clone(),
|
model: self.model.clone(),
|
||||||
max_tokens: 32_000,
|
max_tokens: 32_000,
|
||||||
@@ -1953,8 +1716,6 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
input.push_str(&partial_json);
|
input.push_str(&partial_json);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
ContentBlockDelta::ThinkingDelta { .. }
|
|
||||||
| ContentBlockDelta::SignatureDelta { .. } => {}
|
|
||||||
},
|
},
|
||||||
ApiStreamEvent::ContentBlockStop(_) => {
|
ApiStreamEvent::ContentBlockStop(_) => {
|
||||||
if let Some((id, name, input)) = pending_tool.take() {
|
if let Some((id, name, input)) = pending_tool.take() {
|
||||||
@@ -2007,82 +1768,32 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
|
|
||||||
struct SubagentToolExecutor {
|
struct SubagentToolExecutor {
|
||||||
allowed_tools: BTreeSet<String>,
|
allowed_tools: BTreeSet<String>,
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl SubagentToolExecutor {
|
impl SubagentToolExecutor {
|
||||||
fn new(allowed_tools: BTreeSet<String>, tool_registry: GlobalToolRegistry) -> Self {
|
fn new(allowed_tools: BTreeSet<String>) -> Self {
|
||||||
Self {
|
Self { allowed_tools }
|
||||||
allowed_tools,
|
|
||||||
tool_registry,
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ToolExecutor for SubagentToolExecutor {
|
impl ToolExecutor for SubagentToolExecutor {
|
||||||
fn execute(&mut self, tool_name: &str, input: &str) -> Result<String, ToolError> {
|
fn execute(&mut self, tool_name: &str, input: &str) -> Result<String, ToolError> {
|
||||||
let entry = self
|
if !self.allowed_tools.contains(tool_name) {
|
||||||
.tool_registry
|
|
||||||
.find_entry(tool_name)
|
|
||||||
.ok_or_else(|| ToolError::new(format!("unsupported tool: {tool_name}")))?;
|
|
||||||
if !self.allowed_tools.contains(entry.definition.name.as_str()) {
|
|
||||||
return Err(ToolError::new(format!(
|
return Err(ToolError::new(format!(
|
||||||
"tool `{tool_name}` is not enabled for this sub-agent"
|
"tool `{tool_name}` is not enabled for this sub-agent"
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
let value = serde_json::from_str(input)
|
let value = serde_json::from_str(input)
|
||||||
.map_err(|error| ToolError::new(format!("invalid tool input JSON: {error}")))?;
|
.map_err(|error| ToolError::new(format!("invalid tool input JSON: {error}")))?;
|
||||||
self.tool_registry
|
execute_tool(tool_name, &value).map_err(ToolError::new)
|
||||||
.execute(tool_name, &value)
|
|
||||||
.map_err(ToolError::new)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn current_tool_registry() -> Result<GlobalToolRegistry, String> {
|
fn tool_specs_for_allowed_tools(allowed_tools: Option<&BTreeSet<String>>) -> Vec<ToolSpec> {
|
||||||
let cwd = std::env::current_dir().map_err(|error| error.to_string())?;
|
mvp_tool_specs()
|
||||||
let loader = ConfigLoader::default_for(&cwd);
|
.into_iter()
|
||||||
let runtime_config = loader.load().map_err(|error| error.to_string())?;
|
.filter(|spec| allowed_tools.is_none_or(|allowed| allowed.contains(spec.name)))
|
||||||
let plugin_manager = build_plugin_manager(&cwd, &loader, &runtime_config);
|
.collect()
|
||||||
let plugin_tools = plugin_manager
|
|
||||||
.aggregated_tools()
|
|
||||||
.map_err(|error| error.to_string())?;
|
|
||||||
GlobalToolRegistry::with_plugin_tools(plugin_tools)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn build_plugin_manager(
|
|
||||||
cwd: &Path,
|
|
||||||
loader: &ConfigLoader,
|
|
||||||
runtime_config: &RuntimeConfig,
|
|
||||||
) -> PluginManager {
|
|
||||||
let plugin_settings = runtime_config.plugins();
|
|
||||||
let mut plugin_config = PluginManagerConfig::new(loader.config_home().to_path_buf());
|
|
||||||
plugin_config.enabled_plugins = plugin_settings.enabled_plugins().clone();
|
|
||||||
plugin_config.external_dirs = plugin_settings
|
|
||||||
.external_directories()
|
|
||||||
.iter()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path))
|
|
||||||
.collect();
|
|
||||||
plugin_config.install_root = plugin_settings
|
|
||||||
.install_root()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
plugin_config.registry_path = plugin_settings
|
|
||||||
.registry_path()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
plugin_config.bundled_root = plugin_settings
|
|
||||||
.bundled_root()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
PluginManager::new(plugin_config)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn resolve_plugin_path(cwd: &Path, config_home: &Path, value: &str) -> PathBuf {
|
|
||||||
let path = PathBuf::from(value);
|
|
||||||
if path.is_absolute() {
|
|
||||||
path
|
|
||||||
} else if value.starts_with('.') {
|
|
||||||
cwd.join(path)
|
|
||||||
} else {
|
|
||||||
config_home.join(path)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
||||||
@@ -2149,7 +1860,6 @@ fn push_output_block(
|
|||||||
};
|
};
|
||||||
*pending_tool = Some((id, name, initial_input));
|
*pending_tool = Some((id, name, initial_input));
|
||||||
}
|
}
|
||||||
OutputContentBlock::Thinking { .. } | OutputContentBlock::RedactedThinking { .. } => {}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2377,7 +2087,7 @@ fn normalize_subagent_type(subagent_type: Option<&str>) -> String {
|
|||||||
"verification" | "verificationagent" | "verify" | "verifier" => {
|
"verification" | "verificationagent" | "verify" | "verifier" => {
|
||||||
String::from("Verification")
|
String::from("Verification")
|
||||||
}
|
}
|
||||||
"claudecodeguide" | "claudecodeguideagent" | "guide" => String::from("claw-code-guide"),
|
"claudecodeguide" | "claudecodeguideagent" | "guide" => String::from("claude-code-guide"),
|
||||||
"statusline" | "statuslinesetup" => String::from("statusline-setup"),
|
"statusline" | "statuslinesetup" => String::from("statusline-setup"),
|
||||||
_ => trimmed.to_string(),
|
_ => trimmed.to_string(),
|
||||||
}
|
}
|
||||||
@@ -3195,13 +2905,9 @@ mod tests {
|
|||||||
use super::{
|
use super::{
|
||||||
agent_permission_policy, allowed_tools_for_subagent, execute_agent_with_spawn,
|
agent_permission_policy, allowed_tools_for_subagent, execute_agent_with_spawn,
|
||||||
execute_tool, final_assistant_text, mvp_tool_specs, persist_agent_terminal_state,
|
execute_tool, final_assistant_text, mvp_tool_specs, persist_agent_terminal_state,
|
||||||
response_to_events, AgentInput, AgentJob, GlobalToolRegistry, SubagentToolExecutor,
|
AgentInput, AgentJob, SubagentToolExecutor,
|
||||||
};
|
|
||||||
use api::{MessageResponse, OutputContentBlock, Usage};
|
|
||||||
use plugins::{PluginTool, PluginToolDefinition, PluginToolPermission};
|
|
||||||
use runtime::{
|
|
||||||
ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, Session, ToolExecutor,
|
|
||||||
};
|
};
|
||||||
|
use runtime::{ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, Session};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
|
|
||||||
fn env_lock() -> &'static Mutex<()> {
|
fn env_lock() -> &'static Mutex<()> {
|
||||||
@@ -3217,17 +2923,6 @@ mod tests {
|
|||||||
std::env::temp_dir().join(format!("clawd-tools-{unique}-{name}"))
|
std::env::temp_dir().join(format!("clawd-tools-{unique}-{name}"))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn make_executable(path: &PathBuf) {
|
|
||||||
#[cfg(unix)]
|
|
||||||
{
|
|
||||||
use std::os::unix::fs::PermissionsExt;
|
|
||||||
|
|
||||||
let mut permissions = std::fs::metadata(path).expect("metadata").permissions();
|
|
||||||
permissions.set_mode(0o755);
|
|
||||||
std::fs::set_permissions(path, permissions).expect("chmod");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn exposes_mvp_tools() {
|
fn exposes_mvp_tools() {
|
||||||
let names = mvp_tool_specs()
|
let names = mvp_tool_specs()
|
||||||
@@ -3257,170 +2952,6 @@ mod tests {
|
|||||||
assert!(error.contains("unsupported tool"));
|
assert!(error.contains("unsupported tool"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_registers_and_executes_plugin_tools() {
|
|
||||||
let script = temp_path("plugin-tool.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"plugin\":\"%s\",\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_PLUGIN_ID\" \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
"sh".to_string(),
|
|
||||||
vec![script.display().to_string()],
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let names = registry
|
|
||||||
.definitions(None)
|
|
||||||
.into_iter()
|
|
||||||
.map(|definition| definition.name)
|
|
||||||
.collect::<Vec<_>>();
|
|
||||||
assert!(names.contains(&"bash".to_string()));
|
|
||||||
assert!(names.contains(&"plugin_echo".to_string()));
|
|
||||||
|
|
||||||
let output = registry
|
|
||||||
.execute("plugin_echo", &json!({ "message": "hello" }))
|
|
||||||
.expect("plugin tool should execute");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["plugin"], "demo@external");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_normalizes_plugin_tool_names_for_allowlists_and_execution() {
|
|
||||||
let script = temp_path("plugin-tool-normalized.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
script.display().to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let allowed = registry
|
|
||||||
.normalize_allowed_tools(&[String::from("PLUGIN-ECHO")])
|
|
||||||
.expect("plugin tool allowlist should normalize")
|
|
||||||
.expect("allowlist should be present");
|
|
||||||
assert!(allowed.contains("plugin_echo"));
|
|
||||||
|
|
||||||
let output = registry
|
|
||||||
.execute("plugin-echo", &json!({ "message": "hello" }))
|
|
||||||
.expect("normalized plugin tool name should execute");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let builtin_output = GlobalToolRegistry::builtin()
|
|
||||||
.execute("structured-output", &json!({ "ok": true }))
|
|
||||||
.expect("normalized builtin tool name should execute");
|
|
||||||
let builtin_payload: serde_json::Value =
|
|
||||||
serde_json::from_str(&builtin_output).expect("valid json");
|
|
||||||
assert_eq!(builtin_payload["structured_output"]["ok"], true);
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn subagent_executor_executes_allowed_plugin_tools() {
|
|
||||||
let script = temp_path("subagent-plugin-tool.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
script.display().to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let mut executor =
|
|
||||||
SubagentToolExecutor::new(BTreeSet::from([String::from("plugin_echo")]), registry);
|
|
||||||
let output = executor
|
|
||||||
.execute("plugin-echo", r#"{"message":"hello"}"#)
|
|
||||||
.expect("plugin tool should execute for subagent");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_rejects_conflicting_plugin_tool_names() {
|
|
||||||
let error = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "read-file".to_string(),
|
|
||||||
description: Some("Conflicts with builtin".to_string()),
|
|
||||||
input_schema: json!({ "type": "object" }),
|
|
||||||
},
|
|
||||||
"echo".to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::ReadOnly,
|
|
||||||
None,
|
|
||||||
)])
|
|
||||||
.expect_err("conflicting plugin tool should fail");
|
|
||||||
|
|
||||||
assert!(error.contains("conflicts with already-registered tool `read_file`"));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn web_fetch_returns_prompt_aware_summary() {
|
fn web_fetch_returns_prompt_aware_summary() {
|
||||||
let server = TestServer::spawn(Arc::new(|request_line: &str| {
|
let server = TestServer::spawn(Arc::new(|request_line: &str| {
|
||||||
@@ -4000,11 +3531,8 @@ mod tests {
|
|||||||
calls: 0,
|
calls: 0,
|
||||||
input_path: path.display().to_string(),
|
input_path: path.display().to_string(),
|
||||||
},
|
},
|
||||||
SubagentToolExecutor::new(
|
SubagentToolExecutor::new(BTreeSet::from([String::from("read_file")])),
|
||||||
BTreeSet::from([String::from("read_file")]),
|
agent_permission_policy(),
|
||||||
GlobalToolRegistry::builtin(),
|
|
||||||
),
|
|
||||||
agent_permission_policy(&GlobalToolRegistry::builtin()),
|
|
||||||
vec![String::from("system prompt")],
|
vec![String::from("system prompt")],
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -4030,42 +3558,6 @@ mod tests {
|
|||||||
let _ = std::fs::remove_file(path);
|
let _ = std::fs::remove_file(path);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn response_to_events_ignores_thinking_blocks() {
|
|
||||||
let events = response_to_events(MessageResponse {
|
|
||||||
id: "msg-1".to_string(),
|
|
||||||
kind: "message".to_string(),
|
|
||||||
model: "claude-opus-4-6".to_string(),
|
|
||||||
role: "assistant".to_string(),
|
|
||||||
content: vec![
|
|
||||||
OutputContentBlock::Thinking {
|
|
||||||
thinking: "step 1".to_string(),
|
|
||||||
signature: Some("sig_123".to_string()),
|
|
||||||
},
|
|
||||||
OutputContentBlock::Text {
|
|
||||||
text: "Final answer".to_string(),
|
|
||||||
},
|
|
||||||
],
|
|
||||||
stop_reason: Some("end_turn".to_string()),
|
|
||||||
stop_sequence: None,
|
|
||||||
usage: Usage {
|
|
||||||
input_tokens: 1,
|
|
||||||
output_tokens: 1,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
},
|
|
||||||
request_id: None,
|
|
||||||
});
|
|
||||||
|
|
||||||
assert!(matches!(
|
|
||||||
&events[0],
|
|
||||||
AssistantEvent::TextDelta(text) if text == "Final answer"
|
|
||||||
));
|
|
||||||
assert!(!events
|
|
||||||
.iter()
|
|
||||||
.any(|event| matches!(event, AssistantEvent::ToolUse { .. })));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn agent_rejects_blank_required_fields() {
|
fn agent_rejects_blank_required_fields() {
|
||||||
let missing_description = execute_tool(
|
let missing_description = execute_tool(
|
||||||
|
|||||||
Reference in New Issue
Block a user