mirror of
https://github.com/instructkr/claw-code.git
synced 2026-04-03 17:34:48 +08:00
fix: update prompt tests for post-plugins-merge format
This commit is contained in:
File diff suppressed because it is too large
Load Diff
@@ -4,7 +4,10 @@ use std::time::Duration;
|
|||||||
|
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub enum ApiError {
|
pub enum ApiError {
|
||||||
MissingApiKey,
|
MissingCredentials {
|
||||||
|
provider: &'static str,
|
||||||
|
env_vars: &'static [&'static str],
|
||||||
|
},
|
||||||
ExpiredOAuthToken,
|
ExpiredOAuthToken,
|
||||||
Auth(String),
|
Auth(String),
|
||||||
InvalidApiKeyEnv(VarError),
|
InvalidApiKeyEnv(VarError),
|
||||||
@@ -30,13 +33,21 @@ pub enum ApiError {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl ApiError {
|
impl ApiError {
|
||||||
|
#[must_use]
|
||||||
|
pub const fn missing_credentials(
|
||||||
|
provider: &'static str,
|
||||||
|
env_vars: &'static [&'static str],
|
||||||
|
) -> Self {
|
||||||
|
Self::MissingCredentials { provider, env_vars }
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn is_retryable(&self) -> bool {
|
pub fn is_retryable(&self) -> bool {
|
||||||
match self {
|
match self {
|
||||||
Self::Http(error) => error.is_connect() || error.is_timeout() || error.is_request(),
|
Self::Http(error) => error.is_connect() || error.is_timeout() || error.is_request(),
|
||||||
Self::Api { retryable, .. } => *retryable,
|
Self::Api { retryable, .. } => *retryable,
|
||||||
Self::RetriesExhausted { last_error, .. } => last_error.is_retryable(),
|
Self::RetriesExhausted { last_error, .. } => last_error.is_retryable(),
|
||||||
Self::MissingApiKey
|
Self::MissingCredentials { .. }
|
||||||
| Self::ExpiredOAuthToken
|
| Self::ExpiredOAuthToken
|
||||||
| Self::Auth(_)
|
| Self::Auth(_)
|
||||||
| Self::InvalidApiKeyEnv(_)
|
| Self::InvalidApiKeyEnv(_)
|
||||||
@@ -51,12 +62,11 @@ impl ApiError {
|
|||||||
impl Display for ApiError {
|
impl Display for ApiError {
|
||||||
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
|
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
|
||||||
match self {
|
match self {
|
||||||
Self::MissingApiKey => {
|
Self::MissingCredentials { provider, env_vars } => write!(
|
||||||
write!(
|
f,
|
||||||
f,
|
"missing {provider} credentials; export {} before calling the {provider} API",
|
||||||
"ANTHROPIC_AUTH_TOKEN or ANTHROPIC_API_KEY is not set; export one before calling the Anthropic API"
|
env_vars.join(" or ")
|
||||||
)
|
),
|
||||||
}
|
|
||||||
Self::ExpiredOAuthToken => {
|
Self::ExpiredOAuthToken => {
|
||||||
write!(
|
write!(
|
||||||
f,
|
f,
|
||||||
@@ -65,10 +75,7 @@ impl Display for ApiError {
|
|||||||
}
|
}
|
||||||
Self::Auth(message) => write!(f, "auth error: {message}"),
|
Self::Auth(message) => write!(f, "auth error: {message}"),
|
||||||
Self::InvalidApiKeyEnv(error) => {
|
Self::InvalidApiKeyEnv(error) => {
|
||||||
write!(
|
write!(f, "failed to read credential environment variable: {error}")
|
||||||
f,
|
|
||||||
"failed to read ANTHROPIC_AUTH_TOKEN / ANTHROPIC_API_KEY: {error}"
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
Self::Http(error) => write!(f, "http error: {error}"),
|
Self::Http(error) => write!(f, "http error: {error}"),
|
||||||
Self::Io(error) => write!(f, "io error: {error}"),
|
Self::Io(error) => write!(f, "io error: {error}"),
|
||||||
@@ -81,20 +88,14 @@ impl Display for ApiError {
|
|||||||
..
|
..
|
||||||
} => match (error_type, message) {
|
} => match (error_type, message) {
|
||||||
(Some(error_type), Some(message)) => {
|
(Some(error_type), Some(message)) => {
|
||||||
write!(
|
write!(f, "api returned {status} ({error_type}): {message}")
|
||||||
f,
|
|
||||||
"anthropic api returned {status} ({error_type}): {message}"
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
_ => write!(f, "anthropic api returned {status}: {body}"),
|
_ => write!(f, "api returned {status}: {body}"),
|
||||||
},
|
},
|
||||||
Self::RetriesExhausted {
|
Self::RetriesExhausted {
|
||||||
attempts,
|
attempts,
|
||||||
last_error,
|
last_error,
|
||||||
} => write!(
|
} => write!(f, "api failed after {attempts} attempts: {last_error}"),
|
||||||
f,
|
|
||||||
"anthropic api failed after {attempts} attempts: {last_error}"
|
|
||||||
),
|
|
||||||
Self::InvalidSseFrame(message) => write!(f, "invalid sse frame: {message}"),
|
Self::InvalidSseFrame(message) => write!(f, "invalid sse frame: {message}"),
|
||||||
Self::BackoffOverflow {
|
Self::BackoffOverflow {
|
||||||
attempt,
|
attempt,
|
||||||
|
|||||||
@@ -1,13 +1,19 @@
|
|||||||
mod client;
|
mod client;
|
||||||
mod error;
|
mod error;
|
||||||
|
mod providers;
|
||||||
mod sse;
|
mod sse;
|
||||||
mod types;
|
mod types;
|
||||||
|
|
||||||
pub use client::{
|
pub use client::{
|
||||||
oauth_token_is_expired, read_base_url, resolve_saved_oauth_token, resolve_startup_auth_source,
|
oauth_token_is_expired, read_base_url, read_xai_base_url, resolve_saved_oauth_token,
|
||||||
ApiHttpClient, AuthSource, MessageStream, OAuthTokenSet,
|
resolve_startup_auth_source, MessageStream, OAuthTokenSet, ProviderClient,
|
||||||
};
|
};
|
||||||
pub use error::ApiError;
|
pub use error::ApiError;
|
||||||
|
pub use providers::anthropic::{AnthropicClient, AuthSource};
|
||||||
|
pub use providers::openai_compat::{OpenAiCompatClient, OpenAiCompatConfig};
|
||||||
|
pub use providers::{
|
||||||
|
detect_provider_kind, max_tokens_for_model, resolve_model_alias, ProviderKind,
|
||||||
|
};
|
||||||
pub use sse::{parse_frame, SseParser};
|
pub use sse::{parse_frame, SseParser};
|
||||||
pub use types::{
|
pub use types::{
|
||||||
ContentBlockDelta, ContentBlockDeltaEvent, ContentBlockStartEvent, ContentBlockStopEvent,
|
ContentBlockDelta, ContentBlockDeltaEvent, ContentBlockStartEvent, ContentBlockStopEvent,
|
||||||
|
|||||||
1038
rust/crates/api/src/providers/anthropic.rs
Normal file
1038
rust/crates/api/src/providers/anthropic.rs
Normal file
File diff suppressed because it is too large
Load Diff
216
rust/crates/api/src/providers/mod.rs
Normal file
216
rust/crates/api/src/providers/mod.rs
Normal file
@@ -0,0 +1,216 @@
|
|||||||
|
use std::future::Future;
|
||||||
|
use std::pin::Pin;
|
||||||
|
|
||||||
|
use crate::error::ApiError;
|
||||||
|
use crate::types::{MessageRequest, MessageResponse};
|
||||||
|
|
||||||
|
pub mod anthropic;
|
||||||
|
pub mod openai_compat;
|
||||||
|
|
||||||
|
pub type ProviderFuture<'a, T> = Pin<Box<dyn Future<Output = Result<T, ApiError>> + Send + 'a>>;
|
||||||
|
|
||||||
|
pub trait Provider {
|
||||||
|
type Stream;
|
||||||
|
|
||||||
|
fn send_message<'a>(
|
||||||
|
&'a self,
|
||||||
|
request: &'a MessageRequest,
|
||||||
|
) -> ProviderFuture<'a, MessageResponse>;
|
||||||
|
|
||||||
|
fn stream_message<'a>(
|
||||||
|
&'a self,
|
||||||
|
request: &'a MessageRequest,
|
||||||
|
) -> ProviderFuture<'a, Self::Stream>;
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum ProviderKind {
|
||||||
|
Anthropic,
|
||||||
|
Xai,
|
||||||
|
OpenAi,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub struct ProviderMetadata {
|
||||||
|
pub provider: ProviderKind,
|
||||||
|
pub auth_env: &'static str,
|
||||||
|
pub base_url_env: &'static str,
|
||||||
|
pub default_base_url: &'static str,
|
||||||
|
}
|
||||||
|
|
||||||
|
const MODEL_REGISTRY: &[(&str, ProviderMetadata)] = &[
|
||||||
|
(
|
||||||
|
"opus",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Anthropic,
|
||||||
|
auth_env: "ANTHROPIC_API_KEY",
|
||||||
|
base_url_env: "ANTHROPIC_BASE_URL",
|
||||||
|
default_base_url: anthropic::DEFAULT_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"sonnet",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Anthropic,
|
||||||
|
auth_env: "ANTHROPIC_API_KEY",
|
||||||
|
base_url_env: "ANTHROPIC_BASE_URL",
|
||||||
|
default_base_url: anthropic::DEFAULT_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"haiku",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Anthropic,
|
||||||
|
auth_env: "ANTHROPIC_API_KEY",
|
||||||
|
base_url_env: "ANTHROPIC_BASE_URL",
|
||||||
|
default_base_url: anthropic::DEFAULT_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"grok",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"grok-3",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"grok-mini",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"grok-3-mini",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
(
|
||||||
|
"grok-2",
|
||||||
|
ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
},
|
||||||
|
),
|
||||||
|
];
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn resolve_model_alias(model: &str) -> String {
|
||||||
|
let trimmed = model.trim();
|
||||||
|
let lower = trimmed.to_ascii_lowercase();
|
||||||
|
MODEL_REGISTRY
|
||||||
|
.iter()
|
||||||
|
.find_map(|(alias, metadata)| {
|
||||||
|
(*alias == lower).then_some(match metadata.provider {
|
||||||
|
ProviderKind::Anthropic => match *alias {
|
||||||
|
"opus" => "claude-opus-4-6",
|
||||||
|
"sonnet" => "claude-sonnet-4-6",
|
||||||
|
"haiku" => "claude-haiku-4-5-20251213",
|
||||||
|
_ => trimmed,
|
||||||
|
},
|
||||||
|
ProviderKind::Xai => match *alias {
|
||||||
|
"grok" | "grok-3" => "grok-3",
|
||||||
|
"grok-mini" | "grok-3-mini" => "grok-3-mini",
|
||||||
|
"grok-2" => "grok-2",
|
||||||
|
_ => trimmed,
|
||||||
|
},
|
||||||
|
ProviderKind::OpenAi => trimmed,
|
||||||
|
})
|
||||||
|
})
|
||||||
|
.map_or_else(|| trimmed.to_string(), ToOwned::to_owned)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn metadata_for_model(model: &str) -> Option<ProviderMetadata> {
|
||||||
|
let canonical = resolve_model_alias(model);
|
||||||
|
if canonical.starts_with("claude") {
|
||||||
|
return Some(ProviderMetadata {
|
||||||
|
provider: ProviderKind::Anthropic,
|
||||||
|
auth_env: "ANTHROPIC_API_KEY",
|
||||||
|
base_url_env: "ANTHROPIC_BASE_URL",
|
||||||
|
default_base_url: anthropic::DEFAULT_BASE_URL,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if canonical.starts_with("grok") {
|
||||||
|
return Some(ProviderMetadata {
|
||||||
|
provider: ProviderKind::Xai,
|
||||||
|
auth_env: "XAI_API_KEY",
|
||||||
|
base_url_env: "XAI_BASE_URL",
|
||||||
|
default_base_url: openai_compat::DEFAULT_XAI_BASE_URL,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
None
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn detect_provider_kind(model: &str) -> ProviderKind {
|
||||||
|
if let Some(metadata) = metadata_for_model(model) {
|
||||||
|
return metadata.provider;
|
||||||
|
}
|
||||||
|
if anthropic::has_auth_from_env_or_saved().unwrap_or(false) {
|
||||||
|
return ProviderKind::Anthropic;
|
||||||
|
}
|
||||||
|
if openai_compat::has_api_key("OPENAI_API_KEY") {
|
||||||
|
return ProviderKind::OpenAi;
|
||||||
|
}
|
||||||
|
if openai_compat::has_api_key("XAI_API_KEY") {
|
||||||
|
return ProviderKind::Xai;
|
||||||
|
}
|
||||||
|
ProviderKind::Anthropic
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn max_tokens_for_model(model: &str) -> u32 {
|
||||||
|
let canonical = resolve_model_alias(model);
|
||||||
|
if canonical.contains("opus") {
|
||||||
|
32_000
|
||||||
|
} else {
|
||||||
|
64_000
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::{detect_provider_kind, max_tokens_for_model, resolve_model_alias, ProviderKind};
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn resolves_grok_aliases() {
|
||||||
|
assert_eq!(resolve_model_alias("grok"), "grok-3");
|
||||||
|
assert_eq!(resolve_model_alias("grok-mini"), "grok-3-mini");
|
||||||
|
assert_eq!(resolve_model_alias("grok-2"), "grok-2");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn detects_provider_from_model_name_first() {
|
||||||
|
assert_eq!(detect_provider_kind("grok"), ProviderKind::Xai);
|
||||||
|
assert_eq!(
|
||||||
|
detect_provider_kind("claude-sonnet-4-6"),
|
||||||
|
ProviderKind::Anthropic
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn keeps_existing_max_token_heuristic() {
|
||||||
|
assert_eq!(max_tokens_for_model("opus"), 32_000);
|
||||||
|
assert_eq!(max_tokens_for_model("grok-3"), 64_000);
|
||||||
|
}
|
||||||
|
}
|
||||||
1050
rust/crates/api/src/providers/openai_compat.rs
Normal file
1050
rust/crates/api/src/providers/openai_compat.rs
Normal file
File diff suppressed because it is too large
Load Diff
@@ -3,9 +3,9 @@ use std::sync::Arc;
|
|||||||
use std::time::Duration;
|
use std::time::Duration;
|
||||||
|
|
||||||
use api::{
|
use api::{
|
||||||
ApiHttpClient, ApiError, ContentBlockDelta, ContentBlockDeltaEvent, ContentBlockStartEvent,
|
AnthropicClient, ApiError, AuthSource, ContentBlockDelta, ContentBlockDeltaEvent,
|
||||||
InputContentBlock, InputMessage, MessageDeltaEvent, MessageRequest, OutputContentBlock,
|
ContentBlockStartEvent, InputContentBlock, InputMessage, MessageDeltaEvent, MessageRequest,
|
||||||
StreamEvent, ToolChoice, ToolDefinition,
|
OutputContentBlock, ProviderClient, StreamEvent, ToolChoice, ToolDefinition,
|
||||||
};
|
};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
||||||
@@ -34,7 +34,7 @@ async fn send_message_posts_json_and_parses_response() {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key")
|
let client = AnthropicClient::new("test-key")
|
||||||
.with_auth_token(Some("proxy-token".to_string()))
|
.with_auth_token(Some("proxy-token".to_string()))
|
||||||
.with_base_url(server.base_url());
|
.with_base_url(server.base_url());
|
||||||
let response = client
|
let response = client
|
||||||
@@ -75,48 +75,6 @@ async fn send_message_posts_json_and_parses_response() {
|
|||||||
assert_eq!(body["tool_choice"]["type"], json!("auto"));
|
assert_eq!(body["tool_choice"]["type"], json!("auto"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn send_message_parses_response_with_thinking_blocks() {
|
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
|
||||||
let body = concat!(
|
|
||||||
"{",
|
|
||||||
"\"id\":\"msg_thinking\",",
|
|
||||||
"\"type\":\"message\",",
|
|
||||||
"\"role\":\"assistant\",",
|
|
||||||
"\"content\":[",
|
|
||||||
"{\"type\":\"thinking\",\"thinking\":\"step 1\",\"signature\":\"sig_123\"},",
|
|
||||||
"{\"type\":\"text\",\"text\":\"Final answer\"}",
|
|
||||||
"],",
|
|
||||||
"\"model\":\"claude-3-7-sonnet-latest\",",
|
|
||||||
"\"stop_reason\":\"end_turn\",",
|
|
||||||
"\"stop_sequence\":null,",
|
|
||||||
"\"usage\":{\"input_tokens\":12,\"output_tokens\":4}",
|
|
||||||
"}"
|
|
||||||
);
|
|
||||||
let server = spawn_server(
|
|
||||||
state,
|
|
||||||
vec![http_response("200 OK", "application/json", body)],
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key").with_base_url(server.base_url());
|
|
||||||
let response = client
|
|
||||||
.send_message(&sample_request(false))
|
|
||||||
.await
|
|
||||||
.expect("request should succeed");
|
|
||||||
|
|
||||||
assert_eq!(response.content.len(), 2);
|
|
||||||
assert!(matches!(
|
|
||||||
&response.content[0],
|
|
||||||
OutputContentBlock::Thinking { thinking, signature }
|
|
||||||
if thinking == "step 1" && signature.as_deref() == Some("sig_123")
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&response.content[1],
|
|
||||||
OutputContentBlock::Text { text } if text == "Final answer"
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn stream_message_parses_sse_events_with_tool_use() {
|
async fn stream_message_parses_sse_events_with_tool_use() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
@@ -146,7 +104,7 @@ async fn stream_message_parses_sse_events_with_tool_use() {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key")
|
let client = AnthropicClient::new("test-key")
|
||||||
.with_auth_token(Some("proxy-token".to_string()))
|
.with_auth_token(Some("proxy-token".to_string()))
|
||||||
.with_base_url(server.base_url());
|
.with_base_url(server.base_url());
|
||||||
let mut stream = client
|
let mut stream = client
|
||||||
@@ -204,85 +162,6 @@ async fn stream_message_parses_sse_events_with_tool_use() {
|
|||||||
assert!(request.body.contains("\"stream\":true"));
|
assert!(request.body.contains("\"stream\":true"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn stream_message_parses_sse_events_with_thinking_blocks() {
|
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
|
||||||
let sse = concat!(
|
|
||||||
"event: message_start\n",
|
|
||||||
"data: {\"type\":\"message_start\",\"message\":{\"id\":\"msg_stream_thinking\",\"type\":\"message\",\"role\":\"assistant\",\"content\":[],\"model\":\"claude-3-7-sonnet-latest\",\"stop_reason\":null,\"stop_sequence\":null,\"usage\":{\"input_tokens\":8,\"output_tokens\":0}}}\n\n",
|
|
||||||
"event: content_block_start\n",
|
|
||||||
"data: {\"type\":\"content_block_start\",\"index\":0,\"content_block\":{\"type\":\"thinking\",\"thinking\":\"\"}}\n\n",
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"thinking_delta\",\"thinking\":\"step 1\"}}\n\n",
|
|
||||||
"event: content_block_delta\n",
|
|
||||||
"data: {\"type\":\"content_block_delta\",\"index\":0,\"delta\":{\"type\":\"signature_delta\",\"signature\":\"sig_123\"}}\n\n",
|
|
||||||
"event: content_block_stop\n",
|
|
||||||
"data: {\"type\":\"content_block_stop\",\"index\":0}\n\n",
|
|
||||||
"event: content_block_start\n",
|
|
||||||
"data: {\"type\":\"content_block_start\",\"index\":1,\"content_block\":{\"type\":\"text\",\"text\":\"Final answer\"}}\n\n",
|
|
||||||
"event: content_block_stop\n",
|
|
||||||
"data: {\"type\":\"content_block_stop\",\"index\":1}\n\n",
|
|
||||||
"event: message_delta\n",
|
|
||||||
"data: {\"type\":\"message_delta\",\"delta\":{\"stop_reason\":\"end_turn\",\"stop_sequence\":null},\"usage\":{\"input_tokens\":8,\"output_tokens\":1}}\n\n",
|
|
||||||
"event: message_stop\n",
|
|
||||||
"data: {\"type\":\"message_stop\"}\n\n",
|
|
||||||
"data: [DONE]\n\n"
|
|
||||||
);
|
|
||||||
let server = spawn_server(
|
|
||||||
state,
|
|
||||||
vec![http_response("200 OK", "text/event-stream", sse)],
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key").with_base_url(server.base_url());
|
|
||||||
let mut stream = client
|
|
||||||
.stream_message(&sample_request(false))
|
|
||||||
.await
|
|
||||||
.expect("stream should start");
|
|
||||||
|
|
||||||
let mut events = Vec::new();
|
|
||||||
while let Some(event) = stream
|
|
||||||
.next_event()
|
|
||||||
.await
|
|
||||||
.expect("stream event should parse")
|
|
||||||
{
|
|
||||||
events.push(event);
|
|
||||||
}
|
|
||||||
|
|
||||||
assert_eq!(events.len(), 9);
|
|
||||||
assert!(matches!(
|
|
||||||
&events[1],
|
|
||||||
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
|
||||||
content_block: OutputContentBlock::Thinking { thinking, signature },
|
|
||||||
..
|
|
||||||
}) if thinking.is_empty() && signature.is_none()
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[2],
|
|
||||||
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
|
||||||
delta: ContentBlockDelta::ThinkingDelta { thinking },
|
|
||||||
..
|
|
||||||
}) if thinking == "step 1"
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[3],
|
|
||||||
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
|
||||||
delta: ContentBlockDelta::SignatureDelta { signature },
|
|
||||||
..
|
|
||||||
}) if signature == "sig_123"
|
|
||||||
));
|
|
||||||
assert!(matches!(
|
|
||||||
&events[5],
|
|
||||||
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
|
||||||
content_block: OutputContentBlock::Text { text },
|
|
||||||
..
|
|
||||||
}) if text == "Final answer"
|
|
||||||
));
|
|
||||||
assert!(matches!(events[6], StreamEvent::ContentBlockStop(_)));
|
|
||||||
assert!(matches!(events[7], StreamEvent::MessageDelta(_)));
|
|
||||||
assert!(matches!(events[8], StreamEvent::MessageStop(_)));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn retries_retryable_failures_before_succeeding() {
|
async fn retries_retryable_failures_before_succeeding() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
@@ -303,7 +182,7 @@ async fn retries_retryable_failures_before_succeeding() {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key")
|
let client = AnthropicClient::new("test-key")
|
||||||
.with_base_url(server.base_url())
|
.with_base_url(server.base_url())
|
||||||
.with_retry_policy(2, Duration::from_millis(1), Duration::from_millis(2));
|
.with_retry_policy(2, Duration::from_millis(1), Duration::from_millis(2));
|
||||||
|
|
||||||
@@ -316,6 +195,47 @@ async fn retries_retryable_failures_before_succeeding() {
|
|||||||
assert_eq!(state.lock().await.len(), 2);
|
assert_eq!(state.lock().await.len(), 2);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn provider_client_dispatches_anthropic_requests() {
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![http_response(
|
||||||
|
"200 OK",
|
||||||
|
"application/json",
|
||||||
|
"{\"id\":\"msg_provider\",\"type\":\"message\",\"role\":\"assistant\",\"content\":[{\"type\":\"text\",\"text\":\"Dispatched\"}],\"model\":\"claude-3-7-sonnet-latest\",\"stop_reason\":\"end_turn\",\"stop_sequence\":null,\"usage\":{\"input_tokens\":3,\"output_tokens\":2}}",
|
||||||
|
)],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
|
||||||
|
let client = ProviderClient::from_model_with_anthropic_auth(
|
||||||
|
"claude-sonnet-4-6",
|
||||||
|
Some(AuthSource::ApiKey("test-key".to_string())),
|
||||||
|
)
|
||||||
|
.expect("anthropic provider client should be constructed");
|
||||||
|
let client = match client {
|
||||||
|
ProviderClient::Anthropic(client) => {
|
||||||
|
ProviderClient::Anthropic(client.with_base_url(server.base_url()))
|
||||||
|
}
|
||||||
|
other => panic!("expected anthropic provider, got {other:?}"),
|
||||||
|
};
|
||||||
|
|
||||||
|
let response = client
|
||||||
|
.send_message(&sample_request(false))
|
||||||
|
.await
|
||||||
|
.expect("provider-dispatched request should succeed");
|
||||||
|
|
||||||
|
assert_eq!(response.total_tokens(), 5);
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("server should capture request");
|
||||||
|
assert_eq!(request.path, "/v1/messages");
|
||||||
|
assert_eq!(
|
||||||
|
request.headers.get("x-api-key").map(String::as_str),
|
||||||
|
Some("test-key")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn surfaces_retry_exhaustion_for_persistent_retryable_errors() {
|
async fn surfaces_retry_exhaustion_for_persistent_retryable_errors() {
|
||||||
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
@@ -336,7 +256,7 @@ async fn surfaces_retry_exhaustion_for_persistent_retryable_errors() {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
let client = ApiHttpClient::new("test-key")
|
let client = AnthropicClient::new("test-key")
|
||||||
.with_base_url(server.base_url())
|
.with_base_url(server.base_url())
|
||||||
.with_retry_policy(1, Duration::from_millis(1), Duration::from_millis(2));
|
.with_retry_policy(1, Duration::from_millis(1), Duration::from_millis(2));
|
||||||
|
|
||||||
@@ -367,7 +287,7 @@ async fn surfaces_retry_exhaustion_for_persistent_retryable_errors() {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[ignore = "requires ANTHROPIC_API_KEY and network access"]
|
#[ignore = "requires ANTHROPIC_API_KEY and network access"]
|
||||||
async fn live_stream_smoke_test() {
|
async fn live_stream_smoke_test() {
|
||||||
let client = ApiHttpClient::from_env().expect("ANTHROPIC_API_KEY must be set");
|
let client = AnthropicClient::from_env().expect("ANTHROPIC_API_KEY must be set");
|
||||||
let mut stream = client
|
let mut stream = client
|
||||||
.stream_message(&MessageRequest {
|
.stream_message(&MessageRequest {
|
||||||
model: std::env::var("ANTHROPIC_MODEL")
|
model: std::env::var("ANTHROPIC_MODEL")
|
||||||
|
|||||||
415
rust/crates/api/tests/openai_compat_integration.rs
Normal file
415
rust/crates/api/tests/openai_compat_integration.rs
Normal file
@@ -0,0 +1,415 @@
|
|||||||
|
use std::collections::HashMap;
|
||||||
|
use std::ffi::OsString;
|
||||||
|
use std::sync::Arc;
|
||||||
|
use std::sync::{Mutex as StdMutex, OnceLock};
|
||||||
|
|
||||||
|
use api::{
|
||||||
|
ContentBlockDelta, ContentBlockDeltaEvent, ContentBlockStartEvent, ContentBlockStopEvent,
|
||||||
|
InputContentBlock, InputMessage, MessageRequest, OpenAiCompatClient, OpenAiCompatConfig,
|
||||||
|
OutputContentBlock, ProviderClient, StreamEvent, ToolChoice, ToolDefinition,
|
||||||
|
};
|
||||||
|
use serde_json::json;
|
||||||
|
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
||||||
|
use tokio::net::TcpListener;
|
||||||
|
use tokio::sync::Mutex;
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn send_message_uses_openai_compatible_endpoint_and_auth() {
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let body = concat!(
|
||||||
|
"{",
|
||||||
|
"\"id\":\"chatcmpl_test\",",
|
||||||
|
"\"model\":\"grok-3\",",
|
||||||
|
"\"choices\":[{",
|
||||||
|
"\"message\":{\"role\":\"assistant\",\"content\":\"Hello from Grok\",\"tool_calls\":[]},",
|
||||||
|
"\"finish_reason\":\"stop\"",
|
||||||
|
"}],",
|
||||||
|
"\"usage\":{\"prompt_tokens\":11,\"completion_tokens\":5}",
|
||||||
|
"}"
|
||||||
|
);
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![http_response("200 OK", "application/json", body)],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
|
||||||
|
let client = OpenAiCompatClient::new("xai-test-key", OpenAiCompatConfig::xai())
|
||||||
|
.with_base_url(server.base_url());
|
||||||
|
let response = client
|
||||||
|
.send_message(&sample_request(false))
|
||||||
|
.await
|
||||||
|
.expect("request should succeed");
|
||||||
|
|
||||||
|
assert_eq!(response.model, "grok-3");
|
||||||
|
assert_eq!(response.total_tokens(), 16);
|
||||||
|
assert_eq!(
|
||||||
|
response.content,
|
||||||
|
vec![OutputContentBlock::Text {
|
||||||
|
text: "Hello from Grok".to_string(),
|
||||||
|
}]
|
||||||
|
);
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("server should capture request");
|
||||||
|
assert_eq!(request.path, "/chat/completions");
|
||||||
|
assert_eq!(
|
||||||
|
request.headers.get("authorization").map(String::as_str),
|
||||||
|
Some("Bearer xai-test-key")
|
||||||
|
);
|
||||||
|
let body: serde_json::Value = serde_json::from_str(&request.body).expect("json body");
|
||||||
|
assert_eq!(body["model"], json!("grok-3"));
|
||||||
|
assert_eq!(body["messages"][0]["role"], json!("system"));
|
||||||
|
assert_eq!(body["tools"][0]["type"], json!("function"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn send_message_accepts_full_chat_completions_endpoint_override() {
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let body = concat!(
|
||||||
|
"{",
|
||||||
|
"\"id\":\"chatcmpl_full_endpoint\",",
|
||||||
|
"\"model\":\"grok-3\",",
|
||||||
|
"\"choices\":[{",
|
||||||
|
"\"message\":{\"role\":\"assistant\",\"content\":\"Endpoint override works\",\"tool_calls\":[]},",
|
||||||
|
"\"finish_reason\":\"stop\"",
|
||||||
|
"}],",
|
||||||
|
"\"usage\":{\"prompt_tokens\":7,\"completion_tokens\":3}",
|
||||||
|
"}"
|
||||||
|
);
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![http_response("200 OK", "application/json", body)],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
|
||||||
|
let endpoint_url = format!("{}/chat/completions", server.base_url());
|
||||||
|
let client = OpenAiCompatClient::new("xai-test-key", OpenAiCompatConfig::xai())
|
||||||
|
.with_base_url(endpoint_url);
|
||||||
|
let response = client
|
||||||
|
.send_message(&sample_request(false))
|
||||||
|
.await
|
||||||
|
.expect("request should succeed");
|
||||||
|
|
||||||
|
assert_eq!(response.total_tokens(), 10);
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("server should capture request");
|
||||||
|
assert_eq!(request.path, "/chat/completions");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn stream_message_normalizes_text_and_multiple_tool_calls() {
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let sse = concat!(
|
||||||
|
"data: {\"id\":\"chatcmpl_stream\",\"model\":\"grok-3\",\"choices\":[{\"delta\":{\"content\":\"Hello\"}}]}\n\n",
|
||||||
|
"data: {\"id\":\"chatcmpl_stream\",\"choices\":[{\"delta\":{\"tool_calls\":[{\"index\":0,\"id\":\"call_1\",\"function\":{\"name\":\"weather\",\"arguments\":\"{\\\"city\\\":\\\"Paris\\\"}\"}},{\"index\":1,\"id\":\"call_2\",\"function\":{\"name\":\"clock\",\"arguments\":\"{\\\"zone\\\":\\\"UTC\\\"}\"}}]}}]}\n\n",
|
||||||
|
"data: {\"id\":\"chatcmpl_stream\",\"choices\":[{\"delta\":{},\"finish_reason\":\"tool_calls\"}]}\n\n",
|
||||||
|
"data: [DONE]\n\n"
|
||||||
|
);
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![http_response_with_headers(
|
||||||
|
"200 OK",
|
||||||
|
"text/event-stream",
|
||||||
|
sse,
|
||||||
|
&[("x-request-id", "req_grok_stream")],
|
||||||
|
)],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
|
||||||
|
let client = OpenAiCompatClient::new("xai-test-key", OpenAiCompatConfig::xai())
|
||||||
|
.with_base_url(server.base_url());
|
||||||
|
let mut stream = client
|
||||||
|
.stream_message(&sample_request(false))
|
||||||
|
.await
|
||||||
|
.expect("stream should start");
|
||||||
|
|
||||||
|
assert_eq!(stream.request_id(), Some("req_grok_stream"));
|
||||||
|
|
||||||
|
let mut events = Vec::new();
|
||||||
|
while let Some(event) = stream.next_event().await.expect("event should parse") {
|
||||||
|
events.push(event);
|
||||||
|
}
|
||||||
|
|
||||||
|
assert!(matches!(events[0], StreamEvent::MessageStart(_)));
|
||||||
|
assert!(matches!(
|
||||||
|
events[1],
|
||||||
|
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
||||||
|
content_block: OutputContentBlock::Text { .. },
|
||||||
|
..
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[2],
|
||||||
|
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
||||||
|
delta: ContentBlockDelta::TextDelta { .. },
|
||||||
|
..
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[3],
|
||||||
|
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
||||||
|
index: 1,
|
||||||
|
content_block: OutputContentBlock::ToolUse { .. },
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[4],
|
||||||
|
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
||||||
|
index: 1,
|
||||||
|
delta: ContentBlockDelta::InputJsonDelta { .. },
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[5],
|
||||||
|
StreamEvent::ContentBlockStart(ContentBlockStartEvent {
|
||||||
|
index: 2,
|
||||||
|
content_block: OutputContentBlock::ToolUse { .. },
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[6],
|
||||||
|
StreamEvent::ContentBlockDelta(ContentBlockDeltaEvent {
|
||||||
|
index: 2,
|
||||||
|
delta: ContentBlockDelta::InputJsonDelta { .. },
|
||||||
|
})
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[7],
|
||||||
|
StreamEvent::ContentBlockStop(ContentBlockStopEvent { index: 1 })
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[8],
|
||||||
|
StreamEvent::ContentBlockStop(ContentBlockStopEvent { index: 2 })
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
events[9],
|
||||||
|
StreamEvent::ContentBlockStop(ContentBlockStopEvent { index: 0 })
|
||||||
|
));
|
||||||
|
assert!(matches!(events[10], StreamEvent::MessageDelta(_)));
|
||||||
|
assert!(matches!(events[11], StreamEvent::MessageStop(_)));
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("captured request");
|
||||||
|
assert_eq!(request.path, "/chat/completions");
|
||||||
|
assert!(request.body.contains("\"stream\":true"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn provider_client_dispatches_xai_requests_from_env() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _api_key = ScopedEnvVar::set("XAI_API_KEY", "xai-test-key");
|
||||||
|
|
||||||
|
let state = Arc::new(Mutex::new(Vec::<CapturedRequest>::new()));
|
||||||
|
let server = spawn_server(
|
||||||
|
state.clone(),
|
||||||
|
vec![http_response(
|
||||||
|
"200 OK",
|
||||||
|
"application/json",
|
||||||
|
"{\"id\":\"chatcmpl_provider\",\"model\":\"grok-3\",\"choices\":[{\"message\":{\"role\":\"assistant\",\"content\":\"Through provider client\",\"tool_calls\":[]},\"finish_reason\":\"stop\"}],\"usage\":{\"prompt_tokens\":9,\"completion_tokens\":4}}",
|
||||||
|
)],
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
let _base_url = ScopedEnvVar::set("XAI_BASE_URL", server.base_url());
|
||||||
|
|
||||||
|
let client =
|
||||||
|
ProviderClient::from_model("grok").expect("xAI provider client should be constructed");
|
||||||
|
assert!(matches!(client, ProviderClient::Xai(_)));
|
||||||
|
|
||||||
|
let response = client
|
||||||
|
.send_message(&sample_request(false))
|
||||||
|
.await
|
||||||
|
.expect("provider-dispatched request should succeed");
|
||||||
|
|
||||||
|
assert_eq!(response.total_tokens(), 13);
|
||||||
|
|
||||||
|
let captured = state.lock().await;
|
||||||
|
let request = captured.first().expect("captured request");
|
||||||
|
assert_eq!(request.path, "/chat/completions");
|
||||||
|
assert_eq!(
|
||||||
|
request.headers.get("authorization").map(String::as_str),
|
||||||
|
Some("Bearer xai-test-key")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct CapturedRequest {
|
||||||
|
path: String,
|
||||||
|
headers: HashMap<String, String>,
|
||||||
|
body: String,
|
||||||
|
}
|
||||||
|
|
||||||
|
struct TestServer {
|
||||||
|
base_url: String,
|
||||||
|
join_handle: tokio::task::JoinHandle<()>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl TestServer {
|
||||||
|
fn base_url(&self) -> String {
|
||||||
|
self.base_url.clone()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Drop for TestServer {
|
||||||
|
fn drop(&mut self) {
|
||||||
|
self.join_handle.abort();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn spawn_server(
|
||||||
|
state: Arc<Mutex<Vec<CapturedRequest>>>,
|
||||||
|
responses: Vec<String>,
|
||||||
|
) -> TestServer {
|
||||||
|
let listener = TcpListener::bind("127.0.0.1:0")
|
||||||
|
.await
|
||||||
|
.expect("listener should bind");
|
||||||
|
let address = listener.local_addr().expect("listener addr");
|
||||||
|
let join_handle = tokio::spawn(async move {
|
||||||
|
for response in responses {
|
||||||
|
let (mut socket, _) = listener.accept().await.expect("accept");
|
||||||
|
let mut buffer = Vec::new();
|
||||||
|
let mut header_end = None;
|
||||||
|
loop {
|
||||||
|
let mut chunk = [0_u8; 1024];
|
||||||
|
let read = socket.read(&mut chunk).await.expect("read request");
|
||||||
|
if read == 0 {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
buffer.extend_from_slice(&chunk[..read]);
|
||||||
|
if let Some(position) = find_header_end(&buffer) {
|
||||||
|
header_end = Some(position);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let header_end = header_end.expect("headers should exist");
|
||||||
|
let (header_bytes, remaining) = buffer.split_at(header_end);
|
||||||
|
let header_text = String::from_utf8(header_bytes.to_vec()).expect("utf8 headers");
|
||||||
|
let mut lines = header_text.split("\r\n");
|
||||||
|
let request_line = lines.next().expect("request line");
|
||||||
|
let path = request_line
|
||||||
|
.split_whitespace()
|
||||||
|
.nth(1)
|
||||||
|
.expect("path")
|
||||||
|
.to_string();
|
||||||
|
let mut headers = HashMap::new();
|
||||||
|
let mut content_length = 0_usize;
|
||||||
|
for line in lines {
|
||||||
|
if line.is_empty() {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
let (name, value) = line.split_once(':').expect("header");
|
||||||
|
let value = value.trim().to_string();
|
||||||
|
if name.eq_ignore_ascii_case("content-length") {
|
||||||
|
content_length = value.parse().expect("content length");
|
||||||
|
}
|
||||||
|
headers.insert(name.to_ascii_lowercase(), value);
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut body = remaining[4..].to_vec();
|
||||||
|
while body.len() < content_length {
|
||||||
|
let mut chunk = vec![0_u8; content_length - body.len()];
|
||||||
|
let read = socket.read(&mut chunk).await.expect("read body");
|
||||||
|
if read == 0 {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
body.extend_from_slice(&chunk[..read]);
|
||||||
|
}
|
||||||
|
|
||||||
|
state.lock().await.push(CapturedRequest {
|
||||||
|
path,
|
||||||
|
headers,
|
||||||
|
body: String::from_utf8(body).expect("utf8 body"),
|
||||||
|
});
|
||||||
|
|
||||||
|
socket
|
||||||
|
.write_all(response.as_bytes())
|
||||||
|
.await
|
||||||
|
.expect("write response");
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
TestServer {
|
||||||
|
base_url: format!("http://{address}"),
|
||||||
|
join_handle,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn find_header_end(bytes: &[u8]) -> Option<usize> {
|
||||||
|
bytes.windows(4).position(|window| window == b"\r\n\r\n")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn http_response(status: &str, content_type: &str, body: &str) -> String {
|
||||||
|
http_response_with_headers(status, content_type, body, &[])
|
||||||
|
}
|
||||||
|
|
||||||
|
fn http_response_with_headers(
|
||||||
|
status: &str,
|
||||||
|
content_type: &str,
|
||||||
|
body: &str,
|
||||||
|
headers: &[(&str, &str)],
|
||||||
|
) -> String {
|
||||||
|
let mut extra_headers = String::new();
|
||||||
|
for (name, value) in headers {
|
||||||
|
use std::fmt::Write as _;
|
||||||
|
write!(&mut extra_headers, "{name}: {value}\r\n").expect("header write");
|
||||||
|
}
|
||||||
|
format!(
|
||||||
|
"HTTP/1.1 {status}\r\ncontent-type: {content_type}\r\n{extra_headers}content-length: {}\r\nconnection: close\r\n\r\n{body}",
|
||||||
|
body.len()
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn sample_request(stream: bool) -> MessageRequest {
|
||||||
|
MessageRequest {
|
||||||
|
model: "grok-3".to_string(),
|
||||||
|
max_tokens: 64,
|
||||||
|
messages: vec![InputMessage {
|
||||||
|
role: "user".to_string(),
|
||||||
|
content: vec![InputContentBlock::Text {
|
||||||
|
text: "Say hello".to_string(),
|
||||||
|
}],
|
||||||
|
}],
|
||||||
|
system: Some("Use tools when needed".to_string()),
|
||||||
|
tools: Some(vec![ToolDefinition {
|
||||||
|
name: "weather".to_string(),
|
||||||
|
description: Some("Fetches weather".to_string()),
|
||||||
|
input_schema: json!({
|
||||||
|
"type": "object",
|
||||||
|
"properties": {"city": {"type": "string"}},
|
||||||
|
"required": ["city"]
|
||||||
|
}),
|
||||||
|
}]),
|
||||||
|
tool_choice: Some(ToolChoice::Auto),
|
||||||
|
stream,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn env_lock() -> std::sync::MutexGuard<'static, ()> {
|
||||||
|
static LOCK: OnceLock<StdMutex<()>> = OnceLock::new();
|
||||||
|
LOCK.get_or_init(|| StdMutex::new(()))
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(|poisoned| poisoned.into_inner())
|
||||||
|
}
|
||||||
|
|
||||||
|
struct ScopedEnvVar {
|
||||||
|
key: &'static str,
|
||||||
|
previous: Option<OsString>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ScopedEnvVar {
|
||||||
|
fn set(key: &'static str, value: impl AsRef<std::ffi::OsStr>) -> Self {
|
||||||
|
let previous = std::env::var_os(key);
|
||||||
|
std::env::set_var(key, value);
|
||||||
|
Self { key, previous }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Drop for ScopedEnvVar {
|
||||||
|
fn drop(&mut self) {
|
||||||
|
match &self.previous {
|
||||||
|
Some(value) => std::env::set_var(self.key, value),
|
||||||
|
None => std::env::remove_var(self.key),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
86
rust/crates/api/tests/provider_client_integration.rs
Normal file
86
rust/crates/api/tests/provider_client_integration.rs
Normal file
@@ -0,0 +1,86 @@
|
|||||||
|
use std::ffi::OsString;
|
||||||
|
use std::sync::{Mutex, OnceLock};
|
||||||
|
|
||||||
|
use api::{read_xai_base_url, ApiError, AuthSource, ProviderClient, ProviderKind};
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn provider_client_routes_grok_aliases_through_xai() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _xai_api_key = EnvVarGuard::set("XAI_API_KEY", Some("xai-test-key"));
|
||||||
|
|
||||||
|
let client = ProviderClient::from_model("grok-mini").expect("grok alias should resolve");
|
||||||
|
|
||||||
|
assert_eq!(client.provider_kind(), ProviderKind::Xai);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn provider_client_reports_missing_xai_credentials_for_grok_models() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _xai_api_key = EnvVarGuard::set("XAI_API_KEY", None);
|
||||||
|
|
||||||
|
let error = ProviderClient::from_model("grok-3")
|
||||||
|
.expect_err("grok requests without XAI_API_KEY should fail fast");
|
||||||
|
|
||||||
|
match error {
|
||||||
|
ApiError::MissingCredentials { provider, env_vars } => {
|
||||||
|
assert_eq!(provider, "xAI");
|
||||||
|
assert_eq!(env_vars, &["XAI_API_KEY"]);
|
||||||
|
}
|
||||||
|
other => panic!("expected missing xAI credentials, got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn provider_client_uses_explicit_anthropic_auth_without_env_lookup() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _anthropic_api_key = EnvVarGuard::set("ANTHROPIC_API_KEY", None);
|
||||||
|
let _anthropic_auth_token = EnvVarGuard::set("ANTHROPIC_AUTH_TOKEN", None);
|
||||||
|
|
||||||
|
let client = ProviderClient::from_model_with_anthropic_auth(
|
||||||
|
"claude-sonnet-4-6",
|
||||||
|
Some(AuthSource::ApiKey("anthropic-test-key".to_string())),
|
||||||
|
)
|
||||||
|
.expect("explicit anthropic auth should avoid env lookup");
|
||||||
|
|
||||||
|
assert_eq!(client.provider_kind(), ProviderKind::Anthropic);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn read_xai_base_url_prefers_env_override() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _xai_base_url = EnvVarGuard::set("XAI_BASE_URL", Some("https://example.xai.test/v1"));
|
||||||
|
|
||||||
|
assert_eq!(read_xai_base_url(), "https://example.xai.test/v1");
|
||||||
|
}
|
||||||
|
|
||||||
|
fn env_lock() -> std::sync::MutexGuard<'static, ()> {
|
||||||
|
static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
|
||||||
|
LOCK.get_or_init(|| Mutex::new(()))
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(|poisoned| poisoned.into_inner())
|
||||||
|
}
|
||||||
|
|
||||||
|
struct EnvVarGuard {
|
||||||
|
key: &'static str,
|
||||||
|
original: Option<OsString>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl EnvVarGuard {
|
||||||
|
fn set(key: &'static str, value: Option<&str>) -> Self {
|
||||||
|
let original = std::env::var_os(key);
|
||||||
|
match value {
|
||||||
|
Some(value) => std::env::set_var(key, value),
|
||||||
|
None => std::env::remove_var(key),
|
||||||
|
}
|
||||||
|
Self { key, original }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Drop for EnvVarGuard {
|
||||||
|
fn drop(&mut self) {
|
||||||
|
match &self.original {
|
||||||
|
Some(value) => std::env::set_var(self.key, value),
|
||||||
|
None => std::env::remove_var(self.key),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,20 +1,15 @@
|
|||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
use std::fmt::{Display, Formatter};
|
use std::fmt::{Display, Formatter};
|
||||||
|
|
||||||
use plugins::{HookRunner as PluginHookRunner, PluginRegistry};
|
|
||||||
|
|
||||||
use crate::compact::{
|
use crate::compact::{
|
||||||
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
||||||
};
|
};
|
||||||
use crate::config::RuntimeFeatureConfig;
|
use crate::config::RuntimeFeatureConfig;
|
||||||
use crate::hooks::HookRunner;
|
use crate::hooks::{HookRunResult, HookRunner};
|
||||||
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
||||||
use crate::session::{ContentBlock, ConversationMessage, Session};
|
use crate::session::{ContentBlock, ConversationMessage, Session};
|
||||||
use crate::usage::{TokenUsage, UsageTracker};
|
use crate::usage::{TokenUsage, UsageTracker};
|
||||||
|
|
||||||
const DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD: u32 = 200_000;
|
|
||||||
const AUTO_COMPACTION_THRESHOLD_ENV_VAR: &str = "CLAUDE_CODE_AUTO_COMPACT_INPUT_TOKENS";
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
pub struct ApiRequest {
|
pub struct ApiRequest {
|
||||||
pub system_prompt: Vec<String>,
|
pub system_prompt: Vec<String>,
|
||||||
@@ -91,12 +86,6 @@ pub struct TurnSummary {
|
|||||||
pub tool_results: Vec<ConversationMessage>,
|
pub tool_results: Vec<ConversationMessage>,
|
||||||
pub iterations: usize,
|
pub iterations: usize,
|
||||||
pub usage: TokenUsage,
|
pub usage: TokenUsage,
|
||||||
pub auto_compaction: Option<AutoCompactionEvent>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
|
||||||
pub struct AutoCompactionEvent {
|
|
||||||
pub removed_message_count: usize,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct ConversationRuntime<C, T> {
|
pub struct ConversationRuntime<C, T> {
|
||||||
@@ -108,25 +97,6 @@ pub struct ConversationRuntime<C, T> {
|
|||||||
max_iterations: usize,
|
max_iterations: usize,
|
||||||
usage_tracker: UsageTracker,
|
usage_tracker: UsageTracker,
|
||||||
hook_runner: HookRunner,
|
hook_runner: HookRunner,
|
||||||
auto_compaction_input_tokens_threshold: u32,
|
|
||||||
plugin_hook_runner: Option<PluginHookRunner>,
|
|
||||||
plugin_registry: Option<PluginRegistry>,
|
|
||||||
plugins_shutdown: bool,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T> {
|
|
||||||
fn shutdown_registered_plugins(&mut self) -> Result<(), RuntimeError> {
|
|
||||||
if self.plugins_shutdown {
|
|
||||||
return Ok(());
|
|
||||||
}
|
|
||||||
if let Some(registry) = &self.plugin_registry {
|
|
||||||
registry
|
|
||||||
.shutdown()
|
|
||||||
.map_err(|error| RuntimeError::new(format!("plugin shutdown failed: {error}")))?;
|
|
||||||
}
|
|
||||||
self.plugins_shutdown = true;
|
|
||||||
Ok(())
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T>
|
impl<C, T> ConversationRuntime<C, T>
|
||||||
@@ -148,19 +118,18 @@ where
|
|||||||
tool_executor,
|
tool_executor,
|
||||||
permission_policy,
|
permission_policy,
|
||||||
system_prompt,
|
system_prompt,
|
||||||
RuntimeFeatureConfig::default(),
|
&RuntimeFeatureConfig::default(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
#[allow(clippy::needless_pass_by_value)]
|
|
||||||
pub fn new_with_features(
|
pub fn new_with_features(
|
||||||
session: Session,
|
session: Session,
|
||||||
api_client: C,
|
api_client: C,
|
||||||
tool_executor: T,
|
tool_executor: T,
|
||||||
permission_policy: PermissionPolicy,
|
permission_policy: PermissionPolicy,
|
||||||
system_prompt: Vec<String>,
|
system_prompt: Vec<String>,
|
||||||
feature_config: RuntimeFeatureConfig,
|
feature_config: &RuntimeFeatureConfig,
|
||||||
) -> Self {
|
) -> Self {
|
||||||
let usage_tracker = UsageTracker::from_session(&session);
|
let usage_tracker = UsageTracker::from_session(&session);
|
||||||
Self {
|
Self {
|
||||||
@@ -171,57 +140,16 @@ where
|
|||||||
system_prompt,
|
system_prompt,
|
||||||
max_iterations: usize::MAX,
|
max_iterations: usize::MAX,
|
||||||
usage_tracker,
|
usage_tracker,
|
||||||
hook_runner: HookRunner::from_feature_config(&feature_config),
|
hook_runner: HookRunner::from_feature_config(feature_config),
|
||||||
auto_compaction_input_tokens_threshold: auto_compaction_threshold_from_env(),
|
|
||||||
plugin_hook_runner: None,
|
|
||||||
plugin_registry: None,
|
|
||||||
plugins_shutdown: false,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::needless_pass_by_value)]
|
|
||||||
pub fn new_with_plugins(
|
|
||||||
session: Session,
|
|
||||||
api_client: C,
|
|
||||||
tool_executor: T,
|
|
||||||
permission_policy: PermissionPolicy,
|
|
||||||
system_prompt: Vec<String>,
|
|
||||||
feature_config: RuntimeFeatureConfig,
|
|
||||||
plugin_registry: PluginRegistry,
|
|
||||||
) -> Result<Self, RuntimeError> {
|
|
||||||
let plugin_hook_runner =
|
|
||||||
PluginHookRunner::from_registry(&plugin_registry).map_err(|error| {
|
|
||||||
RuntimeError::new(format!("plugin hook registration failed: {error}"))
|
|
||||||
})?;
|
|
||||||
plugin_registry
|
|
||||||
.initialize()
|
|
||||||
.map_err(|error| RuntimeError::new(format!("plugin initialization failed: {error}")))?;
|
|
||||||
let mut runtime = Self::new_with_features(
|
|
||||||
session,
|
|
||||||
api_client,
|
|
||||||
tool_executor,
|
|
||||||
permission_policy,
|
|
||||||
system_prompt,
|
|
||||||
feature_config,
|
|
||||||
);
|
|
||||||
runtime.plugin_hook_runner = Some(plugin_hook_runner);
|
|
||||||
runtime.plugin_registry = Some(plugin_registry);
|
|
||||||
Ok(runtime)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn with_max_iterations(mut self, max_iterations: usize) -> Self {
|
pub fn with_max_iterations(mut self, max_iterations: usize) -> Self {
|
||||||
self.max_iterations = max_iterations;
|
self.max_iterations = max_iterations;
|
||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn with_auto_compaction_input_tokens_threshold(mut self, threshold: u32) -> Self {
|
|
||||||
self.auto_compaction_input_tokens_threshold = threshold;
|
|
||||||
self
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::too_many_lines)]
|
|
||||||
pub fn run_turn(
|
pub fn run_turn(
|
||||||
&mut self,
|
&mut self,
|
||||||
user_input: impl Into<String>,
|
user_input: impl Into<String>,
|
||||||
@@ -234,7 +162,6 @@ where
|
|||||||
let mut assistant_messages = Vec::new();
|
let mut assistant_messages = Vec::new();
|
||||||
let mut tool_results = Vec::new();
|
let mut tool_results = Vec::new();
|
||||||
let mut iterations = 0;
|
let mut iterations = 0;
|
||||||
let mut max_turn_input_tokens = 0;
|
|
||||||
|
|
||||||
loop {
|
loop {
|
||||||
iterations += 1;
|
iterations += 1;
|
||||||
@@ -251,7 +178,6 @@ where
|
|||||||
let events = self.api_client.stream(request)?;
|
let events = self.api_client.stream(request)?;
|
||||||
let (assistant_message, usage) = build_assistant_message(events)?;
|
let (assistant_message, usage) = build_assistant_message(events)?;
|
||||||
if let Some(usage) = usage {
|
if let Some(usage) = usage {
|
||||||
max_turn_input_tokens = max_turn_input_tokens.max(usage.input_tokens);
|
|
||||||
self.usage_tracker.record(usage);
|
self.usage_tracker.record(usage);
|
||||||
}
|
}
|
||||||
let pending_tool_uses = assistant_message
|
let pending_tool_uses = assistant_message
|
||||||
@@ -288,74 +214,35 @@ where
|
|||||||
ConversationMessage::tool_result(
|
ConversationMessage::tool_result(
|
||||||
tool_use_id,
|
tool_use_id,
|
||||||
tool_name,
|
tool_name,
|
||||||
format_hook_message(pre_hook_result.messages(), &deny_message),
|
format_hook_message(&pre_hook_result, &deny_message),
|
||||||
true,
|
true,
|
||||||
)
|
)
|
||||||
} else {
|
} else {
|
||||||
let plugin_pre_hook_result =
|
let (mut output, mut is_error) =
|
||||||
self.run_plugin_pre_tool_use(&tool_name, &input);
|
match self.tool_executor.execute(&tool_name, &input) {
|
||||||
if plugin_pre_hook_result.is_denied() {
|
Ok(output) => (output, false),
|
||||||
let deny_message =
|
Err(error) => (error.to_string(), true),
|
||||||
format!("PreToolUse hook denied tool `{tool_name}`");
|
};
|
||||||
let mut messages = pre_hook_result.messages().to_vec();
|
output = merge_hook_feedback(pre_hook_result.messages(), output, false);
|
||||||
messages.extend(plugin_pre_hook_result.messages().iter().cloned());
|
|
||||||
ConversationMessage::tool_result(
|
|
||||||
tool_use_id,
|
|
||||||
tool_name,
|
|
||||||
format_hook_message(&messages, &deny_message),
|
|
||||||
true,
|
|
||||||
)
|
|
||||||
} else {
|
|
||||||
let (mut output, mut is_error) =
|
|
||||||
match self.tool_executor.execute(&tool_name, &input) {
|
|
||||||
Ok(output) => (output, false),
|
|
||||||
Err(error) => (error.to_string(), true),
|
|
||||||
};
|
|
||||||
output =
|
|
||||||
merge_hook_feedback(pre_hook_result.messages(), output, false);
|
|
||||||
output = merge_hook_feedback(
|
|
||||||
plugin_pre_hook_result.messages(),
|
|
||||||
output,
|
|
||||||
false,
|
|
||||||
);
|
|
||||||
|
|
||||||
let hook_output = output.clone();
|
let post_hook_result = self
|
||||||
let post_hook_result = self.hook_runner.run_post_tool_use(
|
.hook_runner
|
||||||
&tool_name,
|
.run_post_tool_use(&tool_name, &input, &output, is_error);
|
||||||
&input,
|
if post_hook_result.is_denied() {
|
||||||
&hook_output,
|
is_error = true;
|
||||||
is_error,
|
|
||||||
);
|
|
||||||
let plugin_post_hook_result = self.run_plugin_post_tool_use(
|
|
||||||
&tool_name,
|
|
||||||
&input,
|
|
||||||
&hook_output,
|
|
||||||
is_error,
|
|
||||||
);
|
|
||||||
if post_hook_result.is_denied() {
|
|
||||||
is_error = true;
|
|
||||||
}
|
|
||||||
if plugin_post_hook_result.is_denied() {
|
|
||||||
is_error = true;
|
|
||||||
}
|
|
||||||
output = merge_hook_feedback(
|
|
||||||
post_hook_result.messages(),
|
|
||||||
output,
|
|
||||||
post_hook_result.is_denied(),
|
|
||||||
);
|
|
||||||
output = merge_hook_feedback(
|
|
||||||
plugin_post_hook_result.messages(),
|
|
||||||
output,
|
|
||||||
plugin_post_hook_result.is_denied(),
|
|
||||||
);
|
|
||||||
|
|
||||||
ConversationMessage::tool_result(
|
|
||||||
tool_use_id,
|
|
||||||
tool_name,
|
|
||||||
output,
|
|
||||||
is_error,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
output = merge_hook_feedback(
|
||||||
|
post_hook_result.messages(),
|
||||||
|
output,
|
||||||
|
post_hook_result.is_denied(),
|
||||||
|
);
|
||||||
|
|
||||||
|
ConversationMessage::tool_result(
|
||||||
|
tool_use_id,
|
||||||
|
tool_name,
|
||||||
|
output,
|
||||||
|
is_error,
|
||||||
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PermissionOutcome::Deny { reason } => {
|
PermissionOutcome::Deny { reason } => {
|
||||||
@@ -367,14 +254,11 @@ where
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let auto_compaction = self.maybe_auto_compact(max_turn_input_tokens);
|
|
||||||
|
|
||||||
Ok(TurnSummary {
|
Ok(TurnSummary {
|
||||||
assistant_messages,
|
assistant_messages,
|
||||||
tool_results,
|
tool_results,
|
||||||
iterations,
|
iterations,
|
||||||
usage: self.usage_tracker.cumulative_usage(),
|
usage: self.usage_tracker.cumulative_usage(),
|
||||||
auto_compaction,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -399,81 +283,9 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn into_session(mut self) -> Session {
|
pub fn into_session(self) -> Session {
|
||||||
let _ = self.shutdown_registered_plugins();
|
self.session
|
||||||
std::mem::take(&mut self.session)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn shutdown_plugins(&mut self) -> Result<(), RuntimeError> {
|
|
||||||
self.shutdown_registered_plugins()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn run_plugin_pre_tool_use(&self, tool_name: &str, input: &str) -> plugins::HookRunResult {
|
|
||||||
self.plugin_hook_runner.as_ref().map_or_else(
|
|
||||||
|| plugins::HookRunResult::allow(Vec::new()),
|
|
||||||
|runner| runner.run_pre_tool_use(tool_name, input),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn run_plugin_post_tool_use(
|
|
||||||
&self,
|
|
||||||
tool_name: &str,
|
|
||||||
input: &str,
|
|
||||||
output: &str,
|
|
||||||
is_error: bool,
|
|
||||||
) -> plugins::HookRunResult {
|
|
||||||
self.plugin_hook_runner.as_ref().map_or_else(
|
|
||||||
|| plugins::HookRunResult::allow(Vec::new()),
|
|
||||||
|runner| runner.run_post_tool_use(tool_name, input, output, is_error),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn maybe_auto_compact(&mut self, turn_input_tokens: u32) -> Option<AutoCompactionEvent> {
|
|
||||||
if turn_input_tokens < self.auto_compaction_input_tokens_threshold {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
let result = compact_session(
|
|
||||||
&self.session,
|
|
||||||
CompactionConfig {
|
|
||||||
max_estimated_tokens: usize::try_from(self.auto_compaction_input_tokens_threshold)
|
|
||||||
.unwrap_or(usize::MAX),
|
|
||||||
..CompactionConfig::default()
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
if result.removed_message_count == 0 {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
self.session = result.compacted_session;
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: result.removed_message_count,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl<C, T> Drop for ConversationRuntime<C, T> {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
let _ = self.shutdown_registered_plugins();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn auto_compaction_threshold_from_env() -> u32 {
|
|
||||||
parse_auto_compaction_threshold(
|
|
||||||
std::env::var(AUTO_COMPACTION_THRESHOLD_ENV_VAR)
|
|
||||||
.ok()
|
|
||||||
.as_deref(),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
fn parse_auto_compaction_threshold(value: Option<&str>) -> u32 {
|
|
||||||
value
|
|
||||||
.and_then(|raw| raw.trim().parse::<u32>().ok())
|
|
||||||
.filter(|threshold| *threshold > 0)
|
|
||||||
.unwrap_or(DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn build_assistant_message(
|
fn build_assistant_message(
|
||||||
@@ -523,11 +335,11 @@ fn flush_text_block(text: &mut String, blocks: &mut Vec<ContentBlock>) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn format_hook_message(messages: &[String], fallback: &str) -> String {
|
fn format_hook_message(result: &HookRunResult, fallback: &str) -> String {
|
||||||
if messages.is_empty() {
|
if result.messages().is_empty() {
|
||||||
fallback.to_string()
|
fallback.to_string()
|
||||||
} else {
|
} else {
|
||||||
messages.join("\n")
|
result.messages().join("\n")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -584,9 +396,8 @@ impl ToolExecutor for StaticToolExecutor {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
parse_auto_compaction_threshold, ApiClient, ApiRequest, AssistantEvent,
|
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError,
|
||||||
AutoCompactionEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
StaticToolExecutor,
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD,
|
|
||||||
};
|
};
|
||||||
use crate::compact::CompactionConfig;
|
use crate::compact::CompactionConfig;
|
||||||
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
@@ -597,13 +408,7 @@ mod tests {
|
|||||||
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
||||||
use crate::session::{ContentBlock, MessageRole, Session};
|
use crate::session::{ContentBlock, MessageRole, Session};
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
use plugins::{PluginManager, PluginManagerConfig};
|
|
||||||
use std::fs;
|
|
||||||
#[cfg(unix)]
|
|
||||||
use std::os::unix::fs::PermissionsExt;
|
|
||||||
use std::path::Path;
|
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
|
||||||
|
|
||||||
struct ScriptedApiClient {
|
struct ScriptedApiClient {
|
||||||
call_count: usize,
|
call_count: usize,
|
||||||
@@ -665,68 +470,6 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn temp_dir(label: &str) -> PathBuf {
|
|
||||||
let nanos = SystemTime::now()
|
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.expect("time should be after epoch")
|
|
||||||
.as_nanos();
|
|
||||||
std::env::temp_dir().join(format!("runtime-plugin-{label}-{nanos}"))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn write_lifecycle_plugin(root: &Path, name: &str) -> PathBuf {
|
|
||||||
fs::create_dir_all(root.join(".claude-plugin")).expect("manifest dir");
|
|
||||||
fs::create_dir_all(root.join("lifecycle")).expect("lifecycle dir");
|
|
||||||
let log_path = root.join("lifecycle.log");
|
|
||||||
fs::write(
|
|
||||||
root.join("lifecycle").join("init.sh"),
|
|
||||||
"#!/bin/sh\nprintf 'init\\n' >> lifecycle.log\n",
|
|
||||||
)
|
|
||||||
.expect("write init script");
|
|
||||||
fs::write(
|
|
||||||
root.join("lifecycle").join("shutdown.sh"),
|
|
||||||
"#!/bin/sh\nprintf 'shutdown\\n' >> lifecycle.log\n",
|
|
||||||
)
|
|
||||||
.expect("write shutdown script");
|
|
||||||
fs::write(
|
|
||||||
root.join(".claude-plugin").join("plugin.json"),
|
|
||||||
format!(
|
|
||||||
"{{\n \"name\": \"{name}\",\n \"version\": \"1.0.0\",\n \"description\": \"runtime lifecycle plugin\",\n \"lifecycle\": {{\n \"Init\": [\"./lifecycle/init.sh\"],\n \"Shutdown\": [\"./lifecycle/shutdown.sh\"]\n }}\n}}"
|
|
||||||
),
|
|
||||||
)
|
|
||||||
.expect("write plugin manifest");
|
|
||||||
log_path
|
|
||||||
}
|
|
||||||
|
|
||||||
fn write_hook_plugin(root: &Path, name: &str, pre_message: &str, post_message: &str) {
|
|
||||||
fs::create_dir_all(root.join(".claude-plugin")).expect("manifest dir");
|
|
||||||
fs::create_dir_all(root.join("hooks")).expect("hooks dir");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("pre.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{pre_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write pre hook");
|
|
||||||
fs::write(
|
|
||||||
root.join("hooks").join("post.sh"),
|
|
||||||
format!("#!/bin/sh\nprintf '%s\\n' '{post_message}'\n"),
|
|
||||||
)
|
|
||||||
.expect("write post hook");
|
|
||||||
#[cfg(unix)]
|
|
||||||
{
|
|
||||||
let exec_mode = fs::Permissions::from_mode(0o755);
|
|
||||||
fs::set_permissions(root.join("hooks").join("pre.sh"), exec_mode.clone())
|
|
||||||
.expect("chmod pre hook");
|
|
||||||
fs::set_permissions(root.join("hooks").join("post.sh"), exec_mode)
|
|
||||||
.expect("chmod post hook");
|
|
||||||
}
|
|
||||||
fs::write(
|
|
||||||
root.join(".claude-plugin").join("plugin.json"),
|
|
||||||
format!(
|
|
||||||
"{{\n \"name\": \"{name}\",\n \"version\": \"1.0.0\",\n \"description\": \"runtime hook plugin\",\n \"hooks\": {{\n \"PreToolUse\": [\"./hooks/pre.sh\"],\n \"PostToolUse\": [\"./hooks/post.sh\"]\n }}\n}}"
|
|
||||||
),
|
|
||||||
)
|
|
||||||
.expect("write plugin manifest");
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn runs_user_to_tool_to_result_loop_end_to_end_and_tracks_usage() {
|
fn runs_user_to_tool_to_result_loop_end_to_end_and_tracks_usage() {
|
||||||
let api_client = ScriptedApiClient { call_count: 0 };
|
let api_client = ScriptedApiClient { call_count: 0 };
|
||||||
@@ -765,7 +508,6 @@ mod tests {
|
|||||||
assert_eq!(summary.tool_results.len(), 1);
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
assert_eq!(runtime.session().messages.len(), 4);
|
assert_eq!(runtime.session().messages.len(), 4);
|
||||||
assert_eq!(summary.usage.output_tokens, 10);
|
assert_eq!(summary.usage.output_tokens, 10);
|
||||||
assert_eq!(summary.auto_compaction, None);
|
|
||||||
assert!(matches!(
|
assert!(matches!(
|
||||||
runtime.session().messages[1].blocks[1],
|
runtime.session().messages[1].blocks[1],
|
||||||
ContentBlock::ToolUse { .. }
|
ContentBlock::ToolUse { .. }
|
||||||
@@ -867,7 +609,7 @@ mod tests {
|
|||||||
}),
|
}),
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
vec!["system".to_string()],
|
vec!["system".to_string()],
|
||||||
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
&RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
||||||
Vec::new(),
|
Vec::new(),
|
||||||
)),
|
)),
|
||||||
@@ -933,7 +675,7 @@ mod tests {
|
|||||||
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
vec!["system".to_string()],
|
vec!["system".to_string()],
|
||||||
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
&RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
vec![shell_snippet("printf 'pre hook ran'")],
|
vec![shell_snippet("printf 'pre hook ran'")],
|
||||||
vec![shell_snippet("printf 'post hook ran'")],
|
vec![shell_snippet("printf 'post hook ran'")],
|
||||||
)),
|
)),
|
||||||
@@ -968,153 +710,6 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn initializes_and_shuts_down_plugins_with_runtime_lifecycle() {
|
|
||||||
let config_home = temp_dir("config");
|
|
||||||
let source_root = temp_dir("source");
|
|
||||||
let _ = write_lifecycle_plugin(&source_root, "runtime-lifecycle");
|
|
||||||
|
|
||||||
let mut manager = PluginManager::new(PluginManagerConfig::new(&config_home));
|
|
||||||
let install = manager
|
|
||||||
.install(source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("install should succeed");
|
|
||||||
let log_path = install.install_path.join("lifecycle.log");
|
|
||||||
let registry = manager.plugin_registry().expect("registry should load");
|
|
||||||
|
|
||||||
{
|
|
||||||
let runtime = ConversationRuntime::new_with_plugins(
|
|
||||||
Session::new(),
|
|
||||||
ScriptedApiClient { call_count: 0 },
|
|
||||||
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
|
||||||
PermissionPolicy::new(PermissionMode::WorkspaceWrite),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
RuntimeFeatureConfig::default(),
|
|
||||||
registry,
|
|
||||||
)
|
|
||||||
.expect("runtime should initialize plugins");
|
|
||||||
|
|
||||||
let log = fs::read_to_string(&log_path).expect("init log should exist");
|
|
||||||
assert_eq!(log, "init\n");
|
|
||||||
drop(runtime);
|
|
||||||
}
|
|
||||||
|
|
||||||
let log = fs::read_to_string(&log_path).expect("shutdown log should exist");
|
|
||||||
assert_eq!(log, "init\nshutdown\n");
|
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(config_home);
|
|
||||||
let _ = fs::remove_dir_all(source_root);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn executes_hooks_from_installed_plugins_during_tool_use() {
|
|
||||||
struct TwoCallApiClient {
|
|
||||||
calls: usize,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl ApiClient for TwoCallApiClient {
|
|
||||||
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
self.calls += 1;
|
|
||||||
match self.calls {
|
|
||||||
1 => Ok(vec![
|
|
||||||
AssistantEvent::ToolUse {
|
|
||||||
id: "tool-1".to_string(),
|
|
||||||
name: "add".to_string(),
|
|
||||||
input: r#"{"lhs":2,"rhs":2}"#.to_string(),
|
|
||||||
},
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
]),
|
|
||||||
2 => {
|
|
||||||
assert!(request
|
|
||||||
.messages
|
|
||||||
.iter()
|
|
||||||
.any(|message| message.role == MessageRole::Tool));
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
_ => Err(RuntimeError::new("unexpected extra API call")),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let config_home = temp_dir("hook-config");
|
|
||||||
let first_source_root = temp_dir("hook-source-a");
|
|
||||||
let second_source_root = temp_dir("hook-source-b");
|
|
||||||
write_hook_plugin(
|
|
||||||
&first_source_root,
|
|
||||||
"first",
|
|
||||||
"plugin pre one",
|
|
||||||
"plugin post one",
|
|
||||||
);
|
|
||||||
write_hook_plugin(
|
|
||||||
&second_source_root,
|
|
||||||
"second",
|
|
||||||
"plugin pre two",
|
|
||||||
"plugin post two",
|
|
||||||
);
|
|
||||||
|
|
||||||
let mut manager = PluginManager::new(PluginManagerConfig::new(&config_home));
|
|
||||||
manager
|
|
||||||
.install(first_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("first plugin install should succeed");
|
|
||||||
manager
|
|
||||||
.install(second_source_root.to_str().expect("utf8 path"))
|
|
||||||
.expect("second plugin install should succeed");
|
|
||||||
let registry = manager.plugin_registry().expect("registry should load");
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new_with_plugins(
|
|
||||||
Session::new(),
|
|
||||||
TwoCallApiClient { calls: 0 },
|
|
||||||
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
RuntimeFeatureConfig::default(),
|
|
||||||
registry,
|
|
||||||
)
|
|
||||||
.expect("runtime should load plugin hooks");
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("use add", None)
|
|
||||||
.expect("tool loop succeeds");
|
|
||||||
|
|
||||||
assert_eq!(summary.tool_results.len(), 1);
|
|
||||||
let ContentBlock::ToolResult {
|
|
||||||
is_error, output, ..
|
|
||||||
} = &summary.tool_results[0].blocks[0]
|
|
||||||
else {
|
|
||||||
panic!("expected tool result block");
|
|
||||||
};
|
|
||||||
assert!(
|
|
||||||
!*is_error,
|
|
||||||
"plugin hooks should not force an error: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains('4'),
|
|
||||||
"tool output missing value: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin pre one"),
|
|
||||||
"tool output missing first pre hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin pre two"),
|
|
||||||
"tool output missing second pre hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin post one"),
|
|
||||||
"tool output missing first post hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
output.contains("plugin post two"),
|
|
||||||
"tool output missing second post hook feedback: {output:?}"
|
|
||||||
);
|
|
||||||
|
|
||||||
let _ = fs::remove_dir_all(config_home);
|
|
||||||
let _ = fs::remove_dir_all(first_source_root);
|
|
||||||
let _ = fs::remove_dir_all(second_source_root);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_tracker_from_restored_session() {
|
fn reconstructs_usage_tracker_from_restored_session() {
|
||||||
struct SimpleApi;
|
struct SimpleApi;
|
||||||
@@ -1203,177 +798,4 @@ mod tests {
|
|||||||
fn shell_snippet(script: &str) -> String {
|
fn shell_snippet(script: &str) -> String {
|
||||||
script.to_string()
|
script.to_string()
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compacts_when_turn_input_threshold_is_crossed() {
|
|
||||||
struct SimpleApi;
|
|
||||||
impl ApiClient for SimpleApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens: 120_000,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
crate::session::ConversationMessage::user_text("one ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "two ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
crate::session::ConversationMessage::user_text("three ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "four ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
session,
|
|
||||||
SimpleApi,
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("turn should succeed");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
summary.auto_compaction,
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: 2,
|
|
||||||
})
|
|
||||||
);
|
|
||||||
assert_eq!(runtime.session().messages[0].role, MessageRole::System);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compaction_does_not_repeat_after_context_is_already_compacted() {
|
|
||||||
struct SequentialUsageApi {
|
|
||||||
call_count: usize,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl ApiClient for SequentialUsageApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
self.call_count += 1;
|
|
||||||
let input_tokens = if self.call_count == 1 { 120_000 } else { 64 };
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let session = Session {
|
|
||||||
version: 1,
|
|
||||||
messages: vec![
|
|
||||||
crate::session::ConversationMessage::user_text("one ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "two ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
crate::session::ConversationMessage::user_text("three ".repeat(30_000)),
|
|
||||||
crate::session::ConversationMessage::assistant(vec![ContentBlock::Text {
|
|
||||||
text: "four ".repeat(30_000),
|
|
||||||
}]),
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
session,
|
|
||||||
SequentialUsageApi { call_count: 0 },
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let first = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("first turn should succeed");
|
|
||||||
assert_eq!(
|
|
||||||
first.auto_compaction,
|
|
||||||
Some(AutoCompactionEvent {
|
|
||||||
removed_message_count: 2,
|
|
||||||
})
|
|
||||||
);
|
|
||||||
|
|
||||||
let second = runtime
|
|
||||||
.run_turn("continue", None)
|
|
||||||
.expect("second turn should succeed");
|
|
||||||
assert_eq!(second.auto_compaction, None);
|
|
||||||
assert_eq!(runtime.session().messages[0].role, MessageRole::System);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn skips_auto_compaction_below_threshold() {
|
|
||||||
struct SimpleApi;
|
|
||||||
impl ApiClient for SimpleApi {
|
|
||||||
fn stream(
|
|
||||||
&mut self,
|
|
||||||
_request: ApiRequest,
|
|
||||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
|
||||||
Ok(vec![
|
|
||||||
AssistantEvent::TextDelta("done".to_string()),
|
|
||||||
AssistantEvent::Usage(TokenUsage {
|
|
||||||
input_tokens: 99_999,
|
|
||||||
output_tokens: 4,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
}),
|
|
||||||
AssistantEvent::MessageStop,
|
|
||||||
])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut runtime = ConversationRuntime::new(
|
|
||||||
Session::new(),
|
|
||||||
SimpleApi,
|
|
||||||
StaticToolExecutor::new(),
|
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
|
||||||
vec!["system".to_string()],
|
|
||||||
)
|
|
||||||
.with_auto_compaction_input_tokens_threshold(100_000);
|
|
||||||
|
|
||||||
let summary = runtime
|
|
||||||
.run_turn("trigger", None)
|
|
||||||
.expect("turn should succeed");
|
|
||||||
assert_eq!(summary.auto_compaction, None);
|
|
||||||
assert_eq!(runtime.session().messages.len(), 2);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn auto_compaction_threshold_defaults_and_parses_values() {
|
|
||||||
assert_eq!(
|
|
||||||
parse_auto_compaction_threshold(None),
|
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD
|
|
||||||
);
|
|
||||||
assert_eq!(parse_auto_compaction_threshold(Some("4321")), 4321);
|
|
||||||
assert_eq!(
|
|
||||||
parse_auto_compaction_threshold(Some("not-a-number")),
|
|
||||||
DEFAULT_AUTO_COMPACTION_INPUT_TOKENS_THRESHOLD
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
use std::ffi::OsStr;
|
use std::ffi::OsStr;
|
||||||
use std::path::Path;
|
|
||||||
use std::process::Command;
|
use std::process::Command;
|
||||||
|
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
@@ -52,6 +51,16 @@ pub struct HookRunner {
|
|||||||
config: RuntimeHookConfig,
|
config: RuntimeHookConfig,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy)]
|
||||||
|
struct HookCommandRequest<'a> {
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: &'a str,
|
||||||
|
tool_input: &'a str,
|
||||||
|
tool_output: Option<&'a str>,
|
||||||
|
is_error: bool,
|
||||||
|
payload: &'a str,
|
||||||
|
}
|
||||||
|
|
||||||
impl HookRunner {
|
impl HookRunner {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn new(config: RuntimeHookConfig) -> Self {
|
pub fn new(config: RuntimeHookConfig) -> Self {
|
||||||
@@ -119,14 +128,16 @@ impl HookRunner {
|
|||||||
let mut messages = Vec::new();
|
let mut messages = Vec::new();
|
||||||
|
|
||||||
for command in commands {
|
for command in commands {
|
||||||
match self.run_command(
|
match Self::run_command(
|
||||||
command,
|
command,
|
||||||
event,
|
HookCommandRequest {
|
||||||
tool_name,
|
event,
|
||||||
tool_input,
|
tool_name,
|
||||||
tool_output,
|
tool_input,
|
||||||
is_error,
|
tool_output,
|
||||||
&payload,
|
is_error,
|
||||||
|
payload: &payload,
|
||||||
|
},
|
||||||
) {
|
) {
|
||||||
HookCommandOutcome::Allow { message } => {
|
HookCommandOutcome::Allow { message } => {
|
||||||
if let Some(message) = message {
|
if let Some(message) = message {
|
||||||
@@ -150,30 +161,23 @@ impl HookRunner {
|
|||||||
HookRunResult::allow(messages)
|
HookRunResult::allow(messages)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::too_many_arguments, clippy::unused_self)]
|
fn run_command(command: &str, request: HookCommandRequest<'_>) -> HookCommandOutcome {
|
||||||
fn run_command(
|
|
||||||
&self,
|
|
||||||
command: &str,
|
|
||||||
event: HookEvent,
|
|
||||||
tool_name: &str,
|
|
||||||
tool_input: &str,
|
|
||||||
tool_output: Option<&str>,
|
|
||||||
is_error: bool,
|
|
||||||
payload: &str,
|
|
||||||
) -> HookCommandOutcome {
|
|
||||||
let mut child = shell_command(command);
|
let mut child = shell_command(command);
|
||||||
child.stdin(std::process::Stdio::piped());
|
child.stdin(std::process::Stdio::piped());
|
||||||
child.stdout(std::process::Stdio::piped());
|
child.stdout(std::process::Stdio::piped());
|
||||||
child.stderr(std::process::Stdio::piped());
|
child.stderr(std::process::Stdio::piped());
|
||||||
child.env("HOOK_EVENT", event.as_str());
|
child.env("HOOK_EVENT", request.event.as_str());
|
||||||
child.env("HOOK_TOOL_NAME", tool_name);
|
child.env("HOOK_TOOL_NAME", request.tool_name);
|
||||||
child.env("HOOK_TOOL_INPUT", tool_input);
|
child.env("HOOK_TOOL_INPUT", request.tool_input);
|
||||||
child.env("HOOK_TOOL_IS_ERROR", if is_error { "1" } else { "0" });
|
child.env(
|
||||||
if let Some(tool_output) = tool_output {
|
"HOOK_TOOL_IS_ERROR",
|
||||||
|
if request.is_error { "1" } else { "0" },
|
||||||
|
);
|
||||||
|
if let Some(tool_output) = request.tool_output {
|
||||||
child.env("HOOK_TOOL_OUTPUT", tool_output);
|
child.env("HOOK_TOOL_OUTPUT", tool_output);
|
||||||
}
|
}
|
||||||
|
|
||||||
match child.output_with_stdin(payload.as_bytes()) {
|
match child.output_with_stdin(request.payload.as_bytes()) {
|
||||||
Ok(output) => {
|
Ok(output) => {
|
||||||
let stdout = String::from_utf8_lossy(&output.stdout).trim().to_string();
|
let stdout = String::from_utf8_lossy(&output.stdout).trim().to_string();
|
||||||
let stderr = String::from_utf8_lossy(&output.stderr).trim().to_string();
|
let stderr = String::from_utf8_lossy(&output.stderr).trim().to_string();
|
||||||
@@ -191,16 +195,18 @@ impl HookRunner {
|
|||||||
},
|
},
|
||||||
None => HookCommandOutcome::Warn {
|
None => HookCommandOutcome::Warn {
|
||||||
message: format!(
|
message: format!(
|
||||||
"{} hook `{command}` terminated by signal while handling `{tool_name}`",
|
"{} hook `{command}` terminated by signal while handling `{}`",
|
||||||
event.as_str()
|
request.event.as_str(),
|
||||||
|
request.tool_name
|
||||||
),
|
),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
Err(error) => HookCommandOutcome::Warn {
|
Err(error) => HookCommandOutcome::Warn {
|
||||||
message: format!(
|
message: format!(
|
||||||
"{} hook `{command}` failed to start for `{tool_name}`: {error}",
|
"{} hook `{command}` failed to start for `{}`: {error}",
|
||||||
event.as_str()
|
request.event.as_str(),
|
||||||
|
request.tool_name
|
||||||
),
|
),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
@@ -239,11 +245,7 @@ fn shell_command(command: &str) -> CommandWithStdin {
|
|||||||
};
|
};
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
#[cfg(not(windows))]
|
||||||
let command_builder = if Path::new(command).exists() {
|
let command_builder = {
|
||||||
let mut command_builder = Command::new("sh");
|
|
||||||
command_builder.arg(command);
|
|
||||||
CommandWithStdin::new(command_builder)
|
|
||||||
} else {
|
|
||||||
let mut command_builder = Command::new("sh");
|
let mut command_builder = Command::new("sh");
|
||||||
command_builder.arg("-lc").arg(command);
|
command_builder.arg("-lc").arg(command);
|
||||||
CommandWithStdin::new(command_builder)
|
CommandWithStdin::new(command_builder)
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -4,17 +4,16 @@ use std::process::Command;
|
|||||||
use std::time::{Duration, Instant};
|
use std::time::{Duration, Instant};
|
||||||
|
|
||||||
use api::{
|
use api::{
|
||||||
read_base_url, ApiHttpClient, ContentBlockDelta, InputContentBlock, InputMessage,
|
max_tokens_for_model, resolve_model_alias, ContentBlockDelta, InputContentBlock, InputMessage,
|
||||||
MessageRequest, MessageResponse, OutputContentBlock, StreamEvent as ApiStreamEvent, ToolChoice,
|
MessageRequest, MessageResponse, OutputContentBlock, ProviderClient,
|
||||||
ToolDefinition, ToolResultContentBlock,
|
StreamEvent as ApiStreamEvent, ToolChoice, ToolDefinition, ToolResultContentBlock,
|
||||||
};
|
};
|
||||||
use plugins::{PluginManager, PluginManagerConfig, PluginTool};
|
|
||||||
use reqwest::blocking::Client;
|
use reqwest::blocking::Client;
|
||||||
use runtime::{
|
use runtime::{
|
||||||
edit_file, execute_bash, glob_search, grep_search, load_system_prompt, read_file, write_file,
|
edit_file, execute_bash, glob_search, grep_search, load_system_prompt, read_file, write_file,
|
||||||
ApiClient, ApiRequest, AssistantEvent, BashCommandInput, ConfigLoader, ContentBlock,
|
ApiClient, ApiRequest, AssistantEvent, BashCommandInput, ContentBlock, ConversationMessage,
|
||||||
ConversationMessage, ConversationRuntime, GrepSearchInput, MessageRole, PermissionMode,
|
ConversationRuntime, GrepSearchInput, MessageRole, PermissionMode, PermissionPolicy,
|
||||||
PermissionPolicy, RuntimeConfig, RuntimeError, Session, TokenUsage, ToolError, ToolExecutor,
|
RuntimeError, Session, TokenUsage, ToolError, ToolExecutor,
|
||||||
};
|
};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use serde_json::{json, Value};
|
use serde_json::{json, Value};
|
||||||
@@ -56,239 +55,6 @@ pub struct ToolSpec {
|
|||||||
pub required_permission: PermissionMode,
|
pub required_permission: PermissionMode,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
pub struct RegisteredTool {
|
|
||||||
pub definition: ToolDefinition,
|
|
||||||
pub required_permission: PermissionMode,
|
|
||||||
handler: RegisteredToolHandler,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::large_enum_variant)]
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
enum RegisteredToolHandler {
|
|
||||||
Builtin,
|
|
||||||
Plugin(PluginTool),
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq)]
|
|
||||||
pub struct GlobalToolRegistry {
|
|
||||||
entries: Vec<RegisteredTool>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl GlobalToolRegistry {
|
|
||||||
#[must_use]
|
|
||||||
pub fn builtin() -> Self {
|
|
||||||
Self {
|
|
||||||
entries: mvp_tool_specs()
|
|
||||||
.into_iter()
|
|
||||||
.map(|spec| RegisteredTool {
|
|
||||||
definition: ToolDefinition {
|
|
||||||
name: spec.name.to_string(),
|
|
||||||
description: Some(spec.description.to_string()),
|
|
||||||
input_schema: spec.input_schema,
|
|
||||||
},
|
|
||||||
required_permission: spec.required_permission,
|
|
||||||
handler: RegisteredToolHandler::Builtin,
|
|
||||||
})
|
|
||||||
.collect(),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn with_plugin_tools(plugin_tools: Vec<PluginTool>) -> Result<Self, String> {
|
|
||||||
let mut registry = Self::builtin();
|
|
||||||
let mut seen = registry
|
|
||||||
.entries
|
|
||||||
.iter()
|
|
||||||
.map(|entry| {
|
|
||||||
(
|
|
||||||
normalize_registry_tool_name(&entry.definition.name),
|
|
||||||
entry.definition.name.clone(),
|
|
||||||
)
|
|
||||||
})
|
|
||||||
.collect::<BTreeMap<_, _>>();
|
|
||||||
|
|
||||||
for tool in plugin_tools {
|
|
||||||
let normalized = normalize_registry_tool_name(&tool.definition().name);
|
|
||||||
if let Some(existing) = seen.get(&normalized) {
|
|
||||||
return Err(format!(
|
|
||||||
"plugin tool `{}` from `{}` conflicts with already-registered tool `{existing}`",
|
|
||||||
tool.definition().name,
|
|
||||||
tool.plugin_id()
|
|
||||||
));
|
|
||||||
}
|
|
||||||
seen.insert(normalized, tool.definition().name.clone());
|
|
||||||
registry.entries.push(RegisteredTool {
|
|
||||||
definition: ToolDefinition {
|
|
||||||
name: tool.definition().name.clone(),
|
|
||||||
description: tool.definition().description.clone(),
|
|
||||||
input_schema: tool.definition().input_schema.clone(),
|
|
||||||
},
|
|
||||||
required_permission: permission_mode_from_plugin_tool(tool.required_permission())?,
|
|
||||||
handler: RegisteredToolHandler::Plugin(tool),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(registry)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn entries(&self) -> &[RegisteredTool] {
|
|
||||||
&self.entries
|
|
||||||
}
|
|
||||||
|
|
||||||
fn find_entry(&self, name: &str) -> Option<&RegisteredTool> {
|
|
||||||
let normalized = normalize_registry_tool_name(name);
|
|
||||||
self.entries.iter().find(|entry| {
|
|
||||||
normalize_registry_tool_name(entry.definition.name.as_str()) == normalized
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn definitions(&self, allowed_tools: Option<&BTreeSet<String>>) -> Vec<ToolDefinition> {
|
|
||||||
self.entries
|
|
||||||
.iter()
|
|
||||||
.filter(|entry| {
|
|
||||||
allowed_tools.is_none_or(|allowed| allowed.contains(entry.definition.name.as_str()))
|
|
||||||
})
|
|
||||||
.map(|entry| entry.definition.clone())
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
|
||||||
pub fn permission_specs(
|
|
||||||
&self,
|
|
||||||
allowed_tools: Option<&BTreeSet<String>>,
|
|
||||||
) -> Vec<(String, PermissionMode)> {
|
|
||||||
self.entries
|
|
||||||
.iter()
|
|
||||||
.filter(|entry| {
|
|
||||||
allowed_tools.is_none_or(|allowed| allowed.contains(entry.definition.name.as_str()))
|
|
||||||
})
|
|
||||||
.map(|entry| (entry.definition.name.clone(), entry.required_permission))
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn normalize_allowed_tools(
|
|
||||||
&self,
|
|
||||||
values: &[String],
|
|
||||||
) -> Result<Option<BTreeSet<String>>, String> {
|
|
||||||
if values.is_empty() {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
|
|
||||||
let canonical_names = self
|
|
||||||
.entries
|
|
||||||
.iter()
|
|
||||||
.map(|entry| entry.definition.name.clone())
|
|
||||||
.collect::<Vec<_>>();
|
|
||||||
let mut name_map = canonical_names
|
|
||||||
.iter()
|
|
||||||
.map(|name| (normalize_registry_tool_name(name), name.clone()))
|
|
||||||
.collect::<BTreeMap<_, _>>();
|
|
||||||
|
|
||||||
for (alias, canonical) in [
|
|
||||||
("read", "read_file"),
|
|
||||||
("write", "write_file"),
|
|
||||||
("edit", "edit_file"),
|
|
||||||
("glob", "glob_search"),
|
|
||||||
("grep", "grep_search"),
|
|
||||||
] {
|
|
||||||
if canonical_names.iter().any(|name| name == canonical) {
|
|
||||||
name_map.insert(alias.to_string(), canonical.to_string());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut allowed = BTreeSet::new();
|
|
||||||
for value in values {
|
|
||||||
for token in value
|
|
||||||
.split(|ch: char| ch == ',' || ch.is_whitespace())
|
|
||||||
.filter(|token| !token.is_empty())
|
|
||||||
{
|
|
||||||
let normalized = normalize_registry_tool_name(token);
|
|
||||||
let canonical = name_map.get(&normalized).ok_or_else(|| {
|
|
||||||
format!(
|
|
||||||
"unsupported tool in --allowedTools: {token} (expected one of: {})",
|
|
||||||
canonical_names.join(", ")
|
|
||||||
)
|
|
||||||
})?;
|
|
||||||
allowed.insert(canonical.clone());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(Some(allowed))
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn execute(&self, name: &str, input: &Value) -> Result<String, String> {
|
|
||||||
let entry = self
|
|
||||||
.find_entry(name)
|
|
||||||
.ok_or_else(|| format!("unsupported tool: {name}"))?;
|
|
||||||
match &entry.handler {
|
|
||||||
RegisteredToolHandler::Builtin => execute_tool(&entry.definition.name, input),
|
|
||||||
RegisteredToolHandler::Plugin(tool) => {
|
|
||||||
tool.execute(input).map_err(|error| error.to_string())
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Default for GlobalToolRegistry {
|
|
||||||
fn default() -> Self {
|
|
||||||
Self::builtin()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn normalize_registry_tool_name(value: &str) -> String {
|
|
||||||
let trimmed = value.trim();
|
|
||||||
let chars = trimmed.chars().collect::<Vec<_>>();
|
|
||||||
let mut normalized = String::new();
|
|
||||||
|
|
||||||
for (index, ch) in chars.iter().copied().enumerate() {
|
|
||||||
if matches!(ch, '-' | ' ' | '\t' | '\n') {
|
|
||||||
if !normalized.ends_with('_') {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
if ch == '_' {
|
|
||||||
if !normalized.ends_with('_') {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
if ch.is_uppercase() {
|
|
||||||
let prev = chars.get(index.wrapping_sub(1)).copied();
|
|
||||||
let next = chars.get(index + 1).copied();
|
|
||||||
let needs_separator = index > 0
|
|
||||||
&& !normalized.ends_with('_')
|
|
||||||
&& (prev.is_some_and(|prev| prev.is_lowercase() || prev.is_ascii_digit())
|
|
||||||
|| (prev.is_some_and(char::is_uppercase)
|
|
||||||
&& next.is_some_and(char::is_lowercase)));
|
|
||||||
if needs_separator {
|
|
||||||
normalized.push('_');
|
|
||||||
}
|
|
||||||
normalized.extend(ch.to_lowercase());
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
normalized.push(ch.to_ascii_lowercase());
|
|
||||||
}
|
|
||||||
|
|
||||||
normalized.trim_matches('_').to_string()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn permission_mode_from_plugin_tool(value: &str) -> Result<PermissionMode, String> {
|
|
||||||
match value {
|
|
||||||
"read-only" => Ok(PermissionMode::ReadOnly),
|
|
||||||
"workspace-write" => Ok(PermissionMode::WorkspaceWrite),
|
|
||||||
"danger-full-access" => Ok(PermissionMode::DangerFullAccess),
|
|
||||||
other => Err(format!(
|
|
||||||
"unsupported plugin tool permission `{other}` (expected read-only, workspace-write, or danger-full-access)"
|
|
||||||
)),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
#[allow(clippy::too_many_lines)]
|
#[allow(clippy::too_many_lines)]
|
||||||
pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
||||||
@@ -557,7 +323,7 @@ pub fn mvp_tool_specs() -> Vec<ToolSpec> {
|
|||||||
},
|
},
|
||||||
ToolSpec {
|
ToolSpec {
|
||||||
name: "Config",
|
name: "Config",
|
||||||
description: "Get or set Claw Code settings.",
|
description: "Get or set Claude Code settings.",
|
||||||
input_schema: json!({
|
input_schema: json!({
|
||||||
"type": "object",
|
"type": "object",
|
||||||
"properties": {
|
"properties": {
|
||||||
@@ -1542,11 +1308,6 @@ fn resolve_skill_path(skill: &str) -> Result<std::path::PathBuf, String> {
|
|||||||
if let Ok(codex_home) = std::env::var("CODEX_HOME") {
|
if let Ok(codex_home) = std::env::var("CODEX_HOME") {
|
||||||
candidates.push(std::path::PathBuf::from(codex_home).join("skills"));
|
candidates.push(std::path::PathBuf::from(codex_home).join("skills"));
|
||||||
}
|
}
|
||||||
if let Ok(home) = std::env::var("HOME") {
|
|
||||||
let home = std::path::PathBuf::from(home);
|
|
||||||
candidates.push(home.join(".agents").join("skills"));
|
|
||||||
candidates.push(home.join(".codex").join("skills"));
|
|
||||||
}
|
|
||||||
candidates.push(std::path::PathBuf::from("/home/bellman/.codex/skills"));
|
candidates.push(std::path::PathBuf::from("/home/bellman/.codex/skills"));
|
||||||
|
|
||||||
for root in candidates {
|
for root in candidates {
|
||||||
@@ -1698,22 +1459,20 @@ fn run_agent_job(job: &AgentJob) -> Result<(), String> {
|
|||||||
|
|
||||||
fn build_agent_runtime(
|
fn build_agent_runtime(
|
||||||
job: &AgentJob,
|
job: &AgentJob,
|
||||||
) -> Result<ConversationRuntime<AnthropicRuntimeClient, SubagentToolExecutor>, String> {
|
) -> Result<ConversationRuntime<ProviderRuntimeClient, SubagentToolExecutor>, String> {
|
||||||
let model = job
|
let model = job
|
||||||
.manifest
|
.manifest
|
||||||
.model
|
.model
|
||||||
.clone()
|
.clone()
|
||||||
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
||||||
let allowed_tools = job.allowed_tools.clone();
|
let allowed_tools = job.allowed_tools.clone();
|
||||||
let tool_registry = current_tool_registry()?;
|
let api_client = ProviderRuntimeClient::new(model, allowed_tools.clone())?;
|
||||||
let api_client =
|
let tool_executor = SubagentToolExecutor::new(allowed_tools);
|
||||||
AnthropicRuntimeClient::new(model, allowed_tools.clone(), tool_registry.clone())?;
|
|
||||||
let tool_executor = SubagentToolExecutor::new(allowed_tools, tool_registry.clone());
|
|
||||||
Ok(ConversationRuntime::new(
|
Ok(ConversationRuntime::new(
|
||||||
Session::new(),
|
Session::new(),
|
||||||
api_client,
|
api_client,
|
||||||
tool_executor,
|
tool_executor,
|
||||||
agent_permission_policy(&tool_registry),
|
agent_permission_policy(),
|
||||||
job.system_prompt.clone(),
|
job.system_prompt.clone(),
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
@@ -1778,7 +1537,7 @@ fn allowed_tools_for_subagent(subagent_type: &str) -> BTreeSet<String> {
|
|||||||
"SendUserMessage",
|
"SendUserMessage",
|
||||||
"PowerShell",
|
"PowerShell",
|
||||||
],
|
],
|
||||||
"claw-code-guide" => vec![
|
"claude-code-guide" => vec![
|
||||||
"read_file",
|
"read_file",
|
||||||
"glob_search",
|
"glob_search",
|
||||||
"grep_search",
|
"grep_search",
|
||||||
@@ -1822,12 +1581,10 @@ fn allowed_tools_for_subagent(subagent_type: &str) -> BTreeSet<String> {
|
|||||||
tools.into_iter().map(str::to_string).collect()
|
tools.into_iter().map(str::to_string).collect()
|
||||||
}
|
}
|
||||||
|
|
||||||
fn agent_permission_policy(tool_registry: &GlobalToolRegistry) -> PermissionPolicy {
|
fn agent_permission_policy() -> PermissionPolicy {
|
||||||
tool_registry.permission_specs(None).into_iter().fold(
|
mvp_tool_specs().into_iter().fold(
|
||||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|policy, (name, required_permission)| {
|
|policy, spec| policy.with_tool_requirement(spec.name, spec.required_permission),
|
||||||
policy.with_tool_requirement(name, required_permission)
|
|
||||||
},
|
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1878,39 +1635,39 @@ fn format_agent_terminal_output(status: &str, result: Option<&str>, error: Optio
|
|||||||
sections.join("")
|
sections.join("")
|
||||||
}
|
}
|
||||||
|
|
||||||
struct AnthropicRuntimeClient {
|
struct ProviderRuntimeClient {
|
||||||
runtime: tokio::runtime::Runtime,
|
runtime: tokio::runtime::Runtime,
|
||||||
client: ApiHttpClient,
|
client: ProviderClient,
|
||||||
model: String,
|
model: String,
|
||||||
allowed_tools: BTreeSet<String>,
|
allowed_tools: BTreeSet<String>,
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AnthropicRuntimeClient {
|
impl ProviderRuntimeClient {
|
||||||
fn new(
|
fn new(model: String, allowed_tools: BTreeSet<String>) -> Result<Self, String> {
|
||||||
model: String,
|
let model = resolve_model_alias(&model).to_string();
|
||||||
allowed_tools: BTreeSet<String>,
|
let client = ProviderClient::from_model(&model).map_err(|error| error.to_string())?;
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
) -> Result<Self, String> {
|
|
||||||
let client = ApiHttpClient::from_env()
|
|
||||||
.map_err(|error| error.to_string())?
|
|
||||||
.with_base_url(read_base_url());
|
|
||||||
Ok(Self {
|
Ok(Self {
|
||||||
runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,
|
runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,
|
||||||
client,
|
client,
|
||||||
model,
|
model,
|
||||||
allowed_tools,
|
allowed_tools,
|
||||||
tool_registry,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ApiClient for AnthropicRuntimeClient {
|
impl ApiClient for ProviderRuntimeClient {
|
||||||
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
let tools = self.tool_registry.definitions(Some(&self.allowed_tools));
|
let tools = tool_specs_for_allowed_tools(Some(&self.allowed_tools))
|
||||||
|
.into_iter()
|
||||||
|
.map(|spec| ToolDefinition {
|
||||||
|
name: spec.name.to_string(),
|
||||||
|
description: Some(spec.description.to_string()),
|
||||||
|
input_schema: spec.input_schema,
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
let message_request = MessageRequest {
|
let message_request = MessageRequest {
|
||||||
model: self.model.clone(),
|
model: self.model.clone(),
|
||||||
max_tokens: 32_000,
|
max_tokens: max_tokens_for_model(&self.model),
|
||||||
messages: convert_messages(&request.messages),
|
messages: convert_messages(&request.messages),
|
||||||
system: (!request.system_prompt.is_empty()).then(|| request.system_prompt.join("\n\n")),
|
system: (!request.system_prompt.is_empty()).then(|| request.system_prompt.join("\n\n")),
|
||||||
tools: (!tools.is_empty()).then_some(tools),
|
tools: (!tools.is_empty()).then_some(tools),
|
||||||
@@ -1925,7 +1682,7 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
.await
|
.await
|
||||||
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
let mut events = Vec::new();
|
let mut events = Vec::new();
|
||||||
let mut pending_tool: Option<(String, String, String)> = None;
|
let mut pending_tools: BTreeMap<u32, (String, String, String)> = BTreeMap::new();
|
||||||
let mut saw_stop = false;
|
let mut saw_stop = false;
|
||||||
|
|
||||||
while let Some(event) = stream
|
while let Some(event) = stream
|
||||||
@@ -1936,14 +1693,15 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
match event {
|
match event {
|
||||||
ApiStreamEvent::MessageStart(start) => {
|
ApiStreamEvent::MessageStart(start) => {
|
||||||
for block in start.message.content {
|
for block in start.message.content {
|
||||||
push_output_block(block, &mut events, &mut pending_tool, true);
|
push_output_block(block, 0, &mut events, &mut pending_tools, true);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
ApiStreamEvent::ContentBlockStart(start) => {
|
ApiStreamEvent::ContentBlockStart(start) => {
|
||||||
push_output_block(
|
push_output_block(
|
||||||
start.content_block,
|
start.content_block,
|
||||||
|
start.index,
|
||||||
&mut events,
|
&mut events,
|
||||||
&mut pending_tool,
|
&mut pending_tools,
|
||||||
true,
|
true,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -1954,15 +1712,13 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
ContentBlockDelta::InputJsonDelta { partial_json } => {
|
ContentBlockDelta::InputJsonDelta { partial_json } => {
|
||||||
if let Some((_, _, input)) = &mut pending_tool {
|
if let Some((_, _, input)) = pending_tools.get_mut(&delta.index) {
|
||||||
input.push_str(&partial_json);
|
input.push_str(&partial_json);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
ContentBlockDelta::ThinkingDelta { .. }
|
|
||||||
| ContentBlockDelta::SignatureDelta { .. } => {}
|
|
||||||
},
|
},
|
||||||
ApiStreamEvent::ContentBlockStop(_) => {
|
ApiStreamEvent::ContentBlockStop(stop) => {
|
||||||
if let Some((id, name, input)) = pending_tool.take() {
|
if let Some((id, name, input)) = pending_tools.remove(&stop.index) {
|
||||||
events.push(AssistantEvent::ToolUse { id, name, input });
|
events.push(AssistantEvent::ToolUse { id, name, input });
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2012,82 +1768,32 @@ impl ApiClient for AnthropicRuntimeClient {
|
|||||||
|
|
||||||
struct SubagentToolExecutor {
|
struct SubagentToolExecutor {
|
||||||
allowed_tools: BTreeSet<String>,
|
allowed_tools: BTreeSet<String>,
|
||||||
tool_registry: GlobalToolRegistry,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl SubagentToolExecutor {
|
impl SubagentToolExecutor {
|
||||||
fn new(allowed_tools: BTreeSet<String>, tool_registry: GlobalToolRegistry) -> Self {
|
fn new(allowed_tools: BTreeSet<String>) -> Self {
|
||||||
Self {
|
Self { allowed_tools }
|
||||||
allowed_tools,
|
|
||||||
tool_registry,
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ToolExecutor for SubagentToolExecutor {
|
impl ToolExecutor for SubagentToolExecutor {
|
||||||
fn execute(&mut self, tool_name: &str, input: &str) -> Result<String, ToolError> {
|
fn execute(&mut self, tool_name: &str, input: &str) -> Result<String, ToolError> {
|
||||||
let entry = self
|
if !self.allowed_tools.contains(tool_name) {
|
||||||
.tool_registry
|
|
||||||
.find_entry(tool_name)
|
|
||||||
.ok_or_else(|| ToolError::new(format!("unsupported tool: {tool_name}")))?;
|
|
||||||
if !self.allowed_tools.contains(entry.definition.name.as_str()) {
|
|
||||||
return Err(ToolError::new(format!(
|
return Err(ToolError::new(format!(
|
||||||
"tool `{tool_name}` is not enabled for this sub-agent"
|
"tool `{tool_name}` is not enabled for this sub-agent"
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
let value = serde_json::from_str(input)
|
let value = serde_json::from_str(input)
|
||||||
.map_err(|error| ToolError::new(format!("invalid tool input JSON: {error}")))?;
|
.map_err(|error| ToolError::new(format!("invalid tool input JSON: {error}")))?;
|
||||||
self.tool_registry
|
execute_tool(tool_name, &value).map_err(ToolError::new)
|
||||||
.execute(tool_name, &value)
|
|
||||||
.map_err(ToolError::new)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn current_tool_registry() -> Result<GlobalToolRegistry, String> {
|
fn tool_specs_for_allowed_tools(allowed_tools: Option<&BTreeSet<String>>) -> Vec<ToolSpec> {
|
||||||
let cwd = std::env::current_dir().map_err(|error| error.to_string())?;
|
mvp_tool_specs()
|
||||||
let loader = ConfigLoader::default_for(&cwd);
|
.into_iter()
|
||||||
let runtime_config = loader.load().map_err(|error| error.to_string())?;
|
.filter(|spec| allowed_tools.is_none_or(|allowed| allowed.contains(spec.name)))
|
||||||
let plugin_manager = build_plugin_manager(&cwd, &loader, &runtime_config);
|
.collect()
|
||||||
let plugin_tools = plugin_manager
|
|
||||||
.aggregated_tools()
|
|
||||||
.map_err(|error| error.to_string())?;
|
|
||||||
GlobalToolRegistry::with_plugin_tools(plugin_tools)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn build_plugin_manager(
|
|
||||||
cwd: &Path,
|
|
||||||
loader: &ConfigLoader,
|
|
||||||
runtime_config: &RuntimeConfig,
|
|
||||||
) -> PluginManager {
|
|
||||||
let plugin_settings = runtime_config.plugins();
|
|
||||||
let mut plugin_config = PluginManagerConfig::new(loader.config_home().to_path_buf());
|
|
||||||
plugin_config.enabled_plugins = plugin_settings.enabled_plugins().clone();
|
|
||||||
plugin_config.external_dirs = plugin_settings
|
|
||||||
.external_directories()
|
|
||||||
.iter()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path))
|
|
||||||
.collect();
|
|
||||||
plugin_config.install_root = plugin_settings
|
|
||||||
.install_root()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
plugin_config.registry_path = plugin_settings
|
|
||||||
.registry_path()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
plugin_config.bundled_root = plugin_settings
|
|
||||||
.bundled_root()
|
|
||||||
.map(|path| resolve_plugin_path(cwd, loader.config_home(), path));
|
|
||||||
PluginManager::new(plugin_config)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn resolve_plugin_path(cwd: &Path, config_home: &Path, value: &str) -> PathBuf {
|
|
||||||
let path = PathBuf::from(value);
|
|
||||||
if path.is_absolute() {
|
|
||||||
path
|
|
||||||
} else if value.starts_with('.') {
|
|
||||||
cwd.join(path)
|
|
||||||
} else {
|
|
||||||
config_home.join(path)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
||||||
@@ -2133,8 +1839,9 @@ fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
|||||||
|
|
||||||
fn push_output_block(
|
fn push_output_block(
|
||||||
block: OutputContentBlock,
|
block: OutputContentBlock,
|
||||||
|
block_index: u32,
|
||||||
events: &mut Vec<AssistantEvent>,
|
events: &mut Vec<AssistantEvent>,
|
||||||
pending_tool: &mut Option<(String, String, String)>,
|
pending_tools: &mut BTreeMap<u32, (String, String, String)>,
|
||||||
streaming_tool_input: bool,
|
streaming_tool_input: bool,
|
||||||
) {
|
) {
|
||||||
match block {
|
match block {
|
||||||
@@ -2152,19 +1859,19 @@ fn push_output_block(
|
|||||||
} else {
|
} else {
|
||||||
input.to_string()
|
input.to_string()
|
||||||
};
|
};
|
||||||
*pending_tool = Some((id, name, initial_input));
|
pending_tools.insert(block_index, (id, name, initial_input));
|
||||||
}
|
}
|
||||||
OutputContentBlock::Thinking { .. } | OutputContentBlock::RedactedThinking { .. } => {}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn response_to_events(response: MessageResponse) -> Vec<AssistantEvent> {
|
fn response_to_events(response: MessageResponse) -> Vec<AssistantEvent> {
|
||||||
let mut events = Vec::new();
|
let mut events = Vec::new();
|
||||||
let mut pending_tool = None;
|
let mut pending_tools = BTreeMap::new();
|
||||||
|
|
||||||
for block in response.content {
|
for (index, block) in response.content.into_iter().enumerate() {
|
||||||
push_output_block(block, &mut events, &mut pending_tool, false);
|
let index = u32::try_from(index).expect("response block index overflow");
|
||||||
if let Some((id, name, input)) = pending_tool.take() {
|
push_output_block(block, index, &mut events, &mut pending_tools, false);
|
||||||
|
if let Some((id, name, input)) = pending_tools.remove(&index) {
|
||||||
events.push(AssistantEvent::ToolUse { id, name, input });
|
events.push(AssistantEvent::ToolUse { id, name, input });
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2382,7 +2089,7 @@ fn normalize_subagent_type(subagent_type: Option<&str>) -> String {
|
|||||||
"verification" | "verificationagent" | "verify" | "verifier" => {
|
"verification" | "verificationagent" | "verify" | "verifier" => {
|
||||||
String::from("Verification")
|
String::from("Verification")
|
||||||
}
|
}
|
||||||
"claudecodeguide" | "claudecodeguideagent" | "guide" => String::from("claw-code-guide"),
|
"claudecodeguide" | "claudecodeguideagent" | "guide" => String::from("claude-code-guide"),
|
||||||
"statusline" | "statuslinesetup" => String::from("statusline-setup"),
|
"statusline" | "statuslinesetup" => String::from("statusline-setup"),
|
||||||
_ => trimmed.to_string(),
|
_ => trimmed.to_string(),
|
||||||
}
|
}
|
||||||
@@ -2882,16 +2589,16 @@ fn config_file_for_scope(scope: ConfigScope) -> Result<PathBuf, String> {
|
|||||||
let cwd = std::env::current_dir().map_err(|error| error.to_string())?;
|
let cwd = std::env::current_dir().map_err(|error| error.to_string())?;
|
||||||
Ok(match scope {
|
Ok(match scope {
|
||||||
ConfigScope::Global => config_home_dir()?.join("settings.json"),
|
ConfigScope::Global => config_home_dir()?.join("settings.json"),
|
||||||
ConfigScope::Settings => cwd.join(".claw").join("settings.local.json"),
|
ConfigScope::Settings => cwd.join(".claude").join("settings.local.json"),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
fn config_home_dir() -> Result<PathBuf, String> {
|
fn config_home_dir() -> Result<PathBuf, String> {
|
||||||
if let Ok(path) = std::env::var("CLAW_CONFIG_HOME") {
|
if let Ok(path) = std::env::var("CLAUDE_CONFIG_HOME") {
|
||||||
return Ok(PathBuf::from(path));
|
return Ok(PathBuf::from(path));
|
||||||
}
|
}
|
||||||
let home = std::env::var("HOME").map_err(|_| String::from("HOME is not set"))?;
|
let home = std::env::var("HOME").map_err(|_| String::from("HOME is not set"))?;
|
||||||
Ok(PathBuf::from(home).join(".claw"))
|
Ok(PathBuf::from(home).join(".claude"))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn read_json_object(path: &Path) -> Result<serde_json::Map<String, Value>, String> {
|
fn read_json_object(path: &Path) -> Result<serde_json::Map<String, Value>, String> {
|
||||||
@@ -3188,6 +2895,7 @@ fn parse_skill_description(contents: &str) -> Option<String> {
|
|||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
|
use std::collections::BTreeMap;
|
||||||
use std::collections::BTreeSet;
|
use std::collections::BTreeSet;
|
||||||
use std::fs;
|
use std::fs;
|
||||||
use std::io::{Read, Write};
|
use std::io::{Read, Write};
|
||||||
@@ -3200,13 +2908,10 @@ mod tests {
|
|||||||
use super::{
|
use super::{
|
||||||
agent_permission_policy, allowed_tools_for_subagent, execute_agent_with_spawn,
|
agent_permission_policy, allowed_tools_for_subagent, execute_agent_with_spawn,
|
||||||
execute_tool, final_assistant_text, mvp_tool_specs, persist_agent_terminal_state,
|
execute_tool, final_assistant_text, mvp_tool_specs, persist_agent_terminal_state,
|
||||||
response_to_events, AgentInput, AgentJob, GlobalToolRegistry, SubagentToolExecutor,
|
push_output_block, AgentInput, AgentJob, SubagentToolExecutor,
|
||||||
};
|
|
||||||
use api::{MessageResponse, OutputContentBlock, Usage};
|
|
||||||
use plugins::{PluginTool, PluginToolDefinition, PluginToolPermission};
|
|
||||||
use runtime::{
|
|
||||||
ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, Session, ToolExecutor,
|
|
||||||
};
|
};
|
||||||
|
use api::OutputContentBlock;
|
||||||
|
use runtime::{ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, Session};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
|
|
||||||
fn env_lock() -> &'static Mutex<()> {
|
fn env_lock() -> &'static Mutex<()> {
|
||||||
@@ -3222,17 +2927,6 @@ mod tests {
|
|||||||
std::env::temp_dir().join(format!("clawd-tools-{unique}-{name}"))
|
std::env::temp_dir().join(format!("clawd-tools-{unique}-{name}"))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn make_executable(path: &PathBuf) {
|
|
||||||
#[cfg(unix)]
|
|
||||||
{
|
|
||||||
use std::os::unix::fs::PermissionsExt;
|
|
||||||
|
|
||||||
let mut permissions = std::fs::metadata(path).expect("metadata").permissions();
|
|
||||||
permissions.set_mode(0o755);
|
|
||||||
std::fs::set_permissions(path, permissions).expect("chmod");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn exposes_mvp_tools() {
|
fn exposes_mvp_tools() {
|
||||||
let names = mvp_tool_specs()
|
let names = mvp_tool_specs()
|
||||||
@@ -3262,170 +2956,6 @@ mod tests {
|
|||||||
assert!(error.contains("unsupported tool"));
|
assert!(error.contains("unsupported tool"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_registers_and_executes_plugin_tools() {
|
|
||||||
let script = temp_path("plugin-tool.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"plugin\":\"%s\",\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_PLUGIN_ID\" \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
"sh".to_string(),
|
|
||||||
vec![script.display().to_string()],
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let names = registry
|
|
||||||
.definitions(None)
|
|
||||||
.into_iter()
|
|
||||||
.map(|definition| definition.name)
|
|
||||||
.collect::<Vec<_>>();
|
|
||||||
assert!(names.contains(&"bash".to_string()));
|
|
||||||
assert!(names.contains(&"plugin_echo".to_string()));
|
|
||||||
|
|
||||||
let output = registry
|
|
||||||
.execute("plugin_echo", &json!({ "message": "hello" }))
|
|
||||||
.expect("plugin tool should execute");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["plugin"], "demo@external");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_normalizes_plugin_tool_names_for_allowlists_and_execution() {
|
|
||||||
let script = temp_path("plugin-tool-normalized.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
script.display().to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let allowed = registry
|
|
||||||
.normalize_allowed_tools(&[String::from("PLUGIN-ECHO")])
|
|
||||||
.expect("plugin tool allowlist should normalize")
|
|
||||||
.expect("allowlist should be present");
|
|
||||||
assert!(allowed.contains("plugin_echo"));
|
|
||||||
|
|
||||||
let output = registry
|
|
||||||
.execute("plugin-echo", &json!({ "message": "hello" }))
|
|
||||||
.expect("normalized plugin tool name should execute");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let builtin_output = GlobalToolRegistry::builtin()
|
|
||||||
.execute("structured-output", &json!({ "ok": true }))
|
|
||||||
.expect("normalized builtin tool name should execute");
|
|
||||||
let builtin_payload: serde_json::Value =
|
|
||||||
serde_json::from_str(&builtin_output).expect("valid json");
|
|
||||||
assert_eq!(builtin_payload["structured_output"]["ok"], true);
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn subagent_executor_executes_allowed_plugin_tools() {
|
|
||||||
let script = temp_path("subagent-plugin-tool.sh");
|
|
||||||
std::fs::write(
|
|
||||||
&script,
|
|
||||||
"#!/bin/sh\nINPUT=$(cat)\nprintf '{\"tool\":\"%s\",\"input\":%s}\\n' \"$CLAWD_TOOL_NAME\" \"$INPUT\"\n",
|
|
||||||
)
|
|
||||||
.expect("write script");
|
|
||||||
make_executable(&script);
|
|
||||||
|
|
||||||
let registry = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "plugin_echo".to_string(),
|
|
||||||
description: Some("Echo plugin input".to_string()),
|
|
||||||
input_schema: json!({
|
|
||||||
"type": "object",
|
|
||||||
"properties": { "message": { "type": "string" } },
|
|
||||||
"required": ["message"],
|
|
||||||
"additionalProperties": false
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
script.display().to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::WorkspaceWrite,
|
|
||||||
script.parent().map(PathBuf::from),
|
|
||||||
)])
|
|
||||||
.expect("registry should build");
|
|
||||||
|
|
||||||
let mut executor =
|
|
||||||
SubagentToolExecutor::new(BTreeSet::from([String::from("plugin_echo")]), registry);
|
|
||||||
let output = executor
|
|
||||||
.execute("plugin-echo", r#"{"message":"hello"}"#)
|
|
||||||
.expect("plugin tool should execute for subagent");
|
|
||||||
let payload: serde_json::Value = serde_json::from_str(&output).expect("valid json");
|
|
||||||
assert_eq!(payload["tool"], "plugin_echo");
|
|
||||||
assert_eq!(payload["input"]["message"], "hello");
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(script);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn global_registry_rejects_conflicting_plugin_tool_names() {
|
|
||||||
let error = GlobalToolRegistry::with_plugin_tools(vec![PluginTool::new(
|
|
||||||
"demo@external",
|
|
||||||
"demo",
|
|
||||||
PluginToolDefinition {
|
|
||||||
name: "read-file".to_string(),
|
|
||||||
description: Some("Conflicts with builtin".to_string()),
|
|
||||||
input_schema: json!({ "type": "object" }),
|
|
||||||
},
|
|
||||||
"echo".to_string(),
|
|
||||||
Vec::new(),
|
|
||||||
PluginToolPermission::ReadOnly,
|
|
||||||
None,
|
|
||||||
)])
|
|
||||||
.expect_err("conflicting plugin tool should fail");
|
|
||||||
|
|
||||||
assert!(error.contains("conflicts with already-registered tool `read_file`"));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn web_fetch_returns_prompt_aware_summary() {
|
fn web_fetch_returns_prompt_aware_summary() {
|
||||||
let server = TestServer::spawn(Arc::new(|request_line: &str| {
|
let server = TestServer::spawn(Arc::new(|request_line: &str| {
|
||||||
@@ -3595,6 +3125,63 @@ mod tests {
|
|||||||
assert!(error.contains("relative URL without a base") || error.contains("empty host"));
|
assert!(error.contains("relative URL without a base") || error.contains("empty host"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn pending_tools_preserve_multiple_streaming_tool_calls_by_index() {
|
||||||
|
let mut events = Vec::new();
|
||||||
|
let mut pending_tools = BTreeMap::new();
|
||||||
|
|
||||||
|
push_output_block(
|
||||||
|
OutputContentBlock::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "read_file".to_string(),
|
||||||
|
input: json!({}),
|
||||||
|
},
|
||||||
|
1,
|
||||||
|
&mut events,
|
||||||
|
&mut pending_tools,
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
push_output_block(
|
||||||
|
OutputContentBlock::ToolUse {
|
||||||
|
id: "tool-2".to_string(),
|
||||||
|
name: "grep_search".to_string(),
|
||||||
|
input: json!({}),
|
||||||
|
},
|
||||||
|
2,
|
||||||
|
&mut events,
|
||||||
|
&mut pending_tools,
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
|
||||||
|
pending_tools
|
||||||
|
.get_mut(&1)
|
||||||
|
.expect("first tool pending")
|
||||||
|
.2
|
||||||
|
.push_str("{\"path\":\"src/main.rs\"}");
|
||||||
|
pending_tools
|
||||||
|
.get_mut(&2)
|
||||||
|
.expect("second tool pending")
|
||||||
|
.2
|
||||||
|
.push_str("{\"pattern\":\"TODO\"}");
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
pending_tools.remove(&1),
|
||||||
|
Some((
|
||||||
|
"tool-1".to_string(),
|
||||||
|
"read_file".to_string(),
|
||||||
|
"{\"path\":\"src/main.rs\"}".to_string(),
|
||||||
|
))
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
pending_tools.remove(&2),
|
||||||
|
Some((
|
||||||
|
"tool-2".to_string(),
|
||||||
|
"grep_search".to_string(),
|
||||||
|
"{\"pattern\":\"TODO\"}".to_string(),
|
||||||
|
))
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn todo_write_persists_and_returns_previous_state() {
|
fn todo_write_persists_and_returns_previous_state() {
|
||||||
let _guard = env_lock()
|
let _guard = env_lock()
|
||||||
@@ -4005,11 +3592,8 @@ mod tests {
|
|||||||
calls: 0,
|
calls: 0,
|
||||||
input_path: path.display().to_string(),
|
input_path: path.display().to_string(),
|
||||||
},
|
},
|
||||||
SubagentToolExecutor::new(
|
SubagentToolExecutor::new(BTreeSet::from([String::from("read_file")])),
|
||||||
BTreeSet::from([String::from("read_file")]),
|
agent_permission_policy(),
|
||||||
GlobalToolRegistry::builtin(),
|
|
||||||
),
|
|
||||||
agent_permission_policy(&GlobalToolRegistry::builtin()),
|
|
||||||
vec![String::from("system prompt")],
|
vec![String::from("system prompt")],
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -4035,42 +3619,6 @@ mod tests {
|
|||||||
let _ = std::fs::remove_file(path);
|
let _ = std::fs::remove_file(path);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn response_to_events_ignores_thinking_blocks() {
|
|
||||||
let events = response_to_events(MessageResponse {
|
|
||||||
id: "msg-1".to_string(),
|
|
||||||
kind: "message".to_string(),
|
|
||||||
model: "claude-opus-4-6".to_string(),
|
|
||||||
role: "assistant".to_string(),
|
|
||||||
content: vec![
|
|
||||||
OutputContentBlock::Thinking {
|
|
||||||
thinking: "step 1".to_string(),
|
|
||||||
signature: Some("sig_123".to_string()),
|
|
||||||
},
|
|
||||||
OutputContentBlock::Text {
|
|
||||||
text: "Final answer".to_string(),
|
|
||||||
},
|
|
||||||
],
|
|
||||||
stop_reason: Some("end_turn".to_string()),
|
|
||||||
stop_sequence: None,
|
|
||||||
usage: Usage {
|
|
||||||
input_tokens: 1,
|
|
||||||
output_tokens: 1,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
},
|
|
||||||
request_id: None,
|
|
||||||
});
|
|
||||||
|
|
||||||
assert!(matches!(
|
|
||||||
&events[0],
|
|
||||||
AssistantEvent::TextDelta(text) if text == "Final answer"
|
|
||||||
));
|
|
||||||
assert!(!events
|
|
||||||
.iter()
|
|
||||||
.any(|event| matches!(event, AssistantEvent::ToolUse { .. })));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn agent_rejects_blank_required_fields() {
|
fn agent_rejects_blank_required_fields() {
|
||||||
let missing_description = execute_tool(
|
let missing_description = execute_tool(
|
||||||
@@ -4495,19 +4043,19 @@ mod tests {
|
|||||||
));
|
));
|
||||||
let home = root.join("home");
|
let home = root.join("home");
|
||||||
let cwd = root.join("cwd");
|
let cwd = root.join("cwd");
|
||||||
std::fs::create_dir_all(home.join(".claw")).expect("home dir");
|
std::fs::create_dir_all(home.join(".claude")).expect("home dir");
|
||||||
std::fs::create_dir_all(cwd.join(".claw")).expect("cwd dir");
|
std::fs::create_dir_all(cwd.join(".claude")).expect("cwd dir");
|
||||||
std::fs::write(
|
std::fs::write(
|
||||||
home.join(".claw").join("settings.json"),
|
home.join(".claude").join("settings.json"),
|
||||||
r#"{"verbose":false}"#,
|
r#"{"verbose":false}"#,
|
||||||
)
|
)
|
||||||
.expect("write global settings");
|
.expect("write global settings");
|
||||||
|
|
||||||
let original_home = std::env::var("HOME").ok();
|
let original_home = std::env::var("HOME").ok();
|
||||||
let original_claw_home = std::env::var("CLAW_CONFIG_HOME").ok();
|
let original_claude_home = std::env::var("CLAUDE_CONFIG_HOME").ok();
|
||||||
let original_dir = std::env::current_dir().expect("cwd");
|
let original_dir = std::env::current_dir().expect("cwd");
|
||||||
std::env::set_var("HOME", &home);
|
std::env::set_var("HOME", &home);
|
||||||
std::env::remove_var("CLAW_CONFIG_HOME");
|
std::env::remove_var("CLAUDE_CONFIG_HOME");
|
||||||
std::env::set_current_dir(&cwd).expect("set cwd");
|
std::env::set_current_dir(&cwd).expect("set cwd");
|
||||||
|
|
||||||
let get = execute_tool("Config", &json!({"setting": "verbose"})).expect("get config");
|
let get = execute_tool("Config", &json!({"setting": "verbose"})).expect("get config");
|
||||||
@@ -4540,9 +4088,9 @@ mod tests {
|
|||||||
Some(value) => std::env::set_var("HOME", value),
|
Some(value) => std::env::set_var("HOME", value),
|
||||||
None => std::env::remove_var("HOME"),
|
None => std::env::remove_var("HOME"),
|
||||||
}
|
}
|
||||||
match original_claw_home {
|
match original_claude_home {
|
||||||
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
|
Some(value) => std::env::set_var("CLAUDE_CONFIG_HOME", value),
|
||||||
None => std::env::remove_var("CLAW_CONFIG_HOME"),
|
None => std::env::remove_var("CLAUDE_CONFIG_HOME"),
|
||||||
}
|
}
|
||||||
let _ = std::fs::remove_dir_all(root);
|
let _ = std::fs::remove_dir_all(root);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user